From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3078A0547 for ; Fri, 12 Mar 2021 06:58:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E427816085F; Fri, 12 Mar 2021 06:58:32 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id A94CE160839 for ; Fri, 12 Mar 2021 06:58:27 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id q5so2508460pgk.5 for ; Thu, 11 Mar 2021 21:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=Z7x2kWbzI8+2GTHRvgIVKXzecWX6O+YB+XqnRwXJJUQ=; b=MVK5t3NQt/LfHNfpzjDvUZVixma8+0j3YQAvEBDfbzyfc3IQrtMHTp/W/XnLHj6+8a CwVuiGMd7RyIhZSF0LzePZrimPswwLcl3HmN/DPjkn0rJi0r6DERgG+CM5VOPK80obZl b6o2JF6eD6Uq94AFBnoyyMG8+vnNoBT3/YTo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=Z7x2kWbzI8+2GTHRvgIVKXzecWX6O+YB+XqnRwXJJUQ=; b=UdNTDaq86Yfhouu8tb7zVORAiAZ0ajDOD4trRfOgMerRaCxxQVMENnUa3u5EIXyefk uN5oQB/v7fmO1TpT+cA7tqsDfn3DN3SwNYTxY9NBbNXn5IyJE2fKnXHLjt2QyXx0N5Ca hOz/bXryRvqRTRXAJVjmrdtxCNRcgEwp1JlebzJ+DxpTPqpS0CGEalFGYh4oSX6VAeiZ rNROSM/BM9NWLUONeqYA6+dxka4dCiWXK1kMPWv/VSMvXahz9zGK5yeNxzVO5y5GsdO9 C3QrNmZ68YCuD7IeDZfhDcbb/32Dkl/KACZwJexrJ8JFf88lxvUXF4LUklZoW/Ud6k/H 0tRw== X-Gm-Message-State: AOAM533DtE/IB35fz40/RzPqgVIAka8cInKT5k00cjYAi1RhfjpEg+uk QYSDRsoE8h97Z31OtSBa/HtpeQ== X-Google-Smtp-Source: ABdhPJxhGjnvPKd0yIGgWVAlxjbNRVx/LoR2pKLdDDD75QRrmSdEI70mf7aVePSVEcDDHMdkcYykrA== X-Received: by 2002:a63:d40b:: with SMTP id a11mr10144941pgh.192.1615528706727; Thu, 11 Mar 2021 21:58:26 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 186sm4413173pfb.143.2021.03.11.21.58.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Mar 2021 21:58:26 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Kalesh AP , stable@dpdk.org Date: Thu, 11 Mar 2021 21:58:10 -0800 Message-Id: <20210312055819.52789-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210312055819.52789-1-ajit.khaparde@broadcom.com> References: <20210312055819.52789-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000b5b7a505bd5096a0" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH v3 03/12] net/bnxt: fix VNIC configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --000000000000b5b7a505bd5096a0 Content-Transfer-Encoding: 8bit From: Kalesh AP PMD should not set any flags to receive RoCE traffic while configuring the vnic. Since the PMD does not support RoCE some of the flags and code is unused. Clean it up. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 ---------- drivers/net/bnxt/bnxt_vnic.h | 2 -- 2 files changed, 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cb8baa8776..5366fe72ca 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2013,12 +2013,6 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic) if (vnic->bd_stall) req.flags |= rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_BD_STALL_MODE); - if (vnic->roce_dual) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE); - if (vnic->roce_only) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE); if (vnic->rss_dflt_cr) req.flags |= rte_cpu_to_le_32( HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE); @@ -2066,10 +2060,6 @@ int bnxt_hwrm_vnic_qcfg(struct bnxt *bp, struct bnxt_vnic_info *vnic, HWRM_VNIC_QCFG_OUTPUT_FLAGS_VLAN_STRIP_MODE; vnic->bd_stall = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_BD_STALL_MODE; - vnic->roce_dual = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE; - vnic->roce_only = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE; vnic->rss_dflt_cr = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE; diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 917b909284..00a664c8b8 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -52,8 +52,6 @@ struct bnxt_vnic_info { bool vlan_strip; bool func_default; bool bd_stall; - bool roce_dual; - bool roce_only; bool rss_dflt_cr; STAILQ_HEAD(, bnxt_filter_info) filter; -- 2.21.1 (Apple Git-122.3) --000000000000b5b7a505bd5096a0--