From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8655AA054F
	for <public@inbox.dpdk.org>; Wed, 17 Mar 2021 16:15:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 729C1140E9D;
	Wed, 17 Mar 2021 16:15:58 +0100 (CET)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 7E7454014D;
 Wed, 17 Mar 2021 16:15:56 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id B69485C0329;
 Wed, 17 Mar 2021 11:15:55 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 17 Mar 2021 11:15:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding; s=fm3; bh=pxxQtFbdxMNekmIhO6oDr/Vfum
 qoAB2smt7JOgTw+qU=; b=EWyKVdd7ylmkdYZtsGk3OgYwPhW1ZI5GW7p1MWUZZ8
 GAtXWdPJyabXZNHGEnY2IsAAXG/qRaWhSJYAPiyhqUdoIDA6jaLdjsLyT1RwVAiu
 p0oi+lnbHAu7dCpkxhj9EMrVr6WbpcIZLJ3hCwDCKjMRy2TnUPA4O9Hji6TMaB0S
 iTsr4XTrmJuGBuLSlzXYVTJfJbn+3o45/wPEb9qotfZXdFvtdjYasIllZD4t3RgU
 u6eY8RGKY+F3dZhH5GAfcp7OOC1UfrC1lBUAa1JZjYB3y0vsRNfSFZdjA1sYsCHZ
 nMcAZ+0AGgZaEo+zz5cX2yh0VyY6r0Gl+vw1BxxNa39Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:date:from
 :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pxxQtFbdxMNekmIhO
 6oDr/VfumqoAB2smt7JOgTw+qU=; b=sMPXWvNQet/qMBNGHfIjkfP7i3ww28MzB
 NSS4bheOvN3oDyz8j2zgNi2EUcNbmNGf240HC4oj8IFvHkY4OUUsNDVU5SM3/A37
 /M7RgO84dSA93GLlQd+1TfeLawsZujD1hs2Cfs0hVXuCzCIDGVrcqEDIEd3jG1Oh
 zsD6bwgyIVDUbKDd8f+jvlqVzU63EHTk/crclE7t+eoJmWCI5ndxLBk2oOWLauQ9
 G8jWdczrp7uVt8K35a5u5Z0hE8Yz+YSLScRjIGhjCMlf23L+S/rwyczOsLlzM811
 ak18726Bne92txlS4/Qe2YPAiVloKrtjiOnzkwl5rAm3B2hZZXxpA==
X-ME-Sender: <xms:Kh1SYNjCkcoJYifpnWqUDxza__TDykWbn7kVIM93IYLtANlPP7adHQ>
 <xme:Kh1SYCAiNGygx7UxU2XHxSaZNUYonMsp3nZUj_7hs-n0haMpXoY_JSZdf_UScCNf0
 agc344aKO2dG1xbKA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefgedgjeejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu
 ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf
 grthhtvghrnhepvdelvdduhedvudduveeuvdevheegudelgeeigfejheduhedttdegudff
 jeeihffgnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiii
 gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn
 rdhnvght
X-ME-Proxy: <xmx:Kh1SYNGfuxWY17TiQIl5wMRVlhuvpc6_CH4CV3loLLNkuKcSWFI6Ag>
 <xmx:Kh1SYCQ-CKp50ZLq2_C2vvBRVD8jjAuxWBmIgL1VbWJp6Zi003BZRA>
 <xmx:Kh1SYKyRyor8mYIro5cUXD5-pHND_FlhYuwMa7wl9LNFK0pr-MFZBw>
 <xmx:Kx1SYO8TGX-NCtiKXzUBJ67gSSLMpVaIzVNpFzLj5TO_fMJhU_2PtA>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 9BDF91080064;
 Wed, 17 Mar 2021 11:15:53 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, David Marchand <david.marchand@redhat.com>,
 Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 Bruce Richardson <bruce.richardson@intel.com>
Date: Wed, 17 Mar 2021 16:15:35 +0100
Message-Id: <20210317151535.1412311-1-thomas@monjalon.net>
X-Mailer: git-send-email 2.30.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH] eal: mark version parts API as experimental
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

Some functions were introduced in DPDK 21.05 to query the version parts
(prefix, year, month, minor, suffix, release) at runtime.
Per guidelines, these new public functions must be marked with
__rte_experimental and ABI versioned as EXPERIMENTAL.

Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime")
Cc: stable@dpdk.org

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/include/rte_version.h |  7 +++++++
 lib/librte_eal/version.map           | 14 ++++++++------
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h
index 736c5703be..b06a62e7a2 100644
--- a/lib/librte_eal/include/rte_version.h
+++ b/lib/librte_eal/include/rte_version.h
@@ -18,6 +18,7 @@ extern "C" {
 #include <string.h>
 #include <stdio.h>
 #include <rte_common.h>
+#include <rte_compat.h>
 
 /**
  * Macro to compute a version number usable for comparisons
@@ -36,31 +37,37 @@ extern "C" {
 /**
  * Function to return DPDK version prefix string
  */
+__rte_experimental
 const char *rte_version_prefix(void);
 
 /**
  * Function to return DPDK version year
  */
+__rte_experimental
 unsigned int rte_version_year(void);
 
 /**
  * Function to return DPDK version month
  */
+__rte_experimental
 unsigned int rte_version_month(void);
 
 /**
  * Function to return DPDK minor version number
  */
+__rte_experimental
 unsigned int rte_version_minor(void);
 
 /**
  * Function to return DPDK version suffix for any release candidates
  */
+__rte_experimental
 const char *rte_version_suffix(void);
 
 /**
  * Function to return DPDK version release candidate value
  */
+__rte_experimental
 unsigned int rte_version_release(void);
 
 /**
diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map
index 756c60ed1d..48a2b55d57 100644
--- a/lib/librte_eal/version.map
+++ b/lib/librte_eal/version.map
@@ -200,12 +200,6 @@ DPDK_21 {
 	rte_uuid_parse;
 	rte_uuid_unparse;
 	rte_version;
-	rte_version_minor;
-	rte_version_month;
-	rte_version_prefix;
-	rte_version_release;
-	rte_version_suffix;
-	rte_version_year;
 	rte_vfio_clear_group;
 	rte_vfio_container_create;
 	rte_vfio_container_destroy;
@@ -419,6 +413,14 @@ EXPERIMENTAL {
 	rte_thread_tls_key_delete;
 	rte_thread_tls_value_get;
 	rte_thread_tls_value_set;
+
+	# added in 21.05
+	rte_version_minor;
+	rte_version_month;
+	rte_version_prefix;
+	rte_version_release;
+	rte_version_suffix;
+	rte_version_year;
 };
 
 INTERNAL {
-- 
2.30.1