From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2E75A0561 for ; Thu, 18 Mar 2021 01:47:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9A3740683; Thu, 18 Mar 2021 01:47:37 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 5616340683 for ; Thu, 18 Mar 2021 01:47:36 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id c204so2293474pfc.4 for ; Wed, 17 Mar 2021 17:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=8p6PrhPQ070nkHZeBE7VmYZnnatZfsXASNcR+4tOi3M=; b=WcKcvmN+00xw0B/5Q/GyatVRo7FnyWVS7+S1BfGCarJjFj8T0de43bNrw/ut9PBYcj UA0aOnbaG+izkO1VElYnmEHRBT17kIcvPLCvKvtHMG0jAIH0Q5f/XzVs60eBQmkI7jXD pw+78tEfsO7b85c/cEFrjLmaJzYGjm+pJxojY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=8p6PrhPQ070nkHZeBE7VmYZnnatZfsXASNcR+4tOi3M=; b=ewrTQm+6Svb6q4MzN4sWOz3SMLwPkaAk+EnsJoAuj+s5ta2yx6ISXnoJOh0O14zQys VDgiwyWL/82F3CYJoV025QM5Ei8g2Id5DP+YKk2J9WdbxEJUJVGfkfyYfiCnojplaHw7 /OxDGdhzDzEhorfASndkIg5iHdXCta1MxFjK/gThXL/9eTlLM+r+Eml069O+J6Dym4cP 9KdoCbuaDfn9hfGCPYkefpRn3ScK7SIlqFKTlzdubTgsIfULBV5ZWDQOzgL2Ud+yDIZ1 JsomoUnv9a6kmLDWVe38jbG8vptgLh+IexzZjOpE6Ao5D46pA5zYHcrHjZC0MtbuMUaf S2/Q== X-Gm-Message-State: AOAM533bfZ/6RUY9qXleqpCC1AlWKpRw5ONm2Bwc+POLOxCDId/l9q45 mMrci//VER03ydpp2wG7UWm45g== X-Google-Smtp-Source: ABdhPJy/jHmoqhb9+hR56sdPQdRFGDlf8k8MUZRj7+96TC2dUK71FwLiNKI/JqD0Z1k3/URh5RfLVA== X-Received: by 2002:a63:1d01:: with SMTP id d1mr4602790pgd.361.1616028455295; Wed, 17 Mar 2021 17:47:35 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id f11sm217846pga.34.2021.03.17.17.47.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Mar 2021 17:47:34 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org Date: Wed, 17 Mar 2021 17:47:30 -0700 Message-Id: <20210318004730.24360-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000d376105bdc4f273" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH] net/bnxt: fix RSS context cleanup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000000d376105bdc4f273 Content-Transfer-Encoding: 8bit The PMD is allocating an extra RSS context with each port start. But it is freeing only one RSS context during port stop. So at some point we run out of RSS contexts when we do multiple port stop/start sequences. bnxt_hwrm_vnic_ctx_alloc() is called by bnxt_setup_one_vnic(), but bnxt_hwrm_vnic_ctx_free() is not called in the corresponding bnxt_free_one_vnic(). Fix this by calling bnxt_hwrm_vnic_ctx_free() in bnxt_free_one_vnic(). Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 1997783a7d..ff92f999db 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2531,6 +2531,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) } bnxt_del_dflt_mac_filter(bp, vnic); + rc = bnxt_hwrm_vnic_ctx_free(bp, vnic); + if (rc) + return rc; + rc = bnxt_hwrm_vnic_free(bp, vnic); if (rc) return rc; -- 2.21.1 (Apple Git-122.3) --0000000000000d376105bdc4f273--