From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C054A0562 for ; Thu, 18 Mar 2021 13:28:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C435140EBD; Thu, 18 Mar 2021 13:28:37 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3E11C40698; Thu, 18 Mar 2021 13:28:34 +0100 (CET) IronPort-SDR: E+xayiHTNkeOMQiSTFQGVu3s8KoHPsHuiRasR80shIcFjSV07HOajG5o2DzzSQjAgZ9z1Z3DO1 eVYA4XlKxdDA== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="176794317" X-IronPort-AV: E=Sophos;i="5.81,258,1610438400"; d="scan'208";a="176794317" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 05:28:33 -0700 IronPort-SDR: /tUlEHAxO1+EvcU8mU36AE2tpOaFE3ROhFCu5IFCNPvuK6FebOweIrqjJFXBxIWw22uqRMt/qe ua7eenw155LA== X-IronPort-AV: E=Sophos;i="5.81,258,1610438400"; d="scan'208";a="450464512" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.13.177]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Mar 2021 05:28:31 -0700 Date: Thu, 18 Mar 2021 12:28:27 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , dev , dpdk stable Message-ID: <20210318122827.GB1633@bricha3-MOBL.ger.corp.intel.com> References: <20210317093124.965624-1-thomas@monjalon.net> <10994121.sJyVhAAg4N@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10994121.sJyVhAAg4N@thomas> Subject: Re: [dpdk-stable] [PATCH] eal: fix version macro X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Mar 17, 2021 at 11:01:25AM +0100, Thomas Monjalon wrote: > 17/03/2021 10:48, David Marchand: > > On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > > > > > The macro RTE_VERSION is broken since updated with function calls. > > > It is a build-time version number, and must be built with macros. > > > For a run-time version number, there is the function rte_version(). > > > > > > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > > > Cc: stable@dpdk.org > > > > > > Reported-by: David Marchand > > > Signed-off-by: Thomas Monjalon > > > --- > > > lib/librte_eal/include/rte_version.h | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h > > > index 2f3f727b46..736c5703be 100644 > > > --- a/lib/librte_eal/include/rte_version.h > > > +++ b/lib/librte_eal/include/rte_version.h > > > @@ -28,10 +28,10 @@ extern "C" { > > > * All version numbers in one to compare with RTE_VERSION_NUM() > > > */ > > > #define RTE_VERSION RTE_VERSION_NUM( \ > > > - rte_version_year(), \ > > > - rte_version_month(), \ > > > - rte_version_minor(), \ > > > - rte_version_release()) > > > + RTE_VER_YEAR, \ > > > + RTE_VER_MONTH, \ > > > + RTE_VER_MINOR, \ > > > + RTE_VER_RELEASE) > > > > > > /** > > > * Function to return DPDK version prefix string > > > > The original patch wanted to fix rte_version() at runtime. > > I don't see the need to keep the rte_version_XXX exports now that > > RTE_VERSION is reverted. > > I think it may help to query the version numbers at runtime, > in "if" condition. Is there another way I'm missing? > We may argue that the runtime version number should not be used > to decide how to behave in an application. > I would also tend toward keeping them, for the same reason that runtime is definitely to be preferred over build time, and they are not like to be much of a maintenance burden. Also, next time we have an ABI break, I wonder if the existing macros should be renamed to have an RTE_BUILD_VER_ prefix, to make it clear that it's the build version only that is being reported rather than the version actually being used. Similarly the functions could be renamed to have rte_runtime_ prefix, ensuring that in all cases the user is clear whether they are getting the build version or the runtime version. /Bruce