patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <>
	Gabriel Ganne <>,, Harry van Haaren <>,
	Luca Boccassi <>,
	Keith Wiles <>
Subject: [dpdk-stable] [PATCH v5] build: remove redundant libpcap link
Date: Fri,  9 Apr 2021 14:25:51 +0200
Message-ID: <> (raw)
In-Reply-To: <>

From: Gabriel Ganne <>

The pcap PMD and the librte_port both declare their dependency to libpcap
with a line "ext_deps += pcap_dep".
Then meson automatically adds this dependency to the pkg-config file
in the "Requires.private" section for static builds.

The additional update of dpdk_extra_ldflags was adding the dependency
in the "Libs.private" section of the pkg-config, that is unnecessary.

Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
Fixes: 268fa581b1ff ("port: fix pcap support with meson")

Signed-off-by: Gabriel Ganne <>
Signed-off-by: Thomas Monjalon <>
I have a doubt whether this option is really always useless.
In the case of an old pcap (<1.9) without pkg-config support,
and with the minimum meson supported (0.47.1),
are we sure the generated pkg-config file will include -lpcap?
 config/ | 1 -
 1 file changed, 1 deletion(-)

diff --git a/config/ b/config/
index 66a2edcc47..95777cf331 100644
--- a/config/
+++ b/config/
@@ -183,7 +183,6 @@ if not pcap_dep.found()
 if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
 	dpdk_conf.set('RTE_PORT_PCAP', 1)
-	dpdk_extra_ldflags += '-lpcap'
 # for clang 32-bit compiles we need libatomic for 64-bit atomic ops

       reply	other threads:[~2021-04-09 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2021-04-09 12:25 ` Thomas Monjalon [this message]
2021-04-14  9:41   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-04-14 21:02     ` Dmitry Kozlyuk
2021-04-14 21:10       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone