From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 00580A0A0C
for <public@inbox.dpdk.org>; Thu, 15 Apr 2021 07:39:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E63B0161FC3;
Thu, 15 Apr 2021 07:39:47 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by mails.dpdk.org (Postfix) with ESMTP id 600D3161FC3;
Thu, 15 Apr 2021 07:39:47 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CEE2711B3;
Wed, 14 Apr 2021 22:39:46 -0700 (PDT)
Received: from wls-arm-cavium06.shanghai.arm.com
(wls-arm-cavium06.shanghai.arm.com [10.169.206.120])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BAAD43F792;
Wed, 14 Apr 2021 22:39:44 -0700 (PDT)
From: Richael Zhuang <richael.zhuang@arm.com>
To: dev@dpdk.org
Cc: nd@arm.com, alan.carew@intel.com, stable@dpdk.org,
David Hunt <david.hunt@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Thu, 15 Apr 2021 13:39:23 +0800
Message-Id: <20210415053923.3447-3-richael.zhuang@arm.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210415053923.3447-1-richael.zhuang@arm.com>
References: <20210407074636.26891-2-richael.zhuang@arm.com>
<20210415053923.3447-1-richael.zhuang@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH v4 2/2] test/power: add delay before checking
cpuinfo cur freq
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
For some platforms the newly-set frequency may not be effective
immediately. If we didn't get the right value from cpuinfo_cur_freq
immediately, add 10ms delay each time before rechecking until
timeout.
>From our test, for some arm platforms, it requires up to 700ms when
going from a minimum to a maximum frequency. And it's not the
driver/software issue.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.carew@intel.com
Cc: stable@dpdk.org
Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
---
app/test/test_power_cpufreq.c | 25 ++++++++++++++++++++++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index 1f4d8bb05..25249ecf5 100644
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -8,6 +8,7 @@
#include <limits.h>
#include <string.h>
#include <inttypes.h>
+#include <rte_cycles.h>
#include "test.h"
@@ -48,11 +49,13 @@ static int
check_cur_freq(unsigned lcore_id, uint32_t idx)
{
#define TEST_POWER_CONVERT_TO_DECIMAL 10
+#define MAX_LOOP 100
FILE *f;
char fullpath[PATH_MAX];
char buf[BUFSIZ];
uint32_t cur_freq;
int ret = -1;
+ int i;
if (snprintf(fullpath, sizeof(fullpath),
TEST_POWER_SYSFILE_CUR_FREQ, lcore_id) < 0) {
@@ -62,8 +65,24 @@ check_cur_freq(unsigned lcore_id, uint32_t idx)
if (f == NULL) {
return 0;
}
- if (fgets(buf, sizeof(buf), f) == NULL) {
- goto fail_get_cur_freq;
+ for (i = 0; i < MAX_LOOP; i++) {
+ fflush(f);
+ if (fgets(buf, sizeof(buf), f) == NULL)
+ goto fail_all;
+
+ cur_freq = strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL);
+ ret = (freqs[idx] == cur_freq ? 0 : -1);
+
+ if (ret == 0)
+ break;
+
+ if (fseek(f, 0, SEEK_SET) < 0) {
+ printf("Fail to set file position indicator to 0\n");
+ goto fail_all;
+ }
+
+ /* wait for the value to be updated */
+ rte_delay_ms(10);
}
cur_freq = strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL);
@@ -78,7 +97,7 @@ check_cur_freq(unsigned lcore_id, uint32_t idx)
ret = (freqs[idx] == freq_conv ? 0 : -1);
-fail_get_cur_freq:
+fail_all:
fclose(f);
return ret;
--
2.20.1