patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Alvin Zhang <alvinx.zhang@intel.com>
To: jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, Alvin Zhang <alvinx.zhang@intel.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] net/i40e: fix offload flag checking in simple Tx datapath
Date: Tue, 27 Apr 2021 16:58:59 +0800	[thread overview]
Message-ID: <20210427085859.22376-1-alvinx.zhang@intel.com> (raw)

For Tx packets, if no other offload flag except
'PKT_TX_OUTER_IPV6, PKT_TX_OUTER_IPV4, PKT_TX_IPV6, PKT_TX_IPV4' is
set, the hardware doesn't need to do offloads for these packets.

This patch removes those previously indicated flags from the offload
flag checking in simple Tx datapath.

Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx datapath")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/i40e/i40e_rxtx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 86a9eae..48d0582 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1501,7 +1501,9 @@
 			return i;
 		}
 
-		if (ol_flags & PKT_TX_OFFLOAD_MASK) {
+		if (ol_flags & PKT_TX_OFFLOAD_MASK &
+		    ~(PKT_TX_OUTER_IPV6 | PKT_TX_OUTER_IPV4 |
+		      PKT_TX_IPV6 | PKT_TX_IPV4)) {
 			rte_errno = ENOTSUP;
 			return i;
 		}
-- 
1.8.3.1


             reply	other threads:[~2021-04-27  8:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27  8:58 Alvin Zhang [this message]
2021-05-06  5:32 ` [dpdk-stable] [dpdk-dev] " Zhou, JunX W
2021-05-10  3:27 ` Rong, Leyi
2021-05-11  2:39 ` [dpdk-stable] [PATCH v2] " Alvin Zhang
2021-05-11  8:08   ` Rong, Leyi
2021-05-11  8:45   ` [dpdk-stable] [PATCH v3] " Alvin Zhang
2021-05-11  9:20     ` Rong, Leyi
2021-05-12  8:48       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210427085859.22376-1-alvinx.zhang@intel.com \
    --to=alvinx.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).