From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6728DA0A0E for ; Mon, 10 May 2021 18:14:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C58240140; Mon, 10 May 2021 18:14:56 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2069.outbound.protection.outlook.com [40.107.92.69]) by mails.dpdk.org (Postfix) with ESMTP id 8BD2D410F8 for ; Mon, 10 May 2021 18:14:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLHrdefiI8IBz6LVdrtbAIEkem0HeUeqsPncjZEXhf4y1hCDE5wIqTXW/WVJhJJPXrFt59Qf0T/JcEsfwJIRIOOK1f/xBJF/gThdSfQ4S9+sol0sSfGGqSg50Gff6UQvSI/nRXBSIL+EpWkoq9l5wgBIXDa88pcdUDmLsV/MEKABxsdzUIX5baqXcks5pbkc+TazmCm2+KS7FBSiEBh8RLXdUfWlloN//aWxemTFN19acnenhxcRnP7xYmBxmYxpcpTyGmVRmoxQbK2CgsmvZN1RIaw4KOQ3pL9OOyrgP2i7R2Y/wn6NqVKF7dkn9GvoR1PtRSHKxyVFZmOnXBj5Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xnh2OPiYsTNYpghTO2kdhAzmW9Q8E4khqX3psU9d6B0=; b=fdr1HNvMHmXWxm7qAAOS+/xIwFA2HteiqB9bBHuakGhl0e6NKitstQQqhZogWIK72KUUxzxtdeyT5JXMnnbQe33gTvE5mrct3GwMJxpmg1QjhsvfSCshj7OW6xCPnUTyXx/qdjApo3qwc3FOaPrnTP3rudBnx9r8hjt7uHZLgb/oYg7TLj0Ldf18baUtC7K4CvqrAYGvdqoU4XJZUzfI7PTZ3HYlgzhQOgQ+lJXmNIbRENQZmz74XW/+X67tkPSitmUmehWVohIl7uRTdz+3+s4R/ueuy7fGtiAJjUc46NL4Rf+/RXMqu1fUsgRscHt4FtYWYBROWtt2mSDEvkTcDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xnh2OPiYsTNYpghTO2kdhAzmW9Q8E4khqX3psU9d6B0=; b=FIq+YQtbvkJqKziPCQUeo/qwvEFOJO22SnYNe9SI4SI+8kP4H+ZwokGVw65SputSVxso1+/XDcHQYQp5blHwGCb8IoAOdKmAE/Q9kB8iSPirHvAckg6XRf+XFEwErV2jawhT3O7Cgdp9S81oAP9yf/BQpR30vxLdUmJVPxXhGMIEG8fInvA8oxb0ajunpKb8j4ZI/igTrV7J//+EmEdScPZF7RqUvQJXB7L52apnwI4RksiCyOXhQgafDLUQXX7WKnzjLvVPigXTmxKkhg10lPsoDzlfeJGbjJIjqMRwx/TQJ0p7hT+j+TajB6UiV7ohco/UlsGbgI8EgKv2KOJ7YA== Received: from MW2PR2101CA0011.namprd21.prod.outlook.com (2603:10b6:302:1::24) by BN6PR1201MB2466.namprd12.prod.outlook.com (2603:10b6:404:b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Mon, 10 May 2021 16:14:53 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:302:1:cafe::2a) by MW2PR2101CA0011.outlook.office365.com (2603:10b6:302:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.0 via Frontend Transport; Mon, 10 May 2021 16:14:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:14:53 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:14:50 +0000 From: Xueming Li To: Murphy Yang CC: Luca Boccassi , Haiyue Wang , dpdk stable Date: Tue, 11 May 2021 00:01:06 +0800 Message-ID: <20210510160258.30982-117-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e927d70a-a2c8-41c7-e0b4-08d913cebead X-MS-TrafficTypeDiagnostic: BN6PR1201MB2466: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4nsOMpcW4lgbv/bYS3hiN9OonF3ZItVKKVK1WtBImAYdaAOTNp0KLPuqT9GK/Tvl1q1/TGv/9onsbi3f7Xt5JNe0WrW75wE97XqAufcTFWRapnz/bI2nrLo2HPYkRqoIm/Mrnrq78UyI5R++TR3ea+MXfYYOTVw+oUZbaLLy2Y0S59qbGCci6P5EbWcEngQDW+eGkHKaZzQCkgxKFJVkHHARLLzpKEx6MDeELD3+AKz63TxgZripdvNCAa1Ym7DXZJu7CoklbXCYaMI1Vgro7aWdsRuCFCgfQ6Sxn6VWVSDwGXX37z2zJhQHUsxOsYMxL0AgFtJygZ6/3W5YmJzQUTGHLf9P50+ArnmbKL/6ixZ10BZwa+qKPshh46WiE/aGTueuIKHezszmsHdeE6wfwuj4I7brTVo/UYDZai9psX4mbYGvKXYVVDFE4uEMXUTgHuix0lYKN4YEHeGvaq60YLK28yWJEU6Ra7vYP4NQi6a1fQFPBAVgzEceuS2utp2SAyP5QPoNpYRAJQiHNBXfPg+tZzg+AZ75agjSdJNLyHTkXes0UREDt9efDG5kPR+tFNxg7ixRYz4+x2WVY8VBlsb7DYJQFjXsTW5XHt9nXKn75/ra/Nih8ipmLHfWIWk8ykD7gl/ana/UkFOtNph6E4K5a4GiUQzen+jEsTvjTXDayTrhOIKAcwSY16yEotuyKTk9Q9BioEmchwawIUyzbm5q6K/eyaYbDZOiM4CwAW21nXY4+cRwlxag8JxqnjP52iGZd2fh1jqdipITVEdRQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(70206006)(70586007)(316002)(82310400003)(26005)(83380400001)(54906003)(36756003)(6916009)(8676002)(16526019)(2906002)(186003)(8936002)(36860700001)(36906005)(86362001)(47076005)(55016002)(336012)(2616005)(5660300002)(6286002)(53546011)(6666004)(426003)(1076003)(356005)(478600001)(4326008)(7636003)(966005)(82740400003)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:14:53.1813 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e927d70a-a2c8-41c7-e0b4-08d913cebead X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB2466 Subject: [dpdk-stable] patch 'net/ixgbe: fix RSS RETA being reset after port start' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/7f55ac318c25cfaa6459faaaffdc1b33d0a05e10 Thanks. Xueming Li --- >From 7f55ac318c25cfaa6459faaaffdc1b33d0a05e10 Mon Sep 17 00:00:00 2001 From: Murphy Yang Date: Mon, 29 Mar 2021 08:28:45 +0000 Subject: [PATCH] net/ixgbe: fix RSS RETA being reset after port start MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Luca Boccassi [ upstream commit 8b628c22b38f7a81b6cba677aaabd140d8583ae5 ] If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting the device (but after setting everything else), then RSS RETA configuration will be zero after starting the device. This patch gives a notification if the port not started. Bugzilla ID: 664 Fixes: 249358424eab ("ixgbe: RSS RETA configuration") Signed-off-by: Murphy Yang Acked-by: Haiyue Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index fa0f5afd03..6195c7f025 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -5007,11 +5007,19 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev, uint32_t reta, r; uint16_t idx, shift; struct ixgbe_adapter *adapter = dev->data->dev_private; + struct rte_eth_dev_data *dev_data = dev->data; struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t reta_reg; PMD_INIT_FUNC_TRACE(); + if (!dev_data->dev_started) { + PMD_DRV_LOG(ERR, + "port %d must be started before rss reta update", + dev_data->port_id); + return -EIO; + } + if (!ixgbe_rss_update_sp(hw->mac.type)) { PMD_DRV_LOG(ERR, "RSS reta update is not supported on this " "NIC."); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:29.645793200 +0800 +++ 0118-net-ixgbe-fix-RSS-RETA-being-reset-after-port-start.patch 2021-05-10 23:59:26.520000000 +0800 @@ -1 +1 @@ -From 8b628c22b38f7a81b6cba677aaabd140d8583ae5 Mon Sep 17 00:00:00 2001 +From 7f55ac318c25cfaa6459faaaffdc1b33d0a05e10 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Luca Boccassi + +[ upstream commit 8b628c22b38f7a81b6cba677aaabd140d8583ae5 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index be9c438c10..31faff066c 100644 +index fa0f5afd03..6195c7f025 100644 @@ -29 +31 @@ -@@ -5013,11 +5013,19 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev, +@@ -5007,11 +5007,19 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev,