From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8C49A0A0E for ; Mon, 10 May 2021 18:05:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC44940140; Mon, 10 May 2021 18:05:00 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2046.outbound.protection.outlook.com [40.107.102.46]) by mails.dpdk.org (Postfix) with ESMTP id 1BCE440140 for ; Mon, 10 May 2021 18:04:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOXJnJOmYCPEQrJMVhkX+HE5YC4lpXXRZ7a/XCl0HUCIAE+pjcGpmQvPaX+NCRSlAcG1/Ngd/7MqTM4bYLwS/Abr+9Eh46WFvioEaNEIPTnI3lzAPr6NNJjuH7VQPAH72u1VLMkNJi5dnXz9bapXpK8DtymP0Ba5LbRg+snmueQYTUgwtqd5ILSvR9q30r/soGPE2o9YOWR2BW1vQtYJdMi6o4hBWqGZ2BfYo7oA3EJpcLRMi/0ONewCtwQSWiwcULaz9kUysCaU21aK3JiXz2v2xZ0C7XNH3a5VICoOtCKJ+FpDXtyOiYxUj/iCzd1P/hF8NGaPkOVuayKT71pIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=APX1Gy1CUrcKw2002Ya0b6vXK1Lgsqqf2tM1w2dWC2g=; b=HcojrdHvRqWxucAFM/qvJ+OTfogXprSDjZlZBfMNeuw6OSAHsK0gywarhRhFM597UoPwUvdx7HHSgkBjfsDuEm53xcZyTE9gkyl7qWsVocWeggCHiZqY3a+kqBTk4pgbDo+7oPYHb/Qhz7gqNCSjldBdWTJJr2nPGKAffruSs1mnbWy5gItFCzp89KF0ZzNGI2+32GZ4zCEg4ib2GjPABe35KJTjVX22uGWWxZZHQ0PAb2NttUMuT85G6Nap82kTa9k2e/d2btPGyc52nQhE7xgm5C5YQr4X/o8FUYuB6ak4DlEK2y+kbOCeujMmEMiYxui6mNuDIBlpfoc1XGzIPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=APX1Gy1CUrcKw2002Ya0b6vXK1Lgsqqf2tM1w2dWC2g=; b=TV/YhksiHVtWx5gHpHA1BQY3SONrffqdf9UvrDpOUtD9/v3uTJ4jij7vRc9z82aSl5S5SI/4/nyX5uH5p5apJpwuZFQBah94lgVgyCV/ZCGBUbeepTWpTaQ0HwBgSXX1SovGmRV3q2wr9+KiYvf+lIKnjnGjmh7s8o62a4KsSJFHO0Wsx/XhL4SVjW/kWm4Zl+a0/gEDorON8JW2UejmWVji9e9GQLcQe+iohBF11RYOyt0oA2j3WVlpEju8CL36DhiOQSkUK0zUcNAmY+uUmKnlZv0ZNT8ij0D7LjczOEMiEUVxnD9fVQ+z27dlD5oHBgZEGZ8zuyC9Cymxtm5vBA== Received: from BN8PR03CA0032.namprd03.prod.outlook.com (2603:10b6:408:94::45) by CO6PR12MB5490.namprd12.prod.outlook.com (2603:10b6:303:13d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:04:57 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:94:cafe::98) by BN8PR03CA0032.outlook.office365.com (2603:10b6:408:94::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:04:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:04:56 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:04:53 +0000 From: Xueming Li To: Xiaoyun Li CC: Luca Boccassi , Ferruh Yigit , dpdk stable Date: Mon, 10 May 2021 23:59:25 +0800 Message-ID: <20210510160258.30982-16-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b99e5571-2611-4f7f-db1c-08d913cd5b5f X-MS-TrafficTypeDiagnostic: CO6PR12MB5490: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w1dulJ8yPtYuRLCSzOMqyjhE7J9c1hxSANGcIeEPpDb89fSlyPYMaN48Xs5kYl8ZRsOjiW8izh/+jO9od/3h+e3eAcSeSlAYwgWdCR6LOkk7JWGXAtDiVpSGgCaf8oO+JWloV0TWxKjKpMevh4akHQgO40Kc8zisA3fnRSvuUMp8BexWTRjvBNPK+Cqs7AxqfmoGf6W92X9URWhxBDNih44wAEHwoFmay88lwSN86uRtn8o440Nqscm1fW8MSBNHcr53PS385beNnd0mvwU7Th0uEmM3sqy3TtB0TPUEelZqdl9IJN40jg9PV+IKKfiLcq1mHTiX6ZJc63hdvjkutnKzaovuBaq8V9RE9CggVBxzGncq/OQDsrXsNyVikbVfls2tvXN/bWQmxp59ZFqLQfmZpZmn3x461Dt1k2VdW5/EHPVQ1UK2S/aJJconsEReDUtxdhDidkszqbc92uJkO01KqYrOmQAAH8bfESpCZXzxiA04ueBeHW5ZR3n8PYB9wq3vgiAVF/jbCXJxv55u70rkpugrUimIqVWx4OhD4h+cG4fn3qxRd4AMC/ZVRB9G7/YvSwt9mCO34yyK2RpPziAcW1lD5waO7oKOfdek8sY3p5P8DHzw6vEDCtKf3Q+eWbEYaZBPehvLnTcSsWEuj6VzrqY7oAudxiuFMNd+TPdaNRqkm054/LiQ5/QYEAYDv0/H60skI4N7737VPWCM6CHO5q11Ak734bKDDC5plaXzNj1IDyvitSFqR8Ma+2/eusoyEUAzyqav1DN/4bR05A== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(36840700001)(46966006)(6666004)(83380400001)(4326008)(2906002)(8936002)(478600001)(16526019)(316002)(426003)(2616005)(36906005)(82310400003)(186003)(7636003)(8676002)(336012)(70586007)(54906003)(5660300002)(82740400003)(70206006)(356005)(86362001)(36860700001)(26005)(53546011)(1076003)(966005)(6286002)(36756003)(6916009)(7696005)(55016002)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:04:56.9979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b99e5571-2611-4f7f-db1c-08d913cd5b5f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5490 Subject: [dpdk-stable] patch 'app/testpmd: remove unnecessary UDP tunnel check' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/40072bc599a16c519197ff29f7f7bd7e32c5d351 Thanks. Xueming Li --- >From 40072bc599a16c519197ff29f7f7bd7e32c5d351 Mon Sep 17 00:00:00 2001 From: Xiaoyun Li Date: Thu, 18 Feb 2021 11:06:10 +0800 Subject: [PATCH] app/testpmd: remove unnecessary UDP tunnel check Cc: Luca Boccassi [ upstream commit 9d32f448ea0096185d0bbc5582c8b57f090c88a6 ] cmd_tunnel_udp_config checked 'cmd' to set prot_type but this cmd is only for rx_vxlan_port. The unnecessary cmd check will cause uninit coverity issue. So remove it and rename 'cmd' to 'rx_vxlan_port'. Coverity issue: 366155 Fixes: bd948f20d609 ("app/testpmd: VXLAN packet identification") Signed-off-by: Xiaoyun Li Acked-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 2b9dd3e1f4..fa2a0c78e6 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -9096,7 +9096,7 @@ cmdline_parse_inst_t cmd_vf_rate_limit = { /* *** CONFIGURE TUNNEL UDP PORT *** */ struct cmd_tunnel_udp_config { - cmdline_fixed_string_t cmd; + cmdline_fixed_string_t rx_vxlan_port; cmdline_fixed_string_t what; uint16_t udp_port; portid_t port_id; @@ -9112,9 +9112,7 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, int ret; tunnel_udp.udp_port = res->udp_port; - - if (!strcmp(res->cmd, "rx_vxlan_port")) - tunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN; + tunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN; if (!strcmp(res->what, "add")) ret = rte_eth_dev_udp_tunnel_port_add(res->port_id, @@ -9127,9 +9125,9 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, printf("udp tunneling add error: (%s)\n", strerror(-ret)); } -cmdline_parse_token_string_t cmd_tunnel_udp_config_cmd = +cmdline_parse_token_string_t cmd_tunnel_udp_config_rx_vxlan_port = TOKEN_STRING_INITIALIZER(struct cmd_tunnel_udp_config, - cmd, "rx_vxlan_port"); + rx_vxlan_port, "rx_vxlan_port"); cmdline_parse_token_string_t cmd_tunnel_udp_config_what = TOKEN_STRING_INITIALIZER(struct cmd_tunnel_udp_config, what, "add#rm"); @@ -9146,7 +9144,7 @@ cmdline_parse_inst_t cmd_tunnel_udp_config = { .help_str = "rx_vxlan_port add|rm : " "Add/Remove a tunneling UDP port filter", .tokens = { - (void *)&cmd_tunnel_udp_config_cmd, + (void *)&cmd_tunnel_udp_config_rx_vxlan_port, (void *)&cmd_tunnel_udp_config_what, (void *)&cmd_tunnel_udp_config_udp_port, (void *)&cmd_tunnel_udp_config_port_id, -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:27.130425900 +0800 +++ 0017-app-testpmd-remove-unnecessary-UDP-tunnel-check.patch 2021-05-10 23:59:26.340000000 +0800 @@ -1 +1 @@ -From 9d32f448ea0096185d0bbc5582c8b57f090c88a6 Mon Sep 17 00:00:00 2001 +From 40072bc599a16c519197ff29f7f7bd7e32c5d351 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 9d32f448ea0096185d0bbc5582c8b57f090c88a6 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 65d03b0ffb..14110eb2e4 100644 +index 2b9dd3e1f4..fa2a0c78e6 100644 @@ -24 +26 @@ -@@ -9097,7 +9097,7 @@ cmdline_parse_inst_t cmd_vf_rate_limit = { +@@ -9096,7 +9096,7 @@ cmdline_parse_inst_t cmd_vf_rate_limit = { @@ -33 +35 @@ -@@ -9113,9 +9113,7 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, +@@ -9112,9 +9112,7 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, @@ -44 +46 @@ -@@ -9128,9 +9126,9 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, +@@ -9127,9 +9125,9 @@ cmd_tunnel_udp_config_parsed(void *parsed_result, @@ -56 +58 @@ -@@ -9147,7 +9145,7 @@ cmdline_parse_inst_t cmd_tunnel_udp_config = { +@@ -9146,7 +9144,7 @@ cmdline_parse_inst_t cmd_tunnel_udp_config = {