From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28A30A0A0E for ; Mon, 10 May 2021 18:20:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21DA64003E; Mon, 10 May 2021 18:20:01 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2045.outbound.protection.outlook.com [40.107.236.45]) by mails.dpdk.org (Postfix) with ESMTP id B9B5E4003E for ; Mon, 10 May 2021 18:19:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfUUMHVMAM9Nu6ywMA3BDt+3lJ/aQOaKY3kyJHSBfujO3Fr+hYJtD0eyUS+uSNTgqO3Vfn7+e9l2srXeLXhjHdfLjmk84wYb43FzquZhH399msbXB/GDcO/7FDNrqLxU8Zn0E/4RGfrNUhi9sckPZiyrN2rZFrRQk8phxQKG62t6/+el+5SbTGV273vXgRrcJkfGUE7UgjHSGAkOrbGj4CDKCj7Ya8CwlP9wzDThGi8W3HZb60wqtpbzfY5keEs/pFR3sKlGCKu+n0nrRIY6vu5K261mJhQhJ5xgMmIrdJ0W9ZzadL91ums0V8v24RhUEqhTiPYa1+CKAkKAB8ydFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xr7gcTKrDka93zpJyGSRFFYwATvNHPCLoAha6oC7eDo=; b=YhE3R/4Yf0MEs2LUoZdhZoDrljdZupe6tCNgCt4RRDsuREUCl1jLSETZUiax6S9nMOMOf0CyUOQL7KJ/JhBoJgBtl0Q4cbow/PWH7HcQGlKe3/w258prfuOksKxLHP4nhLvhdbo3aICCccuOqmc2G4CefskHxUUVEIoCTrxjV5YpIgcx1GD9YDz6AC6ofj2rWz8ULqcSfFN03jeOCBkg7PcnDrky4g4HPIMM1ZjQt9Yzg24RbAD+MVAzqcOUpZZjDkFBusaWENKM25iITOYmX4h5f1siYT6qG7xPZJt7m+by8JyLuk1SyDyCTCNXQC3jgrM0m7OeZTN8GeL/A3OOPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xr7gcTKrDka93zpJyGSRFFYwATvNHPCLoAha6oC7eDo=; b=iF1nhMnW1E37bAaVYeoG6GuVI0FgFR0J9RHSJS9aEfGOaiShwj9QMoMTtdwekM3ztk3o115o17qQbQVWzXnXF8scHE/BmkPPKyYfbWiZy1hQYxMYk7844ROmXyxlZl2fIcqLYovkXM/uKIpsC8eC6bF+A5mDktPkjerICficoO5/yfNMXcAG7stEEdyb96rLlVp5HAnRO6KVLi8sZzvi+CPurTM9iaQRzvxiwRecPrmWrox3jS8JBebIOjc4DtRmK+Quw8o+deSCrMpseT6uHWcUVQBgz861pJNszTCjHS0V7kHkudmygfxfbLYaZpMHJdHegcxWtrwlrbv9GsWYUw== Received: from DS7PR03CA0033.namprd03.prod.outlook.com (2603:10b6:5:3b5::8) by DM5PR1201MB0265.namprd12.prod.outlook.com (2603:10b6:4:58::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Mon, 10 May 2021 16:19:58 +0000 Received: from DM6NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::e0) by DS7PR03CA0033.outlook.office365.com (2603:10b6:5:3b5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:19:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT022.mail.protection.outlook.com (10.13.172.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:19:57 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:19:54 +0000 From: Xueming Li To: Feifei Wang CC: Luca Boccassi , Honnappa Nagarahalli , Ruifeng Wang , Pavan Nikhilesh , Jerin Jacob , dpdk stable Date: Tue, 11 May 2021 00:01:58 +0800 Message-ID: <20210510160258.30982-169-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e5f64962-cb8b-4945-dedd-08d913cf7433 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0265: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IkBdinWhCgaTsnWBoRl10HHV7MadQVxfrYS+fYYkAlST1GtGlnW/5B0UwKpXSk6zrLibRXM9OVKQrMdVoZ7GAL5jqYzxgowf1+oQCP+VPtDi4l/Goiza7V8dHvDE99gR9x3hy54SfcMaFapsQ1UmNG/uqq3HqVU0Efnlf0hfuRjp+qr8ueVwyJFycFFXL2Cd07IubsYIkJ2T/UP05E5AWx3j5IwtLairYYep50+N/lnFlfPn47UIEOS+HqbJoRdmurUFwY0D7eFBzAvALQTUZ9dqFpUrLdT9ANZcK/+gygEiMJf0bMnAR/LQjE2TKrSzjsPAGe09bTbh7ZpIW9i7bhYV13Evol57MMpjQSH799uSuwd3o344HzUm9PG98kR1BezHJXCqf9PLWl7LQwH7+CSgXWQha2o3KUvf6i6AjJ1zUVDNPTHBHwtAbJPUISUABeEpvKUx8VZpqzJhJtADkDLgnDbe9P1fZ7xScd30HwMJCKva4FD/rOxK8Hhbf0Ajpt+F6ucNsy9J00Kow20BiX/qy3sTmI6K/EFPNjY2hgujuD6FpCe9Jgz8eb5WMiw37YCeHCqwHFsi/jt9IPrUGpOHtHnqvDXFIIKyL8LPHbnR8z9IXf30nrVytuE5hJuBVugHiWOacc0ASd1FOdiiVD7E/IxjokbVdOoOKEPObjNA21iCDweIIKPVBgCiqF5vXHpBqX66W4SBDMjbE3gWqklubKKyc+m0tAJh70NdZxdyOXv637NEzMb30ZaxPHaQRU0sE3YHvJ7KhBRkEMnR4g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(376002)(39860400002)(46966006)(36840700001)(426003)(5660300002)(36860700001)(8936002)(4326008)(36756003)(83380400001)(7636003)(8676002)(186003)(478600001)(16526019)(336012)(6286002)(70206006)(47076005)(82740400003)(70586007)(55016002)(966005)(26005)(6916009)(82310400003)(86362001)(2616005)(2906002)(53546011)(1076003)(54906003)(7696005)(36906005)(356005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:19:57.7370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5f64962-cb8b-4945-dedd-08d913cf7433 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0265 Subject: [dpdk-stable] patch 'test/trace: fix race on collected perf data' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/d2d434683d83eb9efc4b627e0ac55fc436d626b3 Thanks. Xueming Li --- >From d2d434683d83eb9efc4b627e0ac55fc436d626b3 Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Wed, 10 Mar 2021 10:15:27 +0800 Subject: [PATCH] test/trace: fix race on collected perf data Cc: Luca Boccassi [ upstream commit dda66e716c0550ee8b218428a6d2129bd9c97740 ] The measure_perf function should be executed after worker threads exit to collect correct perf data. Otherwise, while workers are running, the main thread may get incomplete data from workers. In the meanwhile, remove unnecessary barrier in the test. For signal variables "ldata.done" and "ldata.start", no operations should keep the order that being executed after them. So the wmb after them can be moved. Fixes: 16a277a24c9f ("test/trace: add performance test cases") Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test/test_trace_perf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/test/test_trace_perf.c b/app/test/test_trace_perf.c index e1ad8e6f55..46ae7d8074 100644 --- a/app/test/test_trace_perf.c +++ b/app/test/test_trace_perf.c @@ -79,7 +79,6 @@ signal_workers_to_finish(struct test_data *data) for (workers = 0; workers < data->nb_workers; workers++) { data->ldata[workers].done = 1; - rte_smp_wmb(); } } @@ -102,7 +101,6 @@ worker_fn_##func(void *arg) \ { \ struct lcore_data *ldata = arg; \ ldata->started = 1; \ - rte_smp_wmb(); \ __worker_##func(ldata); \ return 0; \ } @@ -137,11 +135,12 @@ run_test(const char *str, lcore_function_t f, struct test_data *data, size_t sz) wait_till_workers_are_ready(data); rte_delay_ms(100); /* Wait for some time to accumulate the stats */ - measure_perf(str, data); signal_workers_to_finish(data); RTE_LCORE_FOREACH_WORKER(id) rte_eal_wait_lcore(id); + + measure_perf(str, data); } static int -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:30.976499800 +0800 +++ 0170-test-trace-fix-race-on-collected-perf-data.patch 2021-05-10 23:59:26.610000000 +0800 @@ -1 +1 @@ -From dda66e716c0550ee8b218428a6d2129bd9c97740 Mon Sep 17 00:00:00 2001 +From d2d434683d83eb9efc4b627e0ac55fc436d626b3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit dda66e716c0550ee8b218428a6d2129bd9c97740 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org