From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0053AA0A0E for ; Mon, 10 May 2021 18:24:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEBAF4003E; Mon, 10 May 2021 18:24:53 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2057.outbound.protection.outlook.com [40.107.236.57]) by mails.dpdk.org (Postfix) with ESMTP id DD1384003E for ; Mon, 10 May 2021 18:24:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SdICwKd98tcgWLprQVIDWSGefgywj6JmgA7RV9GEHvMM9VCsj91RhDWZ2DbxRD8Clu8YLh8gKir8Wy6l1bgEfCRR2L3Gon4CbGCPNSYGDDo0BjXVJ3beJApNq+kq4YROt/G9hYq6PWYIcfUlmRsUqslaRJUwt9UyKsR/jGKKrP2o3vzxTNLMH7BzADPMrExrp2RhHu+K9CcTfCF8GKRHbfe1oMARwNrGGU2ay7XX8ri+1KM9FSIyi6iyT9o5aoK4bmFwsSFp76C11BEH1jH/8XNzqMhNr+RxddbdZibiffid/9L/cH384YxMvV2NDNTTwEfAlwtVFTEKgXqC9kZHHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOBckiilBWRRHsfTZ8q6hkPYCt+t7gywLhBd/+tmJd0=; b=Y5YYyO85dDxux4pJfg9jMXnRLuWf0zIf6N2X2tDxP0U5j0Y/v3lMgSUcVffGxkqMbFhi2yz06tu1n11Lrm6+XncDNq0LgND8bzQ/MsVb3E1mC7YOozmAKX0D1Rt720qE9qJrGI4II95joBqjuov3Wz0r6AvrjhApE5p/BQ8bEp8bV7X+TXLLu9hYHhAYJ8zehJM9MKYYynoQEHr3TynZXD/rzlb8AB4EIO7GJYR8pyd0nSW7ILtHt7BTNocDm5lUu9G2G6l/82zSd/krYImZCXaSY/pPTkfxkwq8FCMrw2FtnYdktoy+OhLhEH6cKY3/7uA9uojiMeGLquu8Tx/t2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOBckiilBWRRHsfTZ8q6hkPYCt+t7gywLhBd/+tmJd0=; b=rZQ/JQBctUur3OtjMofAITKU/skCV/Aq2o/zcRABrWaWzQ1JM6ZjqDgmz5kuvMzWHPfyxc1PVvxa+mokij6sYJTllyIfjslOl4cT5QwP9Phqk7TyiEvv0HIfdLMia00F8dIq6QmUeRIfquSb9z6tOkdqe4Y8qe4qyFrtouCTccXUOz8eTdeWBi69wD579ExgFgBU0HdOXfK8tZgWa+WF5Y6b+fNSk320MF86HWTAhm8ZMw7X49LoEyk1gfVrI4IzfY69qRWSNS5dE9t/wUrSsl9HBEAj/Ka5G+Rt8DQdw0j+J4SQOGP0esQKNdLmN27+a3klXsyEZAQby0Wx7BGrSA== Received: from BN8PR07CA0004.namprd07.prod.outlook.com (2603:10b6:408:ac::17) by BY5PR12MB4193.namprd12.prod.outlook.com (2603:10b6:a03:20c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Mon, 10 May 2021 16:24:50 +0000 Received: from BN8NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ac:cafe::bf) by BN8PR07CA0004.outlook.office365.com (2603:10b6:408:ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:24:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT032.mail.protection.outlook.com (10.13.177.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:24:49 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:24:46 +0000 From: Xueming Li To: Huisong Li CC: Luca Boccassi , Min Hu , dpdk stable Date: Tue, 11 May 2021 00:02:46 +0800 Message-ID: <20210510160258.30982-217-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ffe15eba-94df-421e-4652-08d913d02266 X-MS-TrafficTypeDiagnostic: BY5PR12MB4193: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E1wklhJX7tspYYvg5qECTu+t1i54WLccI2S695nHB0K/aZeZ7f7+UEubiCUn+0nFo0eTegu7phyt64mGhsCOtWIS06A/HAUtgCTZgZi3vmk3HU0TvO4z9VvRfEfQziQrvCLxe1ZftGHZ2AbOPajIyK7ANngeD/BgI+XU8T6pxb0ORZ2E+OUx3p72wZ+DYexpXp8LUbRQa4DnUjMQCO25ZUDCmT6Wy+TqZ7jR3T1O3ac/IYLnJkfSDqjutCsYAj+eJAVq0caG+D9ELZ1ce/QLvy/FUfdIAguIe8bUqqR5TvfycTvMW4U8CzHpXfActAys96WKBRLLFjmG4+M+NupxGxUKXXRtxjhIVB2yZY6muSj1ccmsFqrJ+1ZToKHA6N23eKldz+B1DHZtl2iSdCXC+o19HxsflD52Vaf47fDV53Ahfzj0JyfbqQT4/+9XJhB7s4s1kH4XmtLQMbqrw1Z3cQSYvfXYKs2fgKZvq9UpAsVlahc6lCmqlulPXHgNRIx+8njGY2FOosSa9s16zj2UTuV6znu86BXkPdnrzIPd0CD5LfH3SJGnUpAfzm/eC+h2hRy1DY5ctoXuhjtn+5KgLfLCgzITdimteIHwoR18/fwKGq48nSyUhSXk4MSqEtRIGbMgunoOqr1P3UvVjVyU1FQg5QHOjg/QRMPrtcfGsfMvDWj/vtUjANZNrbRSsMknvmPDczUmymRlMeoFWsMOoNnJevSBco8hCFPUHwHyzoQr851rjNU8e7XcIT+aMqyFChwAc9YQZj0RFWifZEPrdQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(46966006)(7696005)(2616005)(26005)(55016002)(36906005)(36756003)(8676002)(316002)(36860700001)(8936002)(6286002)(336012)(47076005)(6916009)(82310400003)(2906002)(16526019)(426003)(54906003)(15650500001)(5660300002)(186003)(86362001)(478600001)(356005)(966005)(82740400003)(70586007)(7636003)(70206006)(4326008)(53546011)(1076003)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:24:49.9180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffe15eba-94df-421e-4652-08d913d02266 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4193 Subject: [dpdk-stable] patch 'net/hns3: remove redundant mailbox response' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/2782c994db516427c52240bdeef260fe7d8b46be Thanks. Xueming Li --- >From 2782c994db516427c52240bdeef260fe7d8b46be Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Sat, 17 Apr 2021 17:54:55 +0800 Subject: [PATCH] net/hns3: remove redundant mailbox response Cc: Luca Boccassi [ upstream commit 17ff95283fa10c6f296e9008558555ead6d8a3a2 ] Some mbx messages do not need to reply with data. In this case, it is no need to set the response data address and the response length. This patch removes these redundant codes from mbx messages that do not need be replied. Fixes: a5475d61fa34 ("net/hns3: support VF") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev_vf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index ac11befa16..78e7a1bba3 100644 --- a/drivers/net/hns3/hns3_ethdev_vf.c +++ b/drivers/net/hns3/hns3_ethdev_vf.c @@ -1455,13 +1455,12 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q, static void hns3vf_request_link_info(struct hns3_hw *hw) { - uint8_t resp_msg; int ret; if (rte_atomic16_read(&hw->reset.resetting)) return; ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false, - &resp_msg, sizeof(resp_msg)); + NULL, 0); if (ret) hns3_err(hw, "Failed to fetch link status from PF: %d", ret); } @@ -1657,11 +1656,10 @@ hns3vf_keep_alive_handler(void *param) struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param; struct hns3_adapter *hns = eth_dev->data->dev_private; struct hns3_hw *hw = &hns->hw; - uint8_t respmsg; int ret; ret = hns3_send_mbx_msg(hw, HNS3_MBX_KEEP_ALIVE, 0, NULL, 0, - false, &respmsg, sizeof(uint8_t)); + false, NULL, 0); if (ret) hns3_err(hw, "VF sends keeping alive cmd failed(=%d)", ret); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:32.175922900 +0800 +++ 0218-net-hns3-remove-redundant-mailbox-response.patch 2021-05-10 23:59:26.690000000 +0800 @@ -1 +1 @@ -From 17ff95283fa10c6f296e9008558555ead6d8a3a2 Mon Sep 17 00:00:00 2001 +From 2782c994db516427c52240bdeef260fe7d8b46be Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 17ff95283fa10c6f296e9008558555ead6d8a3a2 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index e65f3c1173..065d3181c5 100644 +index ac11befa16..78e7a1bba3 100644 @@ -26 +28,2 @@ -@@ -1511,7 +1511,6 @@ static void +@@ -1455,13 +1455,12 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q, + static void @@ -29 +31,0 @@ - struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw); @@ -31 +32,0 @@ - bool send_req; @@ -34 +35 @@ -@@ -1524,7 +1523,7 @@ hns3vf_request_link_info(struct hns3_hw *hw) + if (rte_atomic16_read(&hw->reset.resetting)) @@ -36 +36,0 @@ - @@ -40,4 +40,4 @@ - if (ret) { - hns3_err(hw, "failed to fetch link status, ret = %d", ret); - return; -@@ -1756,11 +1755,10 @@ hns3vf_keep_alive_handler(void *param) + if (ret) + hns3_err(hw, "Failed to fetch link status from PF: %d", ret); + } +@@ -1657,11 +1656,10 @@ hns3vf_keep_alive_handler(void *param)