From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 767E3A0A0E for ; Mon, 10 May 2021 18:07:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BE064003E; Mon, 10 May 2021 18:07:55 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2080.outbound.protection.outlook.com [40.107.92.80]) by mails.dpdk.org (Postfix) with ESMTP id D8C9E4003E for ; Mon, 10 May 2021 18:07:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkfZM6RFBBgEKkAZC3yjMrVxHj2x9cyRnNp+16wJO2nI60zz4L6sWJt5dK6lhxoa8oRyNq2M1z6mgA43w/i+IUi6P81uW0ofB4XsXPIJBCyZ9QDBRbRKC/hVPpw+/ixXOnCPT9YiFiqBNN61N46BXQoVnT4q+H0Sn/BBA9OSIGpI6YY2ZjhM8PBnDQb7HDdOB1nujJrjK68gKDtZTZk0xoe89lHznO9Jb3Dpn4O4AQDf1p11UQNmJX8ojhYWwMVzuVqb0hez+uWht2YbropB9tydKrVucleDTOCZxmX9VDT/7b7GFQEyETClrMP8+nBRcMXg5Qo2168SbWcgXL0SDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oyx3qNRrizqS4jUwUSHxsrEhhlHvkP/g+f4fvEAxyWk=; b=IF9XRX0ZZXYXZ/+roymhyGdH8RKFnU4KvYgyTeHu4B2yfM2BEf1g0+EwXDMPftRxeIf3DULc9qJCG1SbHfBCdz48fM54gNaopfcDwMimtdOk8QF3V8tFX+1L05d6oNOB6dnd/pY9xRNNi0YyH//yyoCgai6QKiT4O45dypFXhzN/4JLbNHejZMkxAL+zVtZzUXpWRpCYrZKC38NgBwdyNNkmtt/j2HrKmlP7/raXbWR1Gsl1Tgv0xasNTNXFOfpLj9Nio7+eRub2qKAnHN5lSY4nXP4xd79uGscLNyMisjjg2+2Ia8+cQwnbQs2Sckr+Xs2g+LgnC3NwRBXrsMUYgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oyx3qNRrizqS4jUwUSHxsrEhhlHvkP/g+f4fvEAxyWk=; b=bhLe/6jUdE9MyfqXD4TkLsy85CiKESzpOgWqv5f0yiBHQaCHkzdsZB6dhCncBwMAiuIXpf19oVeqdLOxitIEjhvVWtdSk9Ysy7latR8Z3ig60UNXZysSxK39rG85ovOt0RIfAbK8+bEBwgKFZVUz8B/hfOWiHVTH1ZydpXApgG6OENtlNiybb0zXgbkszKh3VOS3HPEB1sgUtXu0rs087JuHWD9KXsg8UvsBNgzUuVIHKzDdEjmJU6HEhzez2onCXWOaXnaSfsUt6zq+z4IkPTSNejHiiTASISJZoxEcF0+KXfXTg6vvSEzpFPl+6Nk89A3/3qhNjGJoQ0R6kb+4nw== Received: from BN9PR03CA0393.namprd03.prod.outlook.com (2603:10b6:408:111::8) by MW3PR12MB4361.namprd12.prod.outlook.com (2603:10b6:303:5a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:07:52 +0000 Received: from BN8NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:408:111:cafe::45) by BN9PR03CA0393.outlook.office365.com (2603:10b6:408:111::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Mon, 10 May 2021 16:07:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT008.mail.protection.outlook.com (10.13.177.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:07:52 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:07:48 +0000 From: Xueming Li To: Tal Shnaiderman CC: Luca Boccassi , Odi Assli , "Dmitry Kozlyuk" , dpdk stable Date: Mon, 10 May 2021 23:59:55 +0800 Message-ID: <20210510160258.30982-46-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89c35890-bf90-4d9a-2d13-08d913cdc3d7 X-MS-TrafficTypeDiagnostic: MW3PR12MB4361: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: diMtSEaZNHcx+7b2qrJCqpgk3KMJL14biKy2/37DNBetDvBeQPjlmDYK4u5nrXKgNvKyeG8QWNhlcxJEXS5l7wF/U1ygCERzot4okpWIb1A3rsoQtI8nHjtmCUcur1/Rcs0B04Tnu7f0jcBokst+OyJqdUQJbxhsc3pim6UII/Br+HgULx70Xf/mzKDTtkjseK3uUu8s/FPninpzdeEzRSoihMT5UhFoA58OehZMzh4g3wzpkgQW5CKvpxJV4N1hJduIwtgGM5xm+1UrvNEcIVUs48Ht7HcL3i2pVQDqHbilLBhUxkHh+MrgFaFWq0Bwi2FRoEQ5P2A1WbUxWoO+H76uvH2OjSGntu/G6zVvuXAGhQHFgpOiTMZIaPBbapu7krQKb0/JTDGyMuf0QINoSnFnJzmqqVss4/g9bvSO0zDL6UC+gRamYfGkz2urR3eaz7AxSOPevwxfgpzccdZ0ILM822H770QVSop5U3m/gcOarGZWAjpH+9MPsvDIzdU5F/CCEAUCpF8mufo+E7xIG/ZQ5K3ra48SbO4uUz3Iy0ZUEQKLzIL1T912I1jAd26v2/ZTgy6G5Cs2c+5P5MByRZFchx+1es1G9fARhzTIShnzufRSl8+yBzGYILX555pp47eLGT87k7t3knPB9Q7sRvr2S9dpGHTg6l9MoIB3ta9PKQAlwdMgNe4p2wqMoBWWcgnZPrRFbzaXDjkcbAgnNC4ygE+B/YNJGJkDCewGu4805UCaYRQ9kdguNiZ8ioNtzVwCllo6ZmgzKrlWJcP+Xw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(46966006)(36840700001)(86362001)(6636002)(36860700001)(53546011)(478600001)(36756003)(55016002)(83380400001)(2906002)(966005)(70206006)(336012)(70586007)(426003)(8676002)(5660300002)(7636003)(7696005)(6666004)(2616005)(356005)(8936002)(82310400003)(6862004)(26005)(1076003)(16526019)(186003)(4326008)(54906003)(37006003)(6286002)(36906005)(47076005)(316002)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:07:52.2809 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89c35890-bf90-4d9a-2d13-08d913cdc3d7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4361 Subject: [dpdk-stable] patch 'eal/windows: fix default thread priority' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/d68bec0b176c41aac146c1a943f6a324fcbf8ad6 Thanks. Xueming Li --- >From d68bec0b176c41aac146c1a943f6a324fcbf8ad6 Mon Sep 17 00:00:00 2001 From: Tal Shnaiderman Date: Thu, 18 Feb 2021 13:40:58 +0200 Subject: [PATCH] eal/windows: fix default thread priority Cc: Luca Boccassi [ upstream commit 16afcbfa30e9c2831264fb349457a4228fa687c8 ] The hard-coded thread priority for Windows threads in EAL is REALTIME_PRIORITY_CLASS/THREAD_PRIORITY_TIME_CRITICAL. This results in issues with DPDK threads causing OS thread starvation and eventually a bugcheck. The fix reduce the thread priority to NORMAL_PRIORITY_CLASS/THREAD_PRIORITY_NORMAL. Bugzilla ID: 600 Fixes: 53ffd9f080f ("eal/windows: add minimum viable code") Reported-by: Odi Assli Signed-off-by: Tal Shnaiderman Acked-by: Dmitry Kozlyuk --- lib/librte_eal/windows/eal_thread.c | 4 ++-- lib/librte_eal/windows/include/pthread.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/windows/eal_thread.c b/lib/librte_eal/windows/eal_thread.c index 908e726d16..9c3f6d69fd 100644 --- a/lib/librte_eal/windows/eal_thread.c +++ b/lib/librte_eal/windows/eal_thread.c @@ -134,8 +134,8 @@ eal_thread_create(pthread_t *thread) if (!th) return -1; - SetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS); - SetThreadPriority(th, THREAD_PRIORITY_TIME_CRITICAL); + SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS); + SetThreadPriority(th, THREAD_PRIORITY_NORMAL); return 0; } diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h index fb11a07ce6..9aeab1fa70 100644 --- a/lib/librte_eal/windows/include/pthread.h +++ b/lib/librte_eal/windows/include/pthread.h @@ -137,8 +137,8 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc, hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, args, 0, (LPDWORD)threadid); if (hThread) { - SetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS); - SetThreadPriority(hThread, THREAD_PRIORITY_TIME_CRITICAL); + SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS); + SetThreadPriority(hThread, THREAD_PRIORITY_NORMAL); } return ((hThread != NULL) ? 0 : E_FAIL); } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:27.874876400 +0800 +++ 0047-eal-windows-fix-default-thread-priority.patch 2021-05-10 23:59:26.390000000 +0800 @@ -1 +1 @@ -From 16afcbfa30e9c2831264fb349457a4228fa687c8 Mon Sep 17 00:00:00 2001 +From d68bec0b176c41aac146c1a943f6a324fcbf8ad6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 16afcbfa30e9c2831264fb349457a4228fa687c8 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org