From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73296A0A0E for ; Mon, 10 May 2021 18:08:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D4684003E; Mon, 10 May 2021 18:08:28 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) by mails.dpdk.org (Postfix) with ESMTP id C98B84003E for ; Mon, 10 May 2021 18:08:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L9gAN4Z2pgqPhY97HtTl4c14yTngdQDsppeY1Mm2E912RoI3aC+wfgSTVGVoiBhyndizEF123ksXh2b5iXHjRas1OxB6JdBKiQt7HC8DtuHpjiHIozfl8pCy4ZF8hLBM6kzO43PuOkUO5jZJM2a1zn0Niq0w6RigLxVjBoAMZoJ9E4PFSC98CSFZFEGoWejH9t3Y/LJmemKdVFcu1MGDAHKBgCLvzg7B3s1N38DXM12afti1EZIMyqUsYz754+KDEFShVudCjBDsEz/V9RoaSqOOrepdEZEEblnvL/bJDf25eydV+x2BK7veMdibiLSl443mCKlara8DatGPFfzSPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLwrV8EBahKfHizZqgEQCRBz3K+caTYEXDPsVBuMbq4=; b=JAKjCS/tfpBFbq2eWusqLlU2QzJTugna3c+ESEd2wWZpQE3dEribUXAQIfaHvEIfvIf+/V7dKnhup6rG48cfr0dkKD0364ic2lzFvWRj/s17hJZj82sSn3KdWMfM2MFowimGA3pk2/gAoR02ahlZDl/Kubbb2T7DJwiip2rlOAJo6QBQW9ybQgG63Z/d7pYN3v0OtuCXjgxM8rCDxSY55KoJhRCpghpmkOkCELMyi/7zdFLicYmZDsO3r6vMsOs4IWywbS3YSscNm1fHnAiDs3b2xtr3Dyzfvd8dQ2vWisT492MmAvVFl0ZKaIDF6bJhHj3y+SWvg2VcxZH8iziqVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLwrV8EBahKfHizZqgEQCRBz3K+caTYEXDPsVBuMbq4=; b=FBRJHhnFLxBh7Tne6+BlZYHK3/80omSjazjCo+xNzJVVVJ0vJQT5vuBBYKLnTYvdMzkUCEzf0NNIXBoXNWnWI0EpPzkXmIMoewOV0pqiPcbXeg4c/1zcitaxRs/IcZtdKOSnzvJwUNwPyFt+tCU+Ni1U0h2MI2gzlonBA9MQE5/BkAvm2lmMexx0e4GLd+30bWDnK2Lz7Le3CuaYWRmiKJ+2pCOxsA7FYSD7xw9RApXrFbEW4xvm5a2S5dUTbcAcH+zvecgpTnm66Zc1uauv8xUz5CFxyltGoFtYPjh07loSZ/G3nZQVQZPXF6OKdkg0oykADZw5bXm55X2657g/Jw== Received: from BN0PR03CA0024.namprd03.prod.outlook.com (2603:10b6:408:e6::29) by DM5PR12MB1417.namprd12.prod.outlook.com (2603:10b6:3:73::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 16:08:26 +0000 Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e6:cafe::e9) by BN0PR03CA0024.outlook.office365.com (2603:10b6:408:e6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:08:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:08:26 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:08:21 +0000 From: Xueming Li To: Venkat Duvvuru CC: Luca Boccassi , Somnath Kotur , Kalesh AP , Ajit Khaparde , dpdk stable Date: Tue, 11 May 2021 00:00:01 +0800 Message-ID: <20210510160258.30982-52-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4b75b21-abe8-4ffb-c2e9-08d913cdd84f X-MS-TrafficTypeDiagnostic: DM5PR12MB1417: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j2YpymClwxW2X3AU/5Z/l7DDbzLcCS/OdhZvYY5zCBUiD7ues4dBRAkHcVLzFKNvBXdZ+/bXGzHxowg6fZAHuzfuB2ur/kJ3TCQxxNKgRDVgZepBjKB/AVI0vmchUhqfJH+1ZExfkqkKwJlPcpKJZVZkjYgN7eYfy9TnhIjzYgbnL7t2munQfs3RZEm1KGCIYGtV27aBE0irnJmycMMlSJA5G6yFcvJ3wsdhm7BTbs03MKalxUq9xuuHA3hBJcceUhhdB0GylmiqyoZGFZq3+TztYmDHoF27uxLrNhiRL9f4kCA2Ng/TryTaEXXswhsG/E9n0IemdH1goB5wXZ3cLOjhKieGNkbcY65xx3vkzFccnz88xzfPWndLjMvWe1n+yvH+R9Uif1ISemzpWB39XgPeuMqodfCCE4l8AKZ6qgXde5vF2E1DbXvUXHIZHRyl7vJTsP0uCbgf1o+yEsm2Gm4Q2ay96B9KkCukOB6wTNL2JUCHNVISbA8JCGFzlbBXwuwopMG2I88fJR7z8V4aoiX1dFXX7+txMvkLT/GvjbItMfxnMEQyFbb7TMMbT0j8Z7pkz/dk4xU/ZvthPMYZ9SMkqqovuZtdh00BrCQIuOU0zpC+/0WE8UGAs0GjyIrxLekBJm6SWiVc6leS0rATkcvlO5KbEgpf+0qKcJddKCavesZ+tKqetrFzm7Pm2/V1c1P1tZJLmdlTuhyaRzEv9vvimdo1DZe9ew1obL+8qgolvUvl+zSi8D+WpMT5PeaY8QeSTAjHgXpaVXD8AiL6Tg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(36840700001)(46966006)(54906003)(82740400003)(7696005)(55016002)(7636003)(478600001)(1076003)(4326008)(356005)(36860700001)(36756003)(316002)(6666004)(8936002)(16526019)(70586007)(186003)(2906002)(53546011)(82310400003)(26005)(70206006)(2616005)(8676002)(5660300002)(6286002)(47076005)(83380400001)(86362001)(6916009)(336012)(426003)(966005)(36906005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:08:26.6146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4b75b21-abe8-4ffb-c2e9-08d913cdd84f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1417 Subject: [dpdk-stable] patch 'net/bnxt: fix queues per VNIC' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/86e9785dbda478aab5649df93e59cc3ad9e388f6 Thanks. Xueming Li --- >From 86e9785dbda478aab5649df93e59cc3ad9e388f6 Mon Sep 17 00:00:00 2001 From: Venkat Duvvuru Date: Wed, 24 Feb 2021 21:25:46 +0530 Subject: [PATCH] net/bnxt: fix queues per VNIC Cc: Luca Boccassi [ upstream commit c23190303efd6884eaeeda7afe23c2a158f4c1ee ] Update queues per VNIC in single queue mode. bp->rx_num_qs_per_vnic is not initialized in the single queue mode. As a result of this when an interface is reconfigured to single queue mode from an existing multiqueue mode, bp->rx_num_qs_per_vnic is not updated to the value of 1. Hence, the driver will try to access more than one queue resulting in a crash. This patch fixes it by initializing bp->rx_num_qs_per_vnic in the single queue mode as well. Fixes: 36024b2e7fe5 ("net/bnxt: allow dynamic creation of VNIC") Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 8637559370..95a3fc91db 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -106,7 +106,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) pools = RTE_MIN(pools, bp->rx_cp_nr_rings); nb_q_per_grp = bp->rx_cp_nr_rings / pools; - bp->rx_num_qs_per_vnic = nb_q_per_grp; PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp); start_grp_id = 0; @@ -165,6 +164,8 @@ skip_filter_allocation: } out: + bp->rx_num_qs_per_vnic = nb_q_per_grp; + if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.012200600 +0800 +++ 0053-net-bnxt-fix-queues-per-VNIC.patch 2021-05-10 23:59:26.390000000 +0800 @@ -1 +1 @@ -From c23190303efd6884eaeeda7afe23c2a158f4c1ee Mon Sep 17 00:00:00 2001 +From 86e9785dbda478aab5649df93e59cc3ad9e388f6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit c23190303efd6884eaeeda7afe23c2a158f4c1ee ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index f46b10c1c5..53a9b52a46 100644 +index 8637559370..95a3fc91db 100644