From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8041A0A0E for ; Mon, 10 May 2021 18:08:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2C174003E; Mon, 10 May 2021 18:08:36 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2064.outbound.protection.outlook.com [40.107.92.64]) by mails.dpdk.org (Postfix) with ESMTP id 1A8A34003E for ; Mon, 10 May 2021 18:08:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AtX9lrjTYUHQ2U78dikjVv1fASAkNWkANapgvlzBK8LpcEPn4k+kT9xuKn060EA2dUMT5bvUCWj/VbPOVWrV2rZF9qi16ZT89Egdn3/YzvcrvX/rgvHaht2bdl9Vbq7UouH7D4Ix3z7MvMywBatpui/m4+1qHZpmYOpf8xgPqSdxS5l2ifkuTVbkzPZ+D8kLP61xWFCTolhVAH+YpAlNrO04JI6fNyYXJ/F5i+Fl0UxXFV7bE3WSEJCQQav/0jmO77tTjKbGDSvdK5Yrmc/qhgNrFxA9PDdbuIfqt/PouzpgvRPL1G4/0uWF7p7M0VPTpDjCslFXOosS9+EoVuQeOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6rLfyHK2J8s52QyL5I8UMmUenL5dmkubHZZpBWuwqo=; b=XtPBO5T2p+N9qheUfxzWXzGd9SKzy1oLLM8xhwslfMAjtCTvN7qOjd5caU2egev5iiTKzWT4Nqm8JqdWabClkWfw3/7jorsMbqJtVdFU+bK69AsRzKLQPajSmAYB6w6wUDC7erikyl4n8M43rFbRR1tLtcrbwbxsg1hMH0Qhbpq6tA7HmnlwxQ4R4UC65aoCNe17GqcMeuUC4aGpSGBBPfZ3Xoiz2LNDCX2muZYwoP+uvTtoOLu/tDnChtBnO02reJlJBa1mAlzlaKNQybVs9HAn1qsBEK4CWg+ySmo7K7L7Mk/Q9MlohtjCXmZ8aYcFp/R8WhyFb+V+I0WHSCxq1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6rLfyHK2J8s52QyL5I8UMmUenL5dmkubHZZpBWuwqo=; b=kBR+xVidiIxPK/tACsi+IGD6RrraAmK3vglmTem6amlrcKxClseE+J6OvEV8Ro0IxaZ3VKuzQul2w/kF5GmCQJfGDSnOB4s7nhlK6Y4J06L2ULenz4qOm9N06vsF7dH4zGYMyEr2jKpHYEusNplAMd/ynsauboljwNV0ilPGECx98WyYo3D9qHm4IJDTKSFXNRCPOJ+O3R72uaQdblHiA6Kc9wangcrcoaXwrRkOJS9LS/jDePXiWuOLg+Q4EPIjMHtIHEKwGWyru9AUH9tECm6tfsUkFlWQWSWjuPvgi0BqV9TU2dnJXtJuIpbFZbxmIqmP8pSYmnF1PBJvTIz3dg== Received: from BN9PR03CA0730.namprd03.prod.outlook.com (2603:10b6:408:110::15) by MN2PR12MB4518.namprd12.prod.outlook.com (2603:10b6:208:266::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:08:34 +0000 Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::a2) by BN9PR03CA0730.outlook.office365.com (2603:10b6:408:110::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:08:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:08:34 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:08:28 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Somnath Kotur , Randy Schacher , Ajit Khaparde , dpdk stable Date: Tue, 11 May 2021 00:00:04 +0800 Message-ID: <20210510160258.30982-55-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16d2151e-813d-469f-fd1d-08d913cddd14 X-MS-TrafficTypeDiagnostic: MN2PR12MB4518: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vYNXO2Fyy56DUNjsBXMze7KjqyxYNNPxU9dJft6qwbu/70ftcomIE0S2tXdIbUr50tkueoQsMXAChEnZarPneALCrp/quzm59MU6zO+Xb80iBMOW3Do3cboEP4wjk20tjpqRkHIyecIh7MO5u4LeVEM5BwbcmiCVtfStBvQlAT7DGawk9FyjTsn/WliLEW9wIdFlmzKc6rosf6WDOMI7BGTb7RU3oktQAyl7DDaOiLbFdKw/CCcVWupeQxQCT8G9MN/eXME7JZmjgfcSB6o56eE/JENK8F8jVwd7plH9Mv+HnSjXXe6zOLBkXuBGvE1sMEsPHI19XthvC6cPAsMObcba/qEU3Ouw0YsUZGyhDPxk84sO+HDwrAuVD3yQhVJ3S/b37ipCHP/h8TKcY4jpMtp/XcfD5jk0Rplg1jebHUHpcETqEdvLXuwNLncBcdvNL3gV0vkDk11SqSqqarTcK7lj1SrN7eRojW2Un19L/USoTNonU4yPr9Wz43ixG8a1r1Km/2UGBJzWqy20kz4oNTG5Ms2aCAWfjLI1HcxfrxlDRyIiEqO+FZkTz6WWUYUDl4Mavil/hw5O2e3q8oPgrjN+zADApmsYoBBmKyvulClS+g2ptfqJtOiD2D9iohyLIQUxTUgRh3NDLV/piyDa+UbOtuPWb7pmDMN6hEEScVjtzxUB17ZpZIYTpqXpIXvNcWqZDu1Ebeovc3kVvvnD0VpFGpAScDUxukfDgIpZWdhVV6qKVoQGAZ3XBkhlJHBTI2dJaBKhWD6odpnC9DpKIw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(36840700001)(46966006)(36906005)(356005)(966005)(316002)(7636003)(36756003)(8676002)(86362001)(336012)(26005)(2616005)(83380400001)(426003)(1076003)(55016002)(5660300002)(6286002)(82310400003)(8936002)(47076005)(53546011)(2906002)(186003)(70586007)(6666004)(36860700001)(82740400003)(478600001)(54906003)(7696005)(16526019)(4326008)(6916009)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:08:34.6150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16d2151e-813d-469f-fd1d-08d913cddd14 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4518 Subject: [dpdk-stable] patch 'net/bnxt: fix device readiness check' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/3d051e75a45ae60f8e49fb8d2de70e1a92c53bc3 Thanks. Xueming Li --- >From 3d051e75a45ae60f8e49fb8d2de70e1a92c53bc3 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 4 Mar 2021 14:37:27 +0530 Subject: [PATCH] net/bnxt: fix device readiness check Cc: Luca Boccassi [ upstream commit 3972281f47b2cc0cf844698885f0e6b4228c0975 ] Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. Driver should fail probe if the device is not ready. Conversely, the HWRM_VER_GET poll after reset can safely retry until the existing timeout is exceeded. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 2477237b39..a27ecfac7e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1096,6 +1096,11 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) else HWRM_CHECK_RESULT(); + if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { + rc = -EAGAIN; + goto error; + } + PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, @@ -5830,6 +5835,10 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT_SILENT(); + + if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) + rc = -EAGAIN; + HWRM_UNLOCK(); return rc; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.089413000 +0800 +++ 0056-net-bnxt-fix-device-readiness-check.patch 2021-05-10 23:59:26.400000000 +0800 @@ -1 +1 @@ -From 3972281f47b2cc0cf844698885f0e6b4228c0975 Mon Sep 17 00:00:00 2001 +From 3d051e75a45ae60f8e49fb8d2de70e1a92c53bc3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 3972281f47b2cc0cf844698885f0e6b4228c0975 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 02b0a214ca..5ef0845e8c 100644 +index 2477237b39..a27ecfac7e 100644 @@ -27 +29 @@ -@@ -1217,6 +1217,11 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) +@@ -1096,6 +1096,11 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) @@ -39 +41 @@ -@@ -6045,6 +6050,10 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) +@@ -5830,6 +5835,10 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)