From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D749CA0A0E for ; Mon, 10 May 2021 18:09:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC1440140; Mon, 10 May 2021 18:09:24 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2079.outbound.protection.outlook.com [40.107.93.79]) by mails.dpdk.org (Postfix) with ESMTP id CEF004003E for ; Mon, 10 May 2021 18:09:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QyuaWvTE7roaLj1JaU4vUoRx0+WM1/Rd82Wkyyf5ysEotBM0yi9eT3E5lZht9Bh6xD9Uhlgj1ankPlcPx51u+x8Wz0DXRY/ibx0eupSn2XyWEZ7ySuId0KNUXQGODu9GbG7zKuLt3RqUuRttJGQqkYxOYRZQIAoU7b7SWDjMNg5/K5oW9R1ujJJ9wRjjhdk6le42nIgll/dCy6TYUhWtWmSE9Ss3kXW2GAtxmGtenzFV+eU9crvMA9ovIaBr5aYRLNf/qxP7sTNWwmz49Iy8uHikTCdmq18jNKQ1yhLZNVOSVqSkbZKQzr2eCfQEa5AKD4JnL8fxKnSynpKL7MK6fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=smyZevA9zfsZAXDvNSs3mWv5T5iN3trDreHc2FhOzj4=; b=CGCfAZDq/KJPaGx4yeuW9o2W7gNXqJzUgN98HxjnLXHDumLfuhK4Oxj/vLrCsrBBLoo6LOS+1EP3Q0s9ot+vc6ws+i22Jm7GVDeJ3ugkoJ1pwA771i8IKGlORZsZUX2s5r/GPkqDjHlMpGOGmdGtK+AiN2yjW5FxA+ueqKbo4OScOfj2mgEM//NzVvk4F+wascQCd/2p4VnW/mMZiUD1EnM6s57QmIdTN633/mCz1Yj1n4xTsow3doVF8AyRU7hIc1eNgtDUyZI/a7OTYl/RJmG9anQ3SdmaHEoCKNh8hgxGKE47pprMILcXthC5ij9xpcOuVdEYXRmTsidUzhOlfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=smyZevA9zfsZAXDvNSs3mWv5T5iN3trDreHc2FhOzj4=; b=b0fFrHn/Rnp21V8AY2op8nom9eVl0UN+CfeJgqw/C8evRl+igVLEsUSAEDsv6kXXXsOZkk8BPABeEkEJe5ZBBIfShDpHPO9guXNLN/WZxUo17aUHoRNgSa4SLhPwgrjP+JLIIW7NxDKUo1GyKbun+rzG2m9AUnYkvvn3Gi+SBZJKNHahhe1QT/icjIEITykomyf3JL+EpzYGu3TAIrcqtYu/c+L1m27DIzwTlspEhN91jl9DIqKtJElZn4+O2QOkniVICZ392uRAE2yZWoSB9sg2w6EaZCrZAa1jB25rQhf+uOmLCKKcQtw4Rzd7ZW96Hz+binMSrHe3HKDiXClEBw== Received: from BN9PR03CA0237.namprd03.prod.outlook.com (2603:10b6:408:f8::32) by MN2PR12MB3359.namprd12.prod.outlook.com (2603:10b6:208:cc::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.26; Mon, 10 May 2021 16:09:22 +0000 Received: from BN8NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f8:cafe::91) by BN9PR03CA0237.outlook.office365.com (2603:10b6:408:f8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:09:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT045.mail.protection.outlook.com (10.13.177.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:09:21 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:09:19 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Xiaoyun Li , Andrew Rybchenko , dpdk stable Date: Tue, 11 May 2021 00:00:10 +0800 Message-ID: <20210510160258.30982-61-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a16e701d-31ea-4412-9a14-08d913cdf8ed X-MS-TrafficTypeDiagnostic: MN2PR12MB3359: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GqP81SCGIbJonaMcvApeWal3bFqwqmFEUttzAgRKKu+72j+IshEjmT2CCQKSG1tFwu/WB9/cuko8BwoH+NFT3J6V8gKm9psxD8y+RfvZvdASqfQJbRlFkg82AAlUjkf4XXyNkJF3jHRibQlkeSjgPYAVkSvIPyigNPXIBXWpwAKSbRl6oJ+hEV3d4v3vB+Gb1zcLSXeHFVDlE8ZyzxjPnXvfveKVS/JN4CmlC2opGaPOfNoXc8Y3m613Y0S2m55DFI9X1PWFhoGSh4NzPKJTw8Ty+h0hDdCagOX7wbgLZytbibalNa5a0tQb7AzP93dXzd6u1Gr4DC04dmWo30gnWwMEdoV9uH/UppNTYsFFSJtNLwNcsVF489/tid2CnCYLk399duqN/xyf3Fpw6FfjNikEEl8haODU959TGT0DD6PtQmOymGE56OS/64wbOoRQWSP/03NDnNuPnA0C1E6NhrmBA+r6u02m3bmYz+EVC4kYQftuHhqMv8A/kIdJTqndj5A1HpUcZ1k6tNvcFhw+cb/spQEUiX5iAhUgQ3OVxKHWFJXnRvDKU7Y+1uJXmfYGfGTssevn5oisfYsZ3yYrPbzc7VuYbOGC1f5AtXFkasiXVzv2xIZF1hh4ZbFfSY8aYGjrzr8WjMiRCHVWwmDFkt0sdOWPoOQl+N5lK/UOv8xwQWLTAPgucOQ5Su65C+dVnttoR+GoINbKXSYI7KL9VSIYYELqjtqblzNbmeT86DOESuvl/luzQ8THo5ercSxgVzTZJzWy2U03/2KLwRR6fQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(376002)(396003)(46966006)(36840700001)(26005)(7696005)(478600001)(86362001)(36756003)(36906005)(6286002)(966005)(36860700001)(356005)(336012)(55016002)(82740400003)(426003)(2616005)(6916009)(7636003)(2906002)(53546011)(16526019)(83380400001)(6666004)(54906003)(47076005)(70586007)(82310400003)(8936002)(316002)(186003)(8676002)(1076003)(4326008)(70206006)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:09:21.3411 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a16e701d-31ea-4412-9a14-08d913cdf8ed X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3359 Subject: [dpdk-stable] patch 'app/testpmd: check MAC address query' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/9a7fd13201b9e6a874713ff5fa05db26f49f0ba6 Thanks. Xueming Li --- >From 9a7fd13201b9e6a874713ff5fa05db26f49f0ba6 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 16 Mar 2021 12:21:36 +0530 Subject: [PATCH] app/testpmd: check MAC address query Cc: Luca Boccassi [ upstream commit 2382a607599ec1e44594bd74175fc8ffcc260a47 ] This patch checks return value for rte_eth_dev_info_get() in show_macs(). Coverity issue: 353629 Fixes: e1d44d0ad623 ("app/testpmd: show MAC addresses added to a port") Signed-off-by: Kalesh AP Acked-by: Xiaoyun Li Acked-by: Andrew Rybchenko --- app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index dab8afe5dd..336d3e59b1 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -5219,7 +5219,8 @@ show_macs(portid_t port_id) dev = &rte_eth_devices[port_id]; - rte_eth_dev_info_get(port_id, &dev_info); + if (eth_dev_info_get_print_err(port_id, &dev_info)) + return; for (i = 0; i < dev_info.max_mac_addrs; i++) { addr = &dev->data->mac_addrs[i]; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.240979900 +0800 +++ 0062-app-testpmd-check-MAC-address-query.patch 2021-05-10 23:59:26.410000000 +0800 @@ -1 +1 @@ -From 2382a607599ec1e44594bd74175fc8ffcc260a47 Mon Sep 17 00:00:00 2001 +From 9a7fd13201b9e6a874713ff5fa05db26f49f0ba6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 2382a607599ec1e44594bd74175fc8ffcc260a47 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 576d5acab5..4ce75a8e73 100644 +index dab8afe5dd..336d3e59b1 100644 @@ -23 +25 @@ -@@ -4930,7 +4930,8 @@ show_macs(portid_t port_id) +@@ -5219,7 +5219,8 @@ show_macs(portid_t port_id)