From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19C6FA0A0E for ; Mon, 10 May 2021 18:10:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D0E540395; Mon, 10 May 2021 18:10:02 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2065.outbound.protection.outlook.com [40.107.237.65]) by mails.dpdk.org (Postfix) with ESMTP id CBF794003E for ; Mon, 10 May 2021 18:09:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJR4J7oPDWOqtMF1lj8EXZeE+kZaQ5HxfVEk2cErG51tK8549dJfhVm7JvoRFcVOVmD6MUgB5twanYjGsj0Qb8fAeSTkcFnTkJSXnHYotGrh/O+RCwJKrls3BVB0jbtdF0XtDnKIz9M3sD+pDV1NTr6Lr/dF/j0kV1xzGWFuW1DRXdShN7sWUxWntGxrbvtu1+PHBPHHFMKVfNakh/I4UGKPI/jA+7VEE5R+gh3STi7cMugSawCrT+YG21bICYjp986bjAVOO5sMwkyQBTOiLMLdKEF+lLCeZ9g3mAkTfx9dq6rhaKEd22i0NxjgsOe7gV+t4tG+V/1u9XXj+Y77Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhwJrdF2kYpIEZJ4ZvY2/eUMvMADh4pN4EWG5Vocry8=; b=JcvQffAMaGd7fwpLFTwBuM6a3iSB0G5keWdgp+YDccdalZwUNpEtzaEZZIZ64LnQvLuZeeISpCMFyW620IgPms9QAyB8aJ7qrj5ItI23DRSB1U9BpGmPNt2jeyZsiFm+FhQABVNlezYhDUqSZqH7ItRmJGzxwxGpBgywZnYN5f3NF7nNVG3zJ5ljEgYeOqVjVAFVDdFCaOmRgqhKG55ZQZqWOC7RsOUCl2z2nIotmnWiVQMEbkMNQmnJ913vqhaSKSFMA6TVK0wShKY52cD5lUm0wK921dpmLGRzIuiAwHDu5/WvnLimBy1HGhX/L6d91Z4V1ygkeE18GeHsHqHotg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rhwJrdF2kYpIEZJ4ZvY2/eUMvMADh4pN4EWG5Vocry8=; b=S0vdOvUGGsJMKWGKoJNlfqirP+xrdaZk1yEk97ZQlQNfNiYZ6tNW5fHIcnV1uJ+oUaJWCoClQi8JpKDbIl6OKv/qfLthTgCzPD+9uXj66HYN6D0cdD7cSJJ8byHEYNpxLlGCx7bFnqs9xvM5ApoamR1X7/JbKN1o3B0kEX2sq0MnWu5LEnaLBAr4AoAOGQNdMRy6ZCZXMveHh99KiXI5srjiZQG7Grln/bwq3mpx/nrb8tvLuVoe/nIxBBD7yiLm78MiX1poUAhxbgtm4z/r+jtqvQrNmGRm52tsSZgCUySxGb2hj5Hqk4oDa4ns+CWeWn0EdUFzP7g02ARZImZiJA== Received: from BN6PR12CA0034.namprd12.prod.outlook.com (2603:10b6:405:70::20) by BL0PR12MB2436.namprd12.prod.outlook.com (2603:10b6:207:42::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 16:09:58 +0000 Received: from BN8NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:405:70:cafe::f4) by BN6PR12CA0034.outlook.office365.com (2603:10b6:405:70::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend Transport; Mon, 10 May 2021 16:09:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT021.mail.protection.outlook.com (10.13.177.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:09:58 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:09:56 +0000 From: Xueming Li To: Thomas Monjalon CC: Luca Boccassi , Andrew Rybchenko , David Marchand , dpdk stable Date: Tue, 11 May 2021 00:00:18 +0800 Message-ID: <20210510160258.30982-69-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1d19b438-85be-4ddd-2f1a-08d913ce0f12 X-MS-TrafficTypeDiagnostic: BL0PR12MB2436: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d9o8AXjTFmEl+O57EK3krsgpJve+hQcICgBBlMbd96F6DKOqWo8UBfDA2NpgA4oCOhTDA46z2GiBbGD8R3ePcgR6gvLbKQi3KzuWUo93cPsobI2Qi/iFsj1Ai3RJ0Emjw97A+h5CWSL4ZW+Sj2G9cosMXZpv6Z+4SYKKhmHHpNQqeXyzA+pLWmtjNJfKmRZp/FUvmfKyUoS4Ts0NJuYdTrbn6y0Dt3sLeBZBdTYIgqizh4U8c+LX6hQ6V8ZjHRcQPV42g4gieRFy0O0L4eFKxrPuOnFdRbs02+/6WxyGnxshKyUdPF277uvZiJVfw365JdRZGaO5LT/0oAdhmhikqTaxd4Gy0L+5hjq5iRSHk8vgoxrwHRQyllZU91Z9m47kKbTOxhBN2jCcy/ajKoP4CzowoeOtu9Pml9Q1/iBxJQTZeSSY+5iroYROnr/Sdeigylr3thYaq4Q+JD7B57x4ndwqK5zM0qQQLqvqrAlcPotc5kB4NojxtmrhjbF7wr3F9YTR3HMM3MWbFo8t5LX10/tBM07WfIbNuIAmOrFDXTE0fVEQ5+8Ckie6txZD8P2FiSDrKr4LMuBrcHQ1BOkSOiPaeI3Hx6c1jerRoOvrTpmSjx72VbRK9SEI26aclCm0R0oP3h5/yAa/DvpicdSzTFvZDn9tmSpp/6Cdiu0Xm42NR4NVB1cyBKnFDpngagc36yVvZFTzKI/tkkxUZdpfbt+tFcJnFKGybHsloAMqA5DdxY6uPUSyKcb3fTaQKh+moUvLPIcmwyGH+WQU/TeT/Q== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(46966006)(36840700001)(6916009)(7636003)(6286002)(86362001)(8676002)(478600001)(7696005)(70206006)(82740400003)(356005)(83380400001)(8936002)(70586007)(2616005)(36756003)(966005)(82310400003)(36860700001)(1076003)(16526019)(54906003)(426003)(53546011)(2906002)(26005)(6666004)(186003)(316002)(55016002)(36906005)(4326008)(5660300002)(47076005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:09:58.4847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d19b438-85be-4ddd-2f1a-08d913ce0f12 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2436 Subject: [dpdk-stable] patch 'build: remove redundant _GNU_SOURCE definitions' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/9c3bb2603c1c964ce8fa3740e9d39ac0cf3ff4ce Thanks. Xueming Li --- >From 9c3bb2603c1c964ce8fa3740e9d39ac0cf3ff4ce Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 25 Feb 2021 09:45:06 +0100 Subject: [PATCH] build: remove redundant _GNU_SOURCE definitions Cc: Luca Boccassi [ upstream commit e0ae50c6876e899540f6116f8b4f5e5e3dec445f ] The feature macro _GNU_SOURCE is defined globally, but there was some remaining useless settings. The internal definition in config/meson.build is kept, all other internal definitions of _GNU_SOURCE are removed, except in examples, which can be built as external applications. Note: external applications do not inherit of _GNU_SOURCE. Fixes: 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default") Fixes: 28188cee2aa0 ("build: enable BSD features visibility for FreeBSD") Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools") Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko Acked-by: David Marchand --- app/test/meson.build | 2 -- drivers/bus/fslmc/qbman/include/compat.h | 3 --- drivers/common/dpaax/compat.h | 4 ---- drivers/common/dpaax/meson.build | 1 - drivers/net/memif/rte_eth_memif.h | 4 ---- drivers/net/mlx5/linux/mlx5_socket.c | 4 ---- 6 files changed, 18 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 3fdd22de7e..49fbb5e18e 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -396,8 +396,6 @@ if cc.has_argument('-Wno-format-truncation') cflags += '-Wno-format-truncation' endif -# specify -D_GNU_SOURCE unconditionally -cflags += '-D_GNU_SOURCE' # Strict-aliasing rules are violated by uint8_t[] to context size casts. cflags += '-fno-strict-aliasing' diff --git a/drivers/bus/fslmc/qbman/include/compat.h b/drivers/bus/fslmc/qbman/include/compat.h index 1ddd69e127..a4471a80af 100644 --- a/drivers/bus/fslmc/qbman/include/compat.h +++ b/drivers/bus/fslmc/qbman/include/compat.h @@ -8,9 +8,6 @@ #ifndef HEADER_COMPAT_H #define HEADER_COMPAT_H -#ifndef _GNU_SOURCE -#define _GNU_SOURCE -#endif #include #include #include diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h index 1a5f36e99e..c69e76ab96 100644 --- a/drivers/common/dpaax/compat.h +++ b/drivers/common/dpaax/compat.h @@ -10,10 +10,6 @@ #define __COMPAT_H #include - -#ifndef _GNU_SOURCE -#define _GNU_SOURCE -#endif #include #include #include diff --git a/drivers/common/dpaax/meson.build b/drivers/common/dpaax/meson.build index 4535482701..b7f177a62e 100644 --- a/drivers/common/dpaax/meson.build +++ b/drivers/common/dpaax/meson.build @@ -10,7 +10,6 @@ sources = files('dpaax_iova_table.c', 'dpaa_of.c', 'caamflib.c') includes += include_directories('caamflib') -cflags += ['-D_GNU_SOURCE'] if cc.has_argument('-Wno-cast-qual') cflags += '-Wno-cast-qual' endif diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h index 765a7e5998..7e5c15341e 100644 --- a/drivers/net/memif/rte_eth_memif.h +++ b/drivers/net/memif/rte_eth_memif.h @@ -5,10 +5,6 @@ #ifndef _RTE_ETH_MEMIF_H_ #define _RTE_ETH_MEMIF_H_ -#ifndef _GNU_SOURCE -#define _GNU_SOURCE -#endif /* GNU_SOURCE */ - #include #include diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c index 1938453980..b1f41bc102 100644 --- a/drivers/net/mlx5/linux/mlx5_socket.c +++ b/drivers/net/mlx5/linux/mlx5_socket.c @@ -2,10 +2,6 @@ * Copyright 2019 Mellanox Technologies, Ltd */ -#ifndef _GNU_SOURCE -#define _GNU_SOURCE -#endif - #include #include #include -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.443423200 +0800 +++ 0070-build-remove-redundant-_GNU_SOURCE-definitions.patch 2021-05-10 23:59:26.430000000 +0800 @@ -1 +1 @@ -From e0ae50c6876e899540f6116f8b4f5e5e3dec445f Mon Sep 17 00:00:00 2001 +From 9c3bb2603c1c964ce8fa3740e9d39ac0cf3ff4ce Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit e0ae50c6876e899540f6116f8b4f5e5e3dec445f ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -32 +34 @@ -index 099895fc87..76eaaea457 100644 +index 3fdd22de7e..49fbb5e18e 100644 @@ -35 +37 @@ -@@ -398,8 +398,6 @@ if cc.has_argument('-Wno-format-truncation') +@@ -396,8 +396,6 @@ if cc.has_argument('-Wno-format-truncation') @@ -86 +88 @@ -index 24321d3a39..2038bda742 100644 +index 765a7e5998..7e5c15341e 100644 @@ -99 +101 @@ - #include + #include