From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E65AA0A0E for ; Mon, 10 May 2021 18:12:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69A2740140; Mon, 10 May 2021 18:12:01 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2067.outbound.protection.outlook.com [40.107.94.67]) by mails.dpdk.org (Postfix) with ESMTP id 18A4540395 for ; Mon, 10 May 2021 18:12:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VyAent6Bhe5+9iURNO6WWb5Wj6/vdu4DTm2moDUN16vchojq8qA8z8QNlpRmb24nyg868dRZ1XgIqNr5rIQm7YM/xe0uTA4IDYanujOaU1baHsnN2IGHClePt9sTi2X4QE/1ZV8WDZraMIMgcGp8SSJDv5dqW5MNpcFlBglJrLW21qTh0JFqNNja1n0wfy2ioaW2B+D+CoiobDHX6tylofXVBz3nxBUU6VPSRXaFKwxufPbGkgiKfnUQX602EFDuH/HYswXTkq9DoVqkZFoDPXgyeidon66DcXqqPAEHT3visLwBjdGCI0WuiYlhBNN4PCt4EfL38mcGNuInyiaXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZrLwS/qrB4ItHqJwPG/lcoWAobCzurV/n3460CMqR04=; b=kuOlrh0pZgNUZcDPICvbcIf3GCRV8MuU1I0T/R3JBuZaZj36Zdbk+p6kuMTKNmMQXNWF7EVSyZrePmHVVDmY1UeE5/2UgSPWF44abFUSXaeh9U9RD0eVJRRlD5LxiYas+Cy+TdDsCnUYb74gnXIA8BHHCWMt+vlgbFiFTIYPwkg5k4Dbuo02xwdoKrtusupdNEUjvJJpSkWDHu40cB/uGGtexAkYIH+ifer+ryd/sgaEjh7P/LurItO38avhxKjJ25kL4HK5lvEhKDgl6Anjbcc7Qi+g3XYhhqELrA1MHEBaconHA8VtqyVEJR/FuIVsxaHLl17Vf2/jcqCDWxXtRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZrLwS/qrB4ItHqJwPG/lcoWAobCzurV/n3460CMqR04=; b=uHtbjXInk5jjD26+4ZoraG0RW8Xu3uFs0PiOnuNRztRgmIhkUSqEDgFZ+rISNUgcKyzdCcDLsAZ+tSvxXTOTYvYBtcbsvtfGD0DyvZjTLAamzPIO5ymvzvNUjdryNiKuAnAiYnWWMqrA4NfrIlN15ZNrrsh5QjSkYuaNJoA2n9AIiqWcxMjaK0EOgMdwuZHz63o5kWBkG2kzYAq+mE8COZUktyv/Izf6rJT8oeu9hqkqCY8BH+0AM7NuXKV2KJp4Y44kasApB9fMVGaUJYbsDD/wEGte8GyH9FuhQNkWqO3qKYKnoki5/4/MPaTziadGn1IvSf599ltwYerTl/tp4Q== Received: from MW4PR03CA0040.namprd03.prod.outlook.com (2603:10b6:303:8e::15) by BN9PR12MB5148.namprd12.prod.outlook.com (2603:10b6:408:119::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 16:11:58 +0000 Received: from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8e:cafe::41) by MW4PR03CA0040.outlook.office365.com (2603:10b6:303:8e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:58 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:11:53 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Somnath Kotur , dpdk stable Date: Tue, 11 May 2021 00:00:37 +0800 Message-ID: <20210510160258.30982-88-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f92a292c-b446-4ddc-0ac5-08d913ce5662 X-MS-TrafficTypeDiagnostic: BN9PR12MB5148: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7L6DACEYbBJN6IEx6eaKbz7nldl7BxusLfHr2eviv8SAUDII2AFTc2woHJNPFrEVz+ZbKGQA77oKw78uT8hrA38sKNbJNAq0lajoHdv5u8mglVkk4CY4NhBb2mrF5hCEiZ1lKuRA+I5O3qJkWj0yv8iXFIWRc5oG4V8QgYjCJ050t3nml1T5z9/nPgspRYKCTwv/KUoiYownQjA3RewAz6rLOVoivzhzHHqGFG+mTSE6Yy7zo5aIGQECunYX/ia6tVkSSzp3mSHdyOJlqUiHAQByoP5PdnrUCCjfB5Xnlz1cd+yz60bkyccyyGqFf26kmjyWh8zYFPA+usbz1L8fbzAKFveOPydnAxohyoP7Ja0X/B5RAiw4sda9yOwgaeOzUmqE9jNxRT7ds7FIXf+bEhSJrgc6hlT42/0thDW7c3pZH1SoKK8T3oEJc3s4DbcUEyne+TFRvY2LdA5ed2R07Inrba7VGzT+DDUpEwmD6yNSOVNHNvHbPmTogOqsx43qP2DQW57Pd0fIGvWnxEBH/JS2RPh9ef81vkV7hJRKiXKDP4EqAftT7BoUKF5b5jSDzMjtEFKr95DX4kmGSRfKMLwzXGzhJovM0M0vXd4S8+yqIOe3foKMz2m5NXwvttu6I3o2K6mGPUDHZeDRd+JCJ+ohDRLRPNbZqRDbi0NsDkefgddP4WCZs9IF9ReqGqpLLM5BcZ6tm7YFJ7BGvawkRCGJpBP5BvrB5icPOrIlD+FJMbp6Cw1j9akx+eLSOzNHaliGkBHFlJcGF+X6I0ctuw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(46966006)(36840700001)(4326008)(82740400003)(8936002)(53546011)(2616005)(966005)(186003)(47076005)(8676002)(86362001)(336012)(6286002)(16526019)(478600001)(70206006)(5660300002)(7696005)(426003)(6916009)(356005)(82310400003)(36756003)(36906005)(2906002)(55016002)(6666004)(83380400001)(316002)(70586007)(36860700001)(26005)(54906003)(1076003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:11:58.2112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f92a292c-b446-4ddc-0ac5-08d913ce5662 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5148 Subject: [dpdk-stable] patch 'net/bnxt: fix PCI write check' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/832c6464ce64a23d13031893868b46a9e4424590 Thanks. Xueming Li --- >From 832c6464ce64a23d13031893868b46a9e4424590 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 16 Mar 2021 11:11:25 +0530 Subject: [PATCH] net/bnxt: fix PCI write check Cc: Luca Boccassi [ upstream commit fcf953791c5c72a22741969071265b74d647c08f ] CID 363716 (#1 of 1): Unchecked return value (CHECKED_RETURN) check_return: Calling rte_pci_write_config without checking return value (as is done elsewhere 46 out of 49 times). Coverity issue: 363716 Fixes: be14720def9c ("net/bnxt: support FW reset") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 780bbe72da..f0de380271 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -3656,13 +3656,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index) uint32_t val = info->reset_reg_val[index]; uint32_t reg = info->reset_reg[index]; uint32_t type, offset; + int ret; type = BNXT_FW_STATUS_REG_TYPE(reg); offset = BNXT_FW_STATUS_REG_OFF(reg); switch (type) { case BNXT_FW_STATUS_REG_TYPE_CFG: - rte_pci_write_config(bp->pdev, &val, sizeof(val), offset); + ret = rte_pci_write_config(bp->pdev, &val, sizeof(val), offset); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to write %#x at PCI offset %#x", + val, offset); + return; + } break; case BNXT_FW_STATUS_REG_TYPE_GRC: offset = bnxt_map_reset_regs(bp, offset); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.900942400 +0800 +++ 0089-net-bnxt-fix-PCI-write-check.patch 2021-05-10 23:59:26.450000000 +0800 @@ -1 +1 @@ -From fcf953791c5c72a22741969071265b74d647c08f Mon Sep 17 00:00:00 2001 +From 832c6464ce64a23d13031893868b46a9e4424590 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit fcf953791c5c72a22741969071265b74d647c08f ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 57a409c0b7..1997783a7d 100644 +index 780bbe72da..f0de380271 100644 @@ -24 +26 @@ -@@ -3861,13 +3861,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index) +@@ -3656,13 +3656,19 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index)