From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED477A0A0E for ; Mon, 10 May 2021 18:12:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC50740140; Mon, 10 May 2021 18:12:03 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2089.outbound.protection.outlook.com [40.107.243.89]) by mails.dpdk.org (Postfix) with ESMTP id BB696410FE for ; Mon, 10 May 2021 18:12:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WxGQ7sxKZc0rT+zB54EEIhHjJV3VtX8Jj0kEtdPyl2wuPG5pKd6zWqeLIdFbXggGO5C1Kfrv7VKrAR+MhvgiImeqTuQsIMqq8MUbelW/PU3m3aCQXwD3xQ5kTqaDjJLMmP9LEhKqtJelhZAA8fQWdeGbu5bTeM6h8j9dsFhTqHmHcEbbuUfzR9WbmiEALC70eX2Kx6L9/mISnnkoTrepDlE04KWiLYUZgVANoohTvV6uNmVXFD3DWVRv9b3NcXwhcqIprDXwXHU9K478hW8yS6r9rYz0HmtclE5I1z/HqVomanAuT9a2SG5IOoO0razGfXqzfHRVVV3daqTryk9j/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8MmbpYOwdS8bpLjbIyV5HvXC0IvqIxGhrVEHhW4UonU=; b=IB7VrnbEmAPH5yzQW9b/iVERvDDNOngnekdOq5RAeS5e8WDSxw76EY1zMd8k/qJOiWNl4qlQhKtjHt34+1+QeERslql3l5pch1JvedF3o+n81TX7h9s8wNs+fUpGIB9jfZ7dRkKm2oMC+fxxFiRBMaXeYqekNUqtqvb4Ql36nsHQtuBLIWLdyZo4QPL0KscQXeAmnGU+Gsl/l/dG41jM/htP8knUCppijIKLrtcUBDfyYVbjbHiBnjP54UPF/Igv1pAgHm6/jzQTulBtvICWI1UCl0eeSTu1P9hEqbhVBLtbfB7FluY5D2vAJWlT2VPjRTzs83UNV6gI7r77L9WC7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8MmbpYOwdS8bpLjbIyV5HvXC0IvqIxGhrVEHhW4UonU=; b=GPuM7QEqiWDdr8sfXnyZmFHiUrRM21dQm0xEqCd0jYS4YjkHCie4wy2IeYt/mViZWsxpkKv7deTl+JCR2krvjb6SXBPLVFmwWNQo0QKZUsanabzyjFnnbHR7oX0gcVutXSrU53UvMSoj/QswoR93HfoLo/JTvgmNP8BiV6ZFVAp2asXtxoMiVYWiJqVRBv1qpYGxZQIVeKrfyazmUjp9r2y4qNBtM+m6X9CslybrHlsh/A+PlOj/zsCzb1C2/fSe64Tuihg1LlF3EB2OnxqRVDr8iWB++pbQPERPgmwW5czpPTZylyV8F4vBFS0wnt9xHDxP4/u1pp4hgbal0+/LIA== Received: from MWHPR17CA0050.namprd17.prod.outlook.com (2603:10b6:300:93::12) by BN6PR12MB1666.namprd12.prod.outlook.com (2603:10b6:405:3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Mon, 10 May 2021 16:12:00 +0000 Received: from CO1NAM11FT046.eop-nam11.prod.protection.outlook.com (2603:10b6:300:93:cafe::49) by MWHPR17CA0050.outlook.office365.com (2603:10b6:300:93::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT046.mail.protection.outlook.com (10.13.174.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:11:59 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 16:11:56 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Somnath Kotur , Ajit Khaparde , dpdk stable Date: Tue, 11 May 2021 00:00:39 +0800 Message-ID: <20210510160258.30982-90-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com> References: <20210510160258.30982-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e226b14d-7aac-4430-b2d5-08d913ce5747 X-MS-TrafficTypeDiagnostic: BN6PR12MB1666: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 45ZoPsnAKKg/Rp5jIo0QJx0cNZ4MEOPQ7qBze+6NEF637FerlirEM11m7RZjbfotiu0MOOu07NP/nJ7EuLxTX5H2kALjNDxr621kkUleRrEfjWXmvaAZHyKzTEQrPE9LTM9AiNVM4aORCRWqxTEkWcUfMj1pnZSJhxCt/JyjDFySbb9FkuQKFa7dgsgHt62KhiB75xOPweofdfF8kF2OhJsmJk//rNdUthNVUmzGULj4TEFANXaGiXywr9dYePur7+Yx+avo8ENyzoCesvjufPX0sRUzFuxY30TDwMrcfRmvxKRaIdvvZCVMLKsKMfGSlHLw3cGr7bGz6lxQpRHtTxFIXbgMG78dw53oBN6kx8v2Jr2TV2IOmZ5ayHYJY6BTFOUuaeBJ/bG2xhtpxvZUurc520IcwN/ZAaA5KmJBqZBgwdJGF6O082kEQslo/4JF/i3VSWY2JEetINo8/whX36RY21N4YsZXeWyz6qOf54EY/Ci5V0aUEh2G/NwvCYkD3/9BaDZ3uxP6IP4tblf/uKdojdgHr/EIPT44+IknEZ6mCigx8hpwF5Qyz7/SxHT8jkxkkgSWHwAjKklvYe+u49mj2clJXIF+8EQBNEpS3kskWi+8NAAZNOKWgp7mMU4Z87jgYNyX4AULqZfN9Pl8Igi2/2het2lgN5kMTnVcNelILzleqJbVpR0tgwRliGTuwpntfHImANCuGQZ5/DLHKC8Wt495gp2gmFnLIEiHdm10/qeVPNa5nILEORAkJMrBDDuTmHj9mQU8ggGIq2GnAA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(36840700001)(46966006)(356005)(86362001)(478600001)(70586007)(7636003)(966005)(82740400003)(186003)(5660300002)(1076003)(70206006)(4326008)(53546011)(8676002)(6286002)(316002)(36860700001)(8936002)(7696005)(55016002)(36906005)(2616005)(26005)(36756003)(426003)(16526019)(82310400003)(6916009)(2906002)(54906003)(336012)(6666004)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:11:59.7103 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e226b14d-7aac-4430-b2d5-08d913ce5747 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1666 Subject: [dpdk-stable] patch 'net/bnxt: fix link state operations' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/23f07e5fdcd49a5c46124cc840de4eca6586a661 Thanks. Xueming Li --- >From 23f07e5fdcd49a5c46124cc840de4eca6586a661 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 18 Mar 2021 15:05:22 +0530 Subject: [PATCH] net/bnxt: fix link state operations Cc: Luca Boccassi [ upstream commit 586d9da38aaa19bfe2e804c4038c3d0ec0a3ef99 ] VFs does not have the privilege to change link configuration. But the driver silently returns success to these ethdev callbacks without actually issuing the HWRM command to bring the link up/down. Fixes: 5c206086feaa ("net/bnxt: add link state operations") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 86c36e46d9..d70e37ca60 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1261,6 +1261,9 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) struct bnxt *bp = eth_dev->data->dev_private; int rc = 0; + if (!BNXT_SINGLE_PF(bp)) + return -ENOTSUP; + if (!bp->link_info->link_up) rc = bnxt_set_hwrm_link_config(bp, true); if (!rc) @@ -1274,6 +1277,9 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev) { struct bnxt *bp = eth_dev->data->dev_private; + if (!BNXT_SINGLE_PF(bp)) + return -ENOTSUP; + eth_dev->data->dev_link.link_status = 0; bnxt_set_hwrm_link_config(bp, false); bp->link_info->link_up = 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-10 23:59:28.952326300 +0800 +++ 0091-net-bnxt-fix-link-state-operations.patch 2021-05-10 23:59:26.450000000 +0800 @@ -1 +1 @@ -From 586d9da38aaa19bfe2e804c4038c3d0ec0a3ef99 Mon Sep 17 00:00:00 2001 +From 23f07e5fdcd49a5c46124cc840de4eca6586a661 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 586d9da38aaa19bfe2e804c4038c3d0ec0a3ef99 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index ff92f999db..4bdc8223d3 100644 +index 86c36e46d9..d70e37ca60 100644 @@ -24 +26 @@ -@@ -1268,6 +1268,9 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) +@@ -1261,6 +1261,9 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) @@ -34 +36 @@ -@@ -1281,6 +1284,9 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev) +@@ -1274,6 +1277,9 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev)