From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 42630A0A0E
for <public@inbox.dpdk.org>; Mon, 10 May 2021 18:13:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3BEC8410F8;
Mon, 10 May 2021 18:13:00 +0200 (CEST)
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
(mail-eopbgr760050.outbound.protection.outlook.com [40.107.76.50])
by mails.dpdk.org (Postfix) with ESMTP id 93A97410F8
for <stable@dpdk.org>; Mon, 10 May 2021 18:12:58 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=kI3YLzTx2cURd/ONkEqZZDqiKQ8oJR/wbsSlKdPhWinrFFEb2xVuFDP3MHky+ftdcmqSX0v8lq1clKYbPt8qcjyOo376Ob9HcQJb/hOyLjr4pX+e4DNT6tg5rBhxA/r5vYxxUS3KvY/Nc0Fh9x9kFk1io8ds/zapHEeFZgerHIirT7wcFtGzfhrYtqINZu52Mmqu3zBJEJNYYiIWnGCskJX/yDhXfuykyGDxPNbp8Qgz4ME96aXFWeJwzs1ZrS76DRY7okF5rexBK55wdmmjXKr8452a6jgwgiZwkfmSnFgsVYKvJwZY/kFS4cPz+1I+SoHNz8F9Ag9v94ategmxaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=rlwU0ySKG5YzePq2MoNUseBGKQls9/Jy4+7pfNHZ4Ew=;
b=dBNU241UlBVXUcMoT8jHoXq5x6zaHSHenduPwgK+2tFr74UOtNlJPW8UC1a+XH8N4aTBtez1Zm2Xo3yHwtbUQDHuL8AhXdcMQy3R9Ezb5kVBFbSyeeQENlkKpcIjyeF9LrC4cZNw82eLPtgW6G2NBT57BWqQTkwDxUs3/8tt8jBPPGNxG4EkOwL+8v4EsWAs7Vb7P8mChC5G7GgVDJjlnnq0mdkJv8KxywMH13zVmdfJ6A40edPcDdUFRKyo8kiXuqCdZAqJHWMnwyZYVqPL/AEje437Ul1s96YIjeC79HtaJf0E3suaG/01F2p2h70ZpvKmglQU6wsgaw3J5BPckA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com;
dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=rlwU0ySKG5YzePq2MoNUseBGKQls9/Jy4+7pfNHZ4Ew=;
b=RGaKGwg9m+1BxhxdD7is0AVcOPBoXkothcRmPwzfiQOLgTq0nmHkRiG5eciV5yhOiEpIV4YD4ZOJd3NntiUuoMmLSN/goOSHtNCJF3qc7L59fvYxG1Rml4DaT7N62YhfliptkGPsYaksU6jHuaBvpH9phfKt5lGH5tpV3Q/Rq5XdTsJS8tSBVvrwL4LEfbxIYgq6uqCyFGbCWwmPKJMlnq+esCOp+83abGF9/Rb8TpCmfjaVZ8cB1IKPoWt1gX4htwqa8UvBJIvpUdT7brsGbQXmiLj0nNhSVtZbPExqG7G+YCHZNOkwkzyQDN9eXCoZpxhbqNcWCmf3vrOJEUqd+g==
Received: from MWHPR22CA0002.namprd22.prod.outlook.com (2603:10b6:300:ef::12)
by BL0PR12MB2401.namprd12.prod.outlook.com (2603:10b6:207:4d::19)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24; Mon, 10 May
2021 16:12:56 +0000
Received: from CO1NAM11FT034.eop-nam11.prod.protection.outlook.com
(2603:10b6:300:ef:cafe::d0) by MWHPR22CA0002.outlook.office365.com
(2603:10b6:300:ef::12) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.24 via Frontend
Transport; Mon, 10 May 2021 16:12:56 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34)
smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed)
header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.34 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.34; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.34) by
CO1NAM11FT034.mail.protection.outlook.com (10.13.174.248) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 16:12:56 +0000
Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com
(172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May
2021 16:12:54 +0000
From: Xueming Li <xuemingl@nvidia.com>
To: Igor Russkikh <irusskikh@marvell.com>
CC: Luca Boccassi <bluca@debian.org>, Rasesh Mody <rmody@marvell.com>, dpdk
stable <stable@dpdk.org>
Date: Tue, 11 May 2021 00:00:47 +0800
Message-ID: <20210510160258.30982-98-xuemingl@nvidia.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210510160258.30982-1-xuemingl@nvidia.com>
References: <20210510160258.30982-1-xuemingl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
HQMAIL107.nvidia.com (172.20.187.13)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 68b5d922-c4ca-4c2c-f876-08d913ce7901
X-MS-TrafficTypeDiagnostic: BL0PR12MB2401:
X-Microsoft-Antispam-PRVS: <BL0PR12MB240172916943790BB5A1DD34A1549@BL0PR12MB2401.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kmdDab4XwLrrOkRlCYiD7zkp5r35u7snHIHFbgAHGvjC+xqKBdNLBFTsHryuJ3snI9z81m4LQ1EFUdBEIrkEFl92Boz7dLvuJdwnI2iO1WqJaT/vByyEAhxUM5ogLZyuCE6IXl3DLpKsb8jCUDhwS49sU3+SGRpzrQWstjCkBCkNMuapbTMZ+QARVMtuGsEvl5ZgKBTRH+p+8oUtriQPMK3ECaSwzXaaHWtSyxJyIdAs8PlpfCKPxTtAycdMXVen4PphzbVz6ixoPD+uf/TTzbp10ZaQ4PeINvliCZvRAqpM7iI8BzW8FcmX1zFdshc8p8KgFp0ywWoq3vYxhzuX8rHnReFOCGbDjbh58CEPS6vl2ds/31oIsiAPgFj0nx+jdr6EIstRQ5fNeGoxZZrNuR92IsG9MYaQUUG75+O9y7LEjBxz+6/2qb5ezzX8aHKlYWrpbbqRf5SDvx8HqrdAFjTy3UWkThkGwUs0+rSdxVMMrDXv1KdlGyuZH75Eq489jJaAOVd1nl/QGTLjApWUhETkf4Vmj5CCErWSJ9GMItBGnpc6lXnmE1JesYqfhRe0thgz2aSINnyIRK8dcCThO2yn7VS+nR1ZFXAM7epcg4o1w+DJzIcYutw3O5sZJnGv51P8mC9+fh0ZqmsuVIB1u6qNOx+TUO6KDzHpUzuIqYXr/GYSabFvbunkaMjwd/CMfriiI+BAMKVVb7BqopMckeNXJfnDeBjn8kEr2ccLFZbLGQl7H2bvEILl1wSVKkewa5f8yP04jXgKwPY/sKJ+kyGxqNXnH/qxv6oibxZxpsI=
X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;
SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(36840700001)(46966006)(336012)(8936002)(55016002)(70586007)(54906003)(36756003)(6916009)(6286002)(8676002)(83380400001)(2616005)(6666004)(26005)(1076003)(5660300002)(316002)(36860700001)(47076005)(86362001)(2906002)(356005)(70206006)(7636003)(478600001)(53546011)(16526019)(186003)(36906005)(7696005)(966005)(4326008)(82740400003)(426003)(82310400003)(135533001);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 16:12:56.2939 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 68b5d922-c4ca-4c2c-f876-08d913ce7901
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT034.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2401
Subject: [dpdk-stable] patch 'net/qede: accept bigger RSS table' has been
queued to stable release 20.11.2
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 20.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/12/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/74fc31b48fc26dc40080d207fbf577bd53191028
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
>From 74fc31b48fc26dc40080d207fbf577bd53191028 Mon Sep 17 00:00:00 2001
From: Igor Russkikh <irusskikh@marvell.com>
Date: Fri, 19 Mar 2021 10:46:56 +0100
Subject: [PATCH] net/qede: accept bigger RSS table
Cc: Luca Boccassi <bluca@debian.org>
[ upstream commit 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 ]
Some dpdk applications blindly pass fixed side RSS hash tables,
and do not check driver/device capabilities.
Moreover, many other drivers do not do such a strong check as well.
Fix it by making qede accept any size rss_key. For larger key
tables we just crop it with notice trace message.
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/qede/qede_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b1065..bfd38a9772 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2139,8 +2139,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
/* RSS hash key */
if (key) {
if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
- DP_ERR(edev, "RSS key length exceeds limit\n");
- return -EINVAL;
+ len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
+ DP_NOTICE(edev, false,
+ "RSS key length too big, trimmed to %d\n",
+ len);
}
DP_INFO(edev, "Applying user supplied hash key\n");
rss_params.update_rss_key = 1;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-05-10 23:59:29.154364800 +0800
+++ 0099-net-qede-accept-bigger-RSS-table.patch 2021-05-10 23:59:26.460000000 +0800
@@ -1 +1 @@
-From 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 Mon Sep 17 00:00:00 2001
+From 74fc31b48fc26dc40080d207fbf577bd53191028 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca@debian.org>
+
+[ upstream commit 6ceb7ab83f168fa6b8e90e4bd5a1392de1a48c70 ]
@@ -13,2 +15,0 @@
-
-Cc: stable@dpdk.org