* [dpdk-stable] [PATCH] app/testpmd: fix tunnel offload flows
@ 2021-05-11 8:03 Gregory Etelson
2021-05-11 19:11 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Gregory Etelson @ 2021-05-11 8:03 UTC (permalink / raw)
To: dev
Cc: getelson, matan, orika, rasland, kishore.padmanabha, stable,
Viacheslav Ovsiienko, Xiaoyun Li
Tunnel offload model requires application to obtain PMD related flow
items or actions to construct a flow rule. These elements acquire
internal PMD flow resources that must be explicitly released.
The patch destroys tunnel offload PMD resources after flow creation
failure.
Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
app/test-pmd/config.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 01a541cdd6..43c79b5021 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1940,6 +1940,9 @@ port_flow_create(portid_t port_id,
memset(&error, 0x22, sizeof(error));
flow = rte_flow_create(port_id, attr, pattern, actions, &error);
if (!flow) {
+ if (tunnel_ops->enabled)
+ port_flow_tunnel_offload_cmd_release(port_id,
+ tunnel_ops, pft);
free(pf);
return port_flow_complain(&error);
}
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH] app/testpmd: fix tunnel offload flows
2021-05-11 8:03 [dpdk-stable] [PATCH] app/testpmd: fix tunnel offload flows Gregory Etelson
@ 2021-05-11 19:11 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-05-11 19:11 UTC (permalink / raw)
To: Gregory Etelson, dev
Cc: matan, orika, rasland, kishore.padmanabha, stable,
Viacheslav Ovsiienko, Xiaoyun Li
On 5/11/2021 9:03 AM, Gregory Etelson wrote:
> Tunnel offload model requires application to obtain PMD related flow
> items or actions to construct a flow rule. These elements acquire
> internal PMD flow resources that must be explicitly released.
>
> The patch destroys tunnel offload PMD resources after flow creation
> failure.
>
> Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-11 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 8:03 [dpdk-stable] [PATCH] app/testpmd: fix tunnel offload flows Gregory Etelson
2021-05-11 19:11 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).