From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D3DA0A02 for ; Mon, 17 May 2021 18:16:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DADAA40041; Mon, 17 May 2021 18:16:12 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 40CBC40041 for ; Mon, 17 May 2021 18:16:11 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifuc-0008J7-WD; Mon, 17 May 2021 16:16:11 +0000 From: Christian Ehrhardt To: Thomas Monjalon Cc: dpdk stable Date: Mon, 17 May 2021 18:09:30 +0200 Message-Id: <20210517161039.3132619-141-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'doc: fix names of UIO drivers' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/98f9d3b86cc6490ed5b22f1f64b45a02969887bb Thanks. Christian Ehrhardt --- >From 98f9d3b86cc6490ed5b22f1f64b45a02969887bb Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 18 Mar 2021 12:00:49 +0100 Subject: [PATCH] doc: fix names of UIO drivers [ upstream commit b7fe612ac1de393f869c9818d5503633c8e96b36 ] Fix typos in the names of kernel drivers based on UIO, and make sure the generic term for the interface is UIO in capitals. Fixes: 3a78b2f73206 ("doc: add virtio crypto PMD guide") Fixes: 3cc4d996fa75 ("doc: update VFIO usage in qat crypto guide") Fixes: 39922c470e3c ("doc: add known uio_pci_generic issue for i40e") Fixes: 86fa6c57a175 ("doc: add known igb_uio issue for i40e") Fixes: beff6d8e8e2e ("net/netvsc: add documentation") Signed-off-by: Thomas Monjalon --- doc/guides/cryptodevs/caam_jr.rst | 2 +- doc/guides/cryptodevs/virtio.rst | 2 +- doc/guides/nics/netvsc.rst | 2 +- doc/guides/nics/virtio.rst | 5 +++-- doc/guides/nics/vmxnet3.rst | 3 ++- doc/guides/rel_notes/known_issues.rst | 10 +++++----- doc/guides/sample_app_ug/vhost.rst | 2 +- 7 files changed, 14 insertions(+), 12 deletions(-) diff --git a/doc/guides/cryptodevs/caam_jr.rst b/doc/guides/cryptodevs/caam_jr.rst index 6d9daf7364..4ee0100247 100644 --- a/doc/guides/cryptodevs/caam_jr.rst +++ b/doc/guides/cryptodevs/caam_jr.rst @@ -24,7 +24,7 @@ accelerators. This provides significant improvement to system level performance. SEC HW accelerator above 4.x+ version are also known as CAAM. -caam_jr PMD is one of DPAA drivers which uses uio interface to interact with +caam_jr PMD is one of DPAA drivers which uses UIO interface to interact with Linux kernel for configure and destroy the device instance (ring). diff --git a/doc/guides/cryptodevs/virtio.rst b/doc/guides/cryptodevs/virtio.rst index 1496ec9208..18bea6227b 100644 --- a/doc/guides/cryptodevs/virtio.rst +++ b/doc/guides/cryptodevs/virtio.rst @@ -63,7 +63,7 @@ QEMU can then be started using the following parameters: -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 [...] -Secondly bind the uio_generic driver for the virtio-crypto device. +Secondly bind the uio_pci_generic driver for the virtio-crypto device. For example, 0000:00:04.0 is the domain, bus, device and function number of the virtio-crypto device: diff --git a/doc/guides/nics/netvsc.rst b/doc/guides/nics/netvsc.rst index 6dbb9a5513..09cb6dbb92 100644 --- a/doc/guides/nics/netvsc.rst +++ b/doc/guides/nics/netvsc.rst @@ -62,7 +62,7 @@ store it in a shell variable: .. _`UUID`: https://en.wikipedia.org/wiki/Universally_unique_identifier -There are several possible ways to assign the uio device driver for a device. +There are several possible ways to assign the UIO device driver for a device. The easiest way (but only on 4.18 or later) is to use the `driverctl Device Driver control utility`_ to override the normal kernel device. diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index d1f5fb8986..667a3db87f 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -71,7 +71,7 @@ In this release, the virtio PMD driver provides the basic functionality of packe * Virtio supports software vlan stripping and inserting. -* Virtio supports using port IO to get PCI resource when uio/igb_uio module is not available. +* Virtio supports using port IO to get PCI resource when UIO module is not available. Prerequisites ------------- @@ -103,7 +103,8 @@ Host2VM communication example insmod rte_kni.ko - Other basic DPDK preparations like hugepage enabling, uio port binding are not listed here. + Other basic DPDK preparations like hugepage enabling, + UIO port binding are not listed here. Please refer to the *DPDK Getting Started Guide* for detailed instructions. #. Launch the kni user application: diff --git a/doc/guides/nics/vmxnet3.rst b/doc/guides/nics/vmxnet3.rst index ae146f0d55..190cf91a47 100644 --- a/doc/guides/nics/vmxnet3.rst +++ b/doc/guides/nics/vmxnet3.rst @@ -119,7 +119,8 @@ This section describes an example setup for Phy-vSwitch-VM-Phy communication. .. note:: - Other instructions on preparing to use DPDK such as, hugepage enabling, uio port binding are not listed here. + Other instructions on preparing to use DPDK such as, + hugepage enabling, UIO port binding are not listed here. Please refer to *DPDK Getting Started Guide and DPDK Sample Application's User Guide* for detailed instructions. The packet reception and transmission flow path is:: diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index 68c3d22bea..21a4764a84 100644 --- a/doc/guides/rel_notes/known_issues.rst +++ b/doc/guides/rel_notes/known_issues.rst @@ -419,7 +419,7 @@ Binding PCI devices to igb_uio fails on Linux kernel 3.9 when more than one devi ------------------------------------------------------------------------------------------ **Description**: - A known bug in the uio driver included in Linux kernel version 3.9 prevents more than one PCI device to be + A known bug in the UIO driver included in Linux kernel version 3.9 prevents more than one PCI device to be bound to the igb_uio driver. **Implication**: @@ -614,7 +614,7 @@ I40e VF may not receive packets in the promiscuous mode Poll Mode Driver (PMD). -uio pci generic module bind failed in X710/XL710/XXV710 +uio_pci_generic module bind failed in X710/XL710/XXV710 ------------------------------------------------------- **Description**: @@ -671,7 +671,7 @@ virtio tx_burst() function cannot do TSO on shared packets Poll Mode Driver (PMD). -igb uio legacy mode can not be used in X710/XL710/XXV710 +igb_uio legacy mode can not be used in X710/XL710/XXV710 -------------------------------------------------------- **Description**: @@ -752,7 +752,7 @@ Netvsc driver and application restart handshake sequence with the host. **Resolution/Workaround**: - Either reboot the guest or remove and reinsert the hv_uio_generic module. + Either reboot the guest or remove and reinsert the uio_hv_generic module. **Affected Environment/Platform**: Linux Hyper-V. @@ -816,7 +816,7 @@ Kernel crash when hot-unplug igb_uio device while DPDK application is running **Reason**: When device is hot-unplugged, igb_uio driver will be removed which will destroy UIO resources. - Later trying to access any uio resource will cause kernel crash. + Later trying to access any UIO resource will cause kernel crash. **Resolution/Workaround**: If using DPDK for PCI HW hot-unplug, prefer to bind device with VFIO instead of IGB_UIO. diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst index a71ada6549..66e804d63a 100644 --- a/doc/guides/sample_app_ug/vhost.rst +++ b/doc/guides/sample_app_ug/vhost.rst @@ -72,7 +72,7 @@ Run testpmd inside guest ~~~~~~~~~~~~~~~~~~~~~~~~ Make sure you have DPDK built inside the guest. Also make sure the -corresponding virtio-net PCI device is bond to a uio driver, which +corresponding virtio-net PCI device is bond to a UIO driver, which could be done by: .. code-block:: console -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:34.929236050 +0200 +++ 0141-doc-fix-names-of-UIO-drivers.patch 2021-05-17 17:40:29.419811429 +0200 @@ -1 +1 @@ -From b7fe612ac1de393f869c9818d5503633c8e96b36 Mon Sep 17 00:00:00 2001 +From 98f9d3b86cc6490ed5b22f1f64b45a02969887bb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b7fe612ac1de393f869c9818d5503633c8e96b36 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +19,0 @@ - doc/guides/cryptodevs/qat.rst | 2 +- @@ -26 +26 @@ - 8 files changed, 15 insertions(+), 13 deletions(-) + 7 files changed, 14 insertions(+), 12 deletions(-) @@ -29 +29 @@ -index 5ef33ae78e..d7b0f14234 100644 +index 6d9daf7364..4ee0100247 100644 @@ -41,13 +40,0 @@ -diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst -index 224b22b3f7..96f5ab6afe 100644 ---- a/doc/guides/cryptodevs/qat.rst -+++ b/doc/guides/cryptodevs/qat.rst -@@ -562,7 +562,7 @@ Binding the available VFs to the vfio-pci driver - - Note: - --* Please note that due to security issues, the usage of older DPDK igb-uio -+* Please note that due to security issues, the usage of older DPDK igb_uio - driver is not recommended. This document shows how to use the more secure - vfio-pci driver. - * If QAT fails to bind to vfio-pci on Linux kernel 5.9+, please see the @@ -55 +42 @@ -index 83d8e32397..8b96446ff2 100644 +index 1496ec9208..18bea6227b 100644 @@ -68 +55 @@ -index 19f9940fe6..c0e218c743 100644 +index 6dbb9a5513..09cb6dbb92 100644 @@ -81 +68 @@ -index 02e74a6e77..ac07d4d1e5 100644 +index d1f5fb8986..667a3db87f 100644 @@ -118 +105 @@ -index 43323e1a43..beea877bad 100644 +index 68c3d22bea..21a4764a84 100644 @@ -167 +154 @@ -index 09b1b6c57d..9afde9c7f5 100644 +index a71ada6549..66e804d63a 100644