From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A908A0A02 for ; Mon, 17 May 2021 18:17:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F53540041; Mon, 17 May 2021 18:17:04 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 9B8BF4014E for ; Mon, 17 May 2021 18:17:01 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifvO-0008Qa-GS; Mon, 17 May 2021 16:16:58 +0000 From: Christian Ehrhardt To: Chengwen Feng Cc: Min Hu , Qi Zhang , dpdk stable Date: Mon, 17 May 2021 18:09:54 +0200 Message-Id: <20210517161039.3132619-165-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> References: <20210517161039.3132619-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix negative VEB index' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/7930c0821608891ae6bbafcbcf421b8a43e22e03 Thanks. Christian Ehrhardt --- >From 7930c0821608891ae6bbafcbcf421b8a43e22e03 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Wed, 21 Apr 2021 10:33:13 +0800 Subject: [PATCH] net/i40e: fix negative VEB index [ upstream commit 47b6667abe533e8c61576aa4803f41daf988eb9b ] This patch adds check for negative VEB index when parsing VEB list. Fixes: 79f2248219c0 ("net/i40e: add floating VEB option") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index b583d3a0ea..f51807a3d4 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -863,6 +863,8 @@ floating_veb_list_handler(__rte_unused const char *key, idx = strtoul(floating_veb_value, &end, 10); if (errno || end == NULL) return -1; + if (idx < 0) + return -1; while (isblank(*end)) end++; if (*end == '-') { -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:35.872477792 +0200 +++ 0165-net-i40e-fix-negative-VEB-index.patch 2021-05-17 17:40:29.483811934 +0200 @@ -1 +1 @@ -From 47b6667abe533e8c61576aa4803f41daf988eb9b Mon Sep 17 00:00:00 2001 +From 7930c0821608891ae6bbafcbcf421b8a43e22e03 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 47b6667abe533e8c61576aa4803f41daf988eb9b ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 66d23d698e..d0586201f8 100644 +index b583d3a0ea..f51807a3d4 100644 @@ -22 +23 @@ -@@ -854,6 +854,8 @@ floating_veb_list_handler(__rte_unused const char *key, +@@ -863,6 +863,8 @@ floating_veb_list_handler(__rte_unused const char *key,