From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D905A0A02 for ; Mon, 17 May 2021 18:21:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73FEE40F35; Mon, 17 May 2021 18:21:43 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 5383540041 for ; Mon, 17 May 2021 18:21:42 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=Keschdeichel.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lifzy-0000PZ-5Q; Mon, 17 May 2021 16:21:42 +0000 From: Christian Ehrhardt To: Ajit Khaparde Cc: Kalesh AP , dpdk stable Date: Mon, 17 May 2021 18:21:11 +0200 Message-Id: <20210517162125.3178901-7-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210517162125.3178901-1-christian.ehrhardt@canonical.com> References: <20210517162125.3178901-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix mismatched type comparison in MAC restore' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/19/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/12a80589b8d41ce8a5d8aa59501bf23daacf5ddf Thanks. Christian Ehrhardt --- >From 12a80589b8d41ce8a5d8aa59501bf23daacf5ddf Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Fri, 30 Apr 2021 13:14:10 -0700 Subject: [PATCH] net/bnxt: fix mismatched type comparison in MAC restore [ upstream commit c8e8154390b38f9242249eb1e023df1db976a285 ] dev_info.max_mac_addrs is of type uint32_t. But the counter i is of type uint16_t. This mismatch may cause the loop condition may always be true. Change the loop counter variable to uint32_t. Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 0575d23a19..5e51da21b8 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4044,7 +4044,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) struct rte_ether_addr *addr; uint64_t pool_mask; uint32_t pool = 0; - uint16_t i; + uint32_t i; int rc; if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-05-17 17:40:37.053776869 +0200 +++ 0196-net-bnxt-fix-mismatched-type-comparison-in-MAC-resto.patch 2021-05-17 17:40:29.567812595 +0200 @@ -1 +1 @@ -From c8e8154390b38f9242249eb1e023df1db976a285 Mon Sep 17 00:00:00 2001 +From 12a80589b8d41ce8a5d8aa59501bf23daacf5ddf Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c8e8154390b38f9242249eb1e023df1db976a285 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 9c3e0f9f36..115acda9b3 100644 +index 0575d23a19..5e51da21b8 100644 @@ -23 +24 @@ -@@ -3989,7 +3989,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) +@@ -4044,7 +4044,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)