From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 493A1A0C45 for ; Thu, 10 Jun 2021 14:08:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 436E34003C; Thu, 10 Jun 2021 14:08:01 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 4F7674003C for ; Thu, 10 Jun 2021 14:08:00 +0200 (CEST) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lrJTZ-00009n-4U; Thu, 10 Jun 2021 12:07:57 +0000 From: Christian Ehrhardt To: "Min Hu (Connor)" Cc: Ferruh Yigit , dpdk stable Date: Thu, 10 Jun 2021 14:06:22 +0200 Message-Id: <20210610120641.885862-34-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210610120641.885862-1-christian.ehrhardt@canonical.com> References: <20210610120641.885862-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/l2fwd-cat: fix NUMA check of port and core' has been queued to stable release 19.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/12/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/f10ba4eba82dc5a1323be021b50ce8d6020088bf Thanks. Christian Ehrhardt --- >From f10ba4eba82dc5a1323be021b50ce8d6020088bf Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 29 Apr 2021 08:50:47 +0800 Subject: [PATCH] examples/l2fwd-cat: fix NUMA check of port and core [ upstream commit 59a50c6a9ace0dc736d71e75267a1cc2127e7938 ] According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. This patch fixes the check for a device on the node 0. Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS CAT and CDP") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- examples/l2fwd-cat/l2fwd-cat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-cat/l2fwd-cat.c b/examples/l2fwd-cat/l2fwd-cat.c index 87d6c930b6..a583e13eca 100644 --- a/examples/l2fwd-cat/l2fwd-cat.c +++ b/examples/l2fwd-cat/l2fwd-cat.c @@ -107,7 +107,7 @@ lcore_main(void) * for best performance. */ RTE_ETH_FOREACH_DEV(port) - if (rte_eth_dev_socket_id(port) > 0 && + if (rte_eth_dev_socket_id(port) >= 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) printf("WARNING, port %u is on remote NUMA node to " -- 2.31.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-10 14:04:59.680546151 +0200 +++ 0034-examples-l2fwd-cat-fix-NUMA-check-of-port-and-core.patch 2021-06-10 14:04:58.062024614 +0200 @@ -1 +1 @@ -From 59a50c6a9ace0dc736d71e75267a1cc2127e7938 Mon Sep 17 00:00:00 2001 +From f10ba4eba82dc5a1323be021b50ce8d6020088bf Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 59a50c6a9ace0dc736d71e75267a1cc2127e7938 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 02288a3824..8e7eb32485 100644 +index 87d6c930b6..a583e13eca 100644