From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3191AA0C3F for ; Sat, 12 Jun 2021 01:14:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27CC94003F; Sat, 12 Jun 2021 01:14:32 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2057.outbound.protection.outlook.com [40.107.92.57]) by mails.dpdk.org (Postfix) with ESMTP id 069BA4003F for ; Sat, 12 Jun 2021 01:14:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NkpL9YlZfgVcBjYn7FBTUs17DRX0hizfw/Guld6M6I58LBxBBXy4p1zUaR31atHiIqyi0psrTrFUVnu5asTNqNuvihzd5x1fBmHH3Qowv2CgbH/UIHafBcdb/c5pbODPqh4F8k4zceDolZ89vfB5Ha8o9KR3tvfb+eOzGrGRulCnRMOq2zw2nU/UmMBqAAjd6dDpGTAOPaiEKgy2k1++2i7LH3yN/17OsZcuHghiAwdQWDOTle24uwNzaQUCRbSbkgN7W+NIDSZ2dOUqOnrYMddNiZtdg0csdEJy93Lz9qCsbn5NoRoeUGITY7z68bPO133GUJaUXbc8pTb4HTPn8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhW+4q4ShAD+8QUvu+D7ybaULs71hFHWTegzz9/py1o=; b=ZUNF7qDeQgVvr9iZoQDBoXHjFK3JuDkZfur1urwW51LeWH4SJZbEISZ8sqCavUQX1TGCrXRZvwyMjngpOi5xHPuyCrFElpmj4TEYFuUcj9VibsyZMtVMeDUc+VhxYUo6Tur77DJN05+F2K1gRD2RGEUDtZZKczfi6ufD48WjDBIyLkE+76WAQgnhXW1duUIJra7fKU0Z/s2tYvp6bnj4NZNY5xjOot1y6BgCJfUpQvD1rDdRv9t0n3es5+ZgufV6PnfTWVNZ4wV8OBWMQHDszWUyz9pAdn8Jw1SSkRpkGhlVN/xVqSFt1ubrJgjmIJ8KiTMCpqGsUJeTMN34cX/SNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhW+4q4ShAD+8QUvu+D7ybaULs71hFHWTegzz9/py1o=; b=chri/kOmpXeVAAdrkyWxeVlLBfp+iZu6tged1jPVN1MH1jmkgZL1ZFENukb05El7LmMsuhd+vP+i3LKNV3fyk15Y+8hpJMHJPscethxKrfQNggopOuN9gezfxOOAwdErWswzGJi+IHmhbGYEFdAkH773gz0tDo/ftR76ltfYKYUgpw2T9rdMFoim9x8Mykd+qtxR9d5UcGjCKc3ZotqvfwIUafZFX4bDkxVH9qqx8A9x/xjUmQQEdup13+LHx7vj4ibA6lntjF4nIDriZLcTkSsjqJ9f5L4adCNR44Mu6Az4OCleazbPcKLHBhvSeDk1tjeS2FgysJoMaxnFgaap9w== Received: from BN9PR03CA0465.namprd03.prod.outlook.com (2603:10b6:408:139::20) by BN6PR1201MB2481.namprd12.prod.outlook.com (2603:10b6:404:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:14:28 +0000 Received: from BN8NAM11FT044.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::f8) by BN9PR03CA0465.outlook.office365.com (2603:10b6:408:139::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:14:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT044.mail.protection.outlook.com (10.13.177.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:14:28 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:14:26 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Erik Gabriel Carrillo , dpdk stable Date: Sat, 12 Jun 2021 07:03:15 +0800 Message-ID: <20210611230433.8208-101-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d08b6ec0-6a12-4b19-5ea2-08d92d2ea9b4 X-MS-TrafficTypeDiagnostic: BN6PR1201MB2481: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LM8ZN7azonN5Xi8euDRXxqVfsuI1fUb8gGUXAyaIMrRsbrNK9Sa3e3gcoyFKqYGLY/STfngcsnOvhiVsrHMHJnAfgWRUyWIUxNKjukKokgy2JZF4YOKa3kzIPUymwb+3YXsGm+GxTOvc68QssBH4v8KHNl4hSQWBeEpMQNBZj6C3dJ/G0Oms404vVeOnOytOhgJlc7nAD/+AlNKFbfi4D1opBIFsIio3lB8ZjZqdls3z+33wKz1KvjwK54gsny4ZB2zV3wfWY2EDFcce3NB0NnBeZWuDTaB7xoEIPPzB/VPa7l19v1di1uAtNTBKn2PZ71q2mRPc1/9itb6AQaIx3o38/S7DjbH4oF/dF/04cHQ4gvXHQQ8hjcAwYloHjRfAzagdAGcuvtunmVnXJpjnU5QcCfSLh1lCE6/XdWJZu/FwIpwGw9MFs/DMIi++noUovf15IskV4T1SI/Ymw02m2Vz/PV9flbqCAmmqBt9caKmfkcaZELszkZPY4KZtevTfwgSjSRGsSNK99z0j1PW3vTz9rOo3qiLPmor08wnUMUD5UfTobmJX1WNL/7uXgBZNrC+8umrUXbQSH9SnLdA+PxQvCUFhF4icGRZP1kBJcRrSBncDq/IIfihRXsjKfHx1ELz4nVIi1WvpgIPubBoY1CjnHmDjv4hgIVDCLzsqfoE7JGlPk/c/gPsnvoWU5Zeo5+CfFeayIn/tktpiSERzgv/0ak5m5z5jYBz+l7PBalUAOML5C0bjQ5X1Hk4vpnWl9IzpGZ57rF8hwhHKircTElA6RUHxTTb73Y+X9DdbrDunDk446gOBLe+9NHBYYoa6 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(36840700001)(46966006)(6666004)(36906005)(316002)(2616005)(426003)(53546011)(70206006)(336012)(966005)(47076005)(478600001)(86362001)(26005)(4326008)(186003)(6286002)(16526019)(1076003)(54906003)(5660300002)(356005)(70586007)(7696005)(36756003)(82310400003)(8936002)(36860700001)(8676002)(55016002)(2906002)(82740400003)(83380400001)(6916009)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:14:28.6652 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d08b6ec0-6a12-4b19-5ea2-08d92d2ea9b4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT044.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB2481 Subject: [dpdk-stable] patch 'test/timer: check memzone allocation' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/14e975dea9267eb7d023b204f22e839bc8fbd59a Thanks. Xueming Li --- >From 14e975dea9267eb7d023b204f22e839bc8fbd59a Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Tue, 4 May 2021 09:07:49 +0800 Subject: [PATCH] test/timer: check memzone allocation Cc: Luca Boccassi [ upstream commit fb9b862e7c0ddee29df36feb8dd0cbcd2762db25 ] Segmentation fault may occur without checking if memzone reserves succeed or not. Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process") Signed-off-by: Min Hu (Connor) Acked-by: Erik Gabriel Carrillo --- app/test/test_timer_secondary.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_timer_secondary.c b/app/test/test_timer_secondary.c index 1e8f1d4549..16a9f1878b 100644 --- a/app/test/test_timer_secondary.c +++ b/app/test/test_timer_secondary.c @@ -125,9 +125,9 @@ test_timer_secondary(void) mz = rte_memzone_reserve(TEST_INFO_MZ_NAME, sizeof(*test_info), SOCKET_ID_ANY, 0); - test_info = mz->addr; - TEST_ASSERT_NOT_NULL(test_info, "Couldn't allocate memory for " + TEST_ASSERT_NOT_NULL(mz, "Couldn't allocate memory for " "test data"); + test_info = mz->addr; test_info->tim_mempool = rte_mempool_create("test_timer_mp", NUM_TIMERS, sizeof(struct rte_timer), 0, 0, @@ -171,9 +171,9 @@ test_timer_secondary(void) int i; mz = rte_memzone_lookup(TEST_INFO_MZ_NAME); - test_info = mz->addr; - TEST_ASSERT_NOT_NULL(test_info, "Couldn't lookup memzone for " + TEST_ASSERT_NOT_NULL(mz, "Couldn't lookup memzone for " "test info"); + test_info = mz->addr; for (i = 0; i < NUM_TIMERS; i++) { rte_mempool_get(test_info->tim_mempool, (void **)&tim); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:59.220674400 +0800 +++ 0101-test-timer-check-memzone-allocation.patch 2021-06-12 06:53:56.450000000 +0800 @@ -1 +1 @@ -From fb9b862e7c0ddee29df36feb8dd0cbcd2762db25 Mon Sep 17 00:00:00 2001 +From 14e975dea9267eb7d023b204f22e839bc8fbd59a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit fb9b862e7c0ddee29df36feb8dd0cbcd2762db25 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org