From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 205EBA0C3F for ; Sat, 12 Jun 2021 01:15:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17B714003F; Sat, 12 Jun 2021 01:15:36 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2043.outbound.protection.outlook.com [40.107.243.43]) by mails.dpdk.org (Postfix) with ESMTP id 5D761406A2 for ; Sat, 12 Jun 2021 01:15:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWDRHYsoGoSm/GaQhglZmGZTWsXwz8CiuEtievUS5Eh0juBuZYIq7xjJraCyGeTtNRBHcSmEqkqUiAtnGfbn4NAvovpflsGMQkFvv+nvvSCAmaLOh4QfLQJFCIBJtEsfmTHh3tWDm1BSpvpgtMvThI6+ehptg4APl3+IvZjJ7Ra+QCHNLiNg5pZLPI893ZqOmG/dyV153n8kKKOjH91Th1Vg6Ddx7MBhrDAdXKJbEh7qAG3i5k+Zm2td7HJSYoji/Y+UNVCKAVNGTlEjkbmHpWgbLjxavXS1xlvBh8AaipmCRBmKS24Js2iCllXBLKEHyX21CF7mWjWQV9pYtMNPXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8BeSzJkbw63NolgjQykdV/mnQIoSVjqOeffHS0foP0=; b=VWWkzgHtAROl6RZTVWUotauZjmwQbesQyHEPA589rtHx1JrCEUlPZeK/pF/ZF9I7VHW3Y7nugvsKxkqQ/i0WL3Rf2EP1LE5AHuyph/pt4C1MlkVKeYuH6ehrrBr2MOVI+ZxrshxA5B23dk5xInpogfU9VhYGI7QlFbwhjaroPSoBHi8foAd73nKP+8rwXy5ugUvkZMTm9KPaeyE4O3ccXPmgKB65qvJf882TTgE9/tQMruG1V13YkHd5Nk7Y8lAVSgm6nen0MaGqPJdfhWTVNWpmnl8oUK4SdcSNi9xIfQZSnamYQawhDOsaqg2KuAPfDndQ7mxvos++h4S+GB35aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8BeSzJkbw63NolgjQykdV/mnQIoSVjqOeffHS0foP0=; b=Ccitct2Mzei0Gp9VyQirhHyqsPKHbyPD4v18UmreiFFEUWAX1gboVTgZf7KyYKJHx43xK1nKSpozwteVI9wf7c8nYiMngioz/B+SMPRaCgEcCy3/rnxs0UE6P6D3yiDFj7qlzC2kLbCkBbDBuXDG/WeaCyg14/HxNJry4AGa9PuDmJ5clvZzUdAWe71+OKlbAb5NQZ3n+lY2Yhow+MlqcPTwLbKRjNK5bwFvjgMDN4Gv8PNft6m8Lds7R0WDwNrPtvD8CxYw8jqTvSSy1rWoWXkVD8LTvpaeNVTTQsDRfmxorra46ZpPt0HI1A2zapFvm/6HS6z645AeXqQANNxxwg== Received: from BN9PR03CA0070.namprd03.prod.outlook.com (2603:10b6:408:fc::15) by CH2PR12MB5516.namprd12.prod.outlook.com (2603:10b6:610:6b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:15:33 +0000 Received: from BN8NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::43) by BN9PR03CA0070.outlook.office365.com (2603:10b6:408:fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:15:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT049.mail.protection.outlook.com (10.13.177.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:15:32 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:15:30 +0000 From: Xueming Li To: Michal Krawczyk CC: Luca Boccassi , Igor Chauskin , Shay Agroskin , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:03:28 +0800 Message-ID: <20210611230433.8208-114-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ca5d7de-8827-4688-f5ef-08d92d2ecffe X-MS-TrafficTypeDiagnostic: CH2PR12MB5516: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 85+qSqfxlXiC+R9322ybkn8GYUYxGPdY//0dooRmihm9981k8AubhoC6zh92L6/NsL5xZ2lx/VGwbJV4UE8kUZg+2ecFfi+PWSKsKxZ9CavyjGdOxoLg4LEeu12Zed12q8rCKIqTmyoAqutlvc5tZ96GSMl5QFDuiwxFoO2/qZpgzC7jaBaPS3HbKZPeQgXenm9Q6WO86yl9N/W2VRyExz/1/zExZEWqvwfuIrgojjpUm0NDjSE4Nvq4tbmwe2XES87vemFG5VgXdEIAG+p+PhG1unPeIwxYU9Al39cDbI8e7i8ZuTEU9vtEvY087JsPQfKRIMuibW3AQebpABn1dBw61Lz7OnfTrnLgePra7uNVNnVes9acdXNNIX1Vguh+r5dc1zElX8OyBm/u2Loy0ujaQG8xRmSUMalJv73PrraeT561MLU5BLd5CiUwBXuyu7zCL8MNBNhtKUZlP4f4tBW0uJ/aX7AlgxEY8/7mIBl6v3NdWKfocvWk8GDxOyJ5nzSAICLLA2d+s3NolPZzffGULrHelv1sAgsBrecS9fD7j7llIoTddOgUqSmEmVJXHHjl+tfxbi4faKDgIC0QN4yyDGmyDRpQtXebQqYqtm74DzBDAdeap1wr5l9MZqxhUvOFfG7GNqRbembHT6mZ+cuvG0A3npEWZbejbjMIhxN8hBaeksA9KUQbD6lBCHbuDjihHtdFkTg24Pg/Ye8diWgcBBd9XAGftzTS1zP+zWOv6229p7QvHmtq60uyt+l3Q4RA1AW6EEmugm2av0NP5x6LgdpCTo/F/T76BtOpGQ4Nq3KKyjAH9J+EzuD0OZHw X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966006)(36840700001)(1076003)(426003)(966005)(36860700001)(336012)(7696005)(16526019)(2616005)(70586007)(6916009)(26005)(55016002)(5660300002)(82740400003)(4326008)(2906002)(54906003)(47076005)(36756003)(86362001)(316002)(8676002)(36906005)(6286002)(478600001)(356005)(8936002)(7636003)(186003)(70206006)(82310400003)(53546011); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:15:32.9265 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca5d7de-8827-4688-f5ef-08d92d2ecffe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5516 Subject: [dpdk-stable] patch 'net/ena: fix crash with unsupported device argument' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/967dcfb168c8e8d79df4e5855b27cd66b68cc0f2 Thanks. Xueming Li --- >From 967dcfb168c8e8d79df4e5855b27cd66b68cc0f2 Mon Sep 17 00:00:00 2001 From: Michal Krawczyk Date: Tue, 11 May 2021 08:45:47 +0200 Subject: [PATCH] net/ena: fix crash with unsupported device argument Cc: Luca Boccassi [ upstream commit 9f220a959d4d7208491efea8ca8e0c4a96b98f0e ] As the documentation of rte_kvargs_parse() states, the valid_keys argument must be NULL terminated. Lack of this feature may cause segmentation fault if the passed devarg will be different then the supported value. Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers") Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shay Agroskin Acked-by: Ferruh Yigit --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index e7547af144..46ef021072 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter, { static const char * const allowed_args[] = { ENA_DEVARG_LARGE_LLQ_HDR, + NULL, }; struct rte_kvargs *kvlist; int rc; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:59.523900000 +0800 +++ 0114-net-ena-fix-crash-with-unsupported-device-argument.patch 2021-06-12 06:53:56.500000000 +0800 @@ -1 +1 @@ -From 9f220a959d4d7208491efea8ca8e0c4a96b98f0e Mon Sep 17 00:00:00 2001 +From 967dcfb168c8e8d79df4e5855b27cd66b68cc0f2 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 9f220a959d4d7208491efea8ca8e0c4a96b98f0e ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 53647cc56e..9721a70cf8 100644 +index e7547af144..46ef021072 100644