From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C98A0C3F for ; Sat, 12 Jun 2021 01:06:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A296D4003F; Sat, 12 Jun 2021 01:06:04 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) by mails.dpdk.org (Postfix) with ESMTP id B03F9406A2 for ; Sat, 12 Jun 2021 01:06:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yw+L6xXslNUs9xXXLP9QNp3wOQN0jqdq5uS6Iw6ne3C/2M2Y7vTKs/vG12iEjd4/aN9hIaJnCF5GPEdeqVGM50+y4prWYJNkr3B1JnaziEZadDJAeRucDQMCnmMcsqtX+AyRl/wKB/f1AK7gBzzKXNYgUzfAWH4XqWUo+Eos5d8+T/COt+b79duX3uEbClw2OWYaNK3GO5WGHaSMHsMJWmgUA2GBibroYdGU9hQKwb54iFHUIvJSIv5aAQrFq+s55E3SDM2rIj8Q4pwni6G6qRAxmPitReFdFvyfHE/V6ifQ33+oFb7Gb+7xqxal11Cz8bY2qLGfr3nVqdBNaJhTFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8xnjEZl/CvqqYhJvPUb8dRZWi6CuLjxt/bQaSMn0V6w=; b=Oau4Y5RaDHmlE20UEdnjtaIiWT+ao89M29vij0MlOwJl6QRVmxsIhd+0JqhBbdYlqjX8y0oOeuPtaxaQeBrseT0P9RMCXSOXlcYGoXSbCZH2Gy+XMHeEk+NqJxm4DqLsShpPLg95KARCHdNqdzVijzneldqwQK0T2D2VANNsiTL8DH/Dp4NzfaM+hzxI6g6KzrqpkS6ccX4kMa6Hxe/LyyYQDlaEHYIW+i6FY1SF572XtCboxy8lUtBnSNhmS3Vfew064rxQJouRkbPaajvpL9ca3tsW4fHEXH+xEA+CJBVi7Wm7InpS3fkipd+49fDvDVafipl09HVfQYaTHRE8gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8xnjEZl/CvqqYhJvPUb8dRZWi6CuLjxt/bQaSMn0V6w=; b=qxgPb1KE2M6KNBdgomYTA174hdrM99Y7gSNKjxLhv6l1jgulkVUE23Bd/u9bXVHi+MXSNTXXkMzJOV3GowwJY7tEKirs8yAJdSAaffjU54RQNBxOm+dkOzS9qnLdnMcDBoyq8aSK0nK5EDzurODHRJ+pRWqXUhpASFXKJWs73POU60ADxOrYJFKPyW8t4MClBMyCmYVvvLkxMNbjR+oPZ47uL5XoeawiUzx/JqzPWal+E1G6So/9tQ+VGdC1Ls7cyUSqN7I4AQr7C06LMrXDJqy6WqKmTQunMPNVlf4EuPldc6jaafiDl7Ff9D8YdkYNpSZLGXqpak9lRt+5vlXFiA== Received: from MW4PR04CA0077.namprd04.prod.outlook.com (2603:10b6:303:6b::22) by MWHPR12MB1134.namprd12.prod.outlook.com (2603:10b6:300:c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:06:00 +0000 Received: from CO1NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::cc) by MW4PR04CA0077.outlook.office365.com (2603:10b6:303:6b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24 via Frontend Transport; Fri, 11 Jun 2021 23:06:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT047.mail.protection.outlook.com (10.13.174.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:06:00 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:05:58 +0000 From: Xueming Li To: Anatoly Burakov CC: Luca Boccassi , Reshma Pattan , dpdk stable Date: Sat, 12 Jun 2021 07:01:46 +0800 Message-ID: <20210611230433.8208-12-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16003690-2867-4eed-52cd-08d92d2d7a77 X-MS-TrafficTypeDiagnostic: MWHPR12MB1134: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HqXqqnQjBJE8+hYtQB8eS4rBEID7HrWgwEWmNRa6HLKS2HXIRyOXy/+FI6BQY2t/fXRT51hCjh9PUi5PPn47W0coSMcOWp0lIUR5jPK0nnp9n6HBIPM+ObzfvrijWcj5ll8F+/7WA4Dzpz3aM8nOonSzdiEJ2Ydg3X/m5fUUGg9XqWQQn6F04+JT9YvzXRDdhEYFIkyR+4SJJSstMIIvLFqHybdKxqokUSvOHY4O91bhamplCLv/0wPK2g37K8+ugtkTfaENyR+I487P8ROmycJS2dk8Vqrmtq13QElkqnkG+cTIeWAb7YmMddNW3VxdMJbvaPtDZGu7XVMYd2u1HnO0U/Y/g6g7ZzpMb5ZmMIS5WpuG1156UzJ3AvKg1JEjh8iCFpNbv5JfqoGkUBuIWmXyh/lZ54jPP3rQPEh5bCit+zH1k+Avzk/NQr2BVKpGcsu/cPh5uY8mqYP5q0Fdf1mp+hDv3MN9V4j4FwVFefirw9da20NVnYLKSOBJSOAqWcpqgLzOnASifNi6GV9AfN8dFrFaVqlGnvBrVsrl2A4DmUA4xOdIyqwpR4wg3PHTqLYVMjnTpO28vMLRBUDfNHYy4oPcNdJEUy8C7V20N2Alnuid7inHCCbnit+YVHiQYp1MONCcaU/nNd5cSGzipwPRBH1FFUaY+7r6PMQ/uKwr8zw9wA+vk6i0zOgntUzvuvh/P9VdzqXytGMw2VJbRPJB5wKFe52kMJqXeteQZpHsQ1+5ll4AkUZwueMqToDi2MDsH0XH2bv4QX2I3FHAI4O8/H/L67/vQIwAXyoK4KE32dh4UqnHmAvPixlktdkl X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39860400002)(376002)(36840700001)(46966006)(82310400003)(426003)(336012)(70586007)(70206006)(26005)(53546011)(186003)(7696005)(16526019)(4326008)(54906003)(6916009)(1076003)(8936002)(86362001)(36860700001)(7636003)(82740400003)(356005)(316002)(83380400001)(36906005)(55016002)(6666004)(47076005)(8676002)(2616005)(5660300002)(478600001)(6286002)(966005)(2906002)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:06:00.0014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16003690-2867-4eed-52cd-08d92d2d7a77 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1134 Subject: [dpdk-stable] patch 'power: save original ACPI governor always' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/7abfd667daede27f826a336876d9ba83d85c1257 Thanks. Xueming Li --- >From 7abfd667daede27f826a336876d9ba83d85c1257 Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 23 Apr 2021 11:01:56 +0000 Subject: [PATCH] power: save original ACPI governor always Cc: Luca Boccassi [ upstream commit 7f15f0fbed656a8e18006bd8451e2059571b9447 ] Currently, when we set the acpi governor to "userspace", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is empty. Fix it by saving the original pstate governor first. While we're at it, replace `strlcpy` with `rte_strscpy`. Fixes: 445c6528b55f ("power: common interface for guest and host") Signed-off-by: Anatoly Burakov Acked-by: Reshma Pattan --- lib/librte_power/power_acpi_cpufreq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c index 84a9d75207..d028a9947f 100644 --- a/lib/librte_power/power_acpi_cpufreq.c +++ b/lib/librte_power/power_acpi_cpufreq.c @@ -152,6 +152,9 @@ power_set_governor_userspace(struct rte_power_info *pi) /* Strip off terminating '\n' */ strtok(buf, "\n"); + /* Save the original governor */ + rte_strscpy(pi->governor_ori, buf, sizeof(pi->governor_ori)); + /* Check if current governor is userspace */ if (strncmp(buf, POWER_GOVERNOR_USERSPACE, sizeof(POWER_GOVERNOR_USERSPACE)) == 0) { @@ -160,8 +163,6 @@ power_set_governor_userspace(struct rte_power_info *pi) "already userspace\n", pi->lcore_id); goto out; } - /* Save the original governor */ - strlcpy(pi->governor_ori, buf, sizeof(pi->governor_ori)); /* Write 'userspace' to the governor */ val = fseek(f, 0, SEEK_SET); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.001743200 +0800 +++ 0012-power-save-original-ACPI-governor-always.patch 2021-06-12 06:53:56.020000000 +0800 @@ -1 +1 @@ -From 7f15f0fbed656a8e18006bd8451e2059571b9447 Mon Sep 17 00:00:00 2001 +From 7abfd667daede27f826a336876d9ba83d85c1257 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 7f15f0fbed656a8e18006bd8451e2059571b9447 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ - lib/power/power_acpi_cpufreq.c | 5 +++-- + lib/librte_power/power_acpi_cpufreq.c | 5 +++-- @@ -25 +27 @@ -diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c +diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c @@ -27,2 +29,2 @@ ---- a/lib/power/power_acpi_cpufreq.c -+++ b/lib/power/power_acpi_cpufreq.c +--- a/lib/librte_power/power_acpi_cpufreq.c ++++ b/lib/librte_power/power_acpi_cpufreq.c