From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 168E9A0C3F for ; Sat, 12 Jun 2021 01:17:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F68A4003F; Sat, 12 Jun 2021 01:17:36 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2064.outbound.protection.outlook.com [40.107.100.64]) by mails.dpdk.org (Postfix) with ESMTP id 05C3D4003F for ; Sat, 12 Jun 2021 01:17:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9WvbqKkzT86i8Y/z9oR3Wu4ywoLpBMslF4FF8Liq8G4AxqDQaCND0/7IOTeNsAE4krq6G8LcZlLkKfqVgJS70TGiACTjHi11ll1PHjaEfXLKerzfShVEtge5EjamHGyxHRZV96ru9/MhoatWK8UDwJGRPb6+pIn7OQSgS9/OMpMZAOjy41vY4vPgM2/WQdvSVhGWYuPn6038QN8bO17dRpLhOcwxjEQVHQxvtDztyfsjeUC2ddjdiOErI0lC+bNeRv2Y+3I/kPiPX31DYxPAitb3yD6i0RFNJHXUlC0Qu8foCIduslghUzkpGLHrlROxAX/L2+w9Hf8lgZi32/uUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kUCGM7rzb4gZQ7C2n/2nTMfy7Qs6upzszWDZaAR4a1Y=; b=b8X1qcBXJPXYuJ8WOv8lLqJeWyRaoYq/b4Kq//KaXwcj2aNjVnqdKs/TGvtJbNBwp25K7cSqwuTjHPp15u9wzOzH2KjqPms8hHW06m0Apya/I1dDOkbVqD2CNRwgR1BpNxZq0VQ6RPPYXXdLUbuTEeX2m6G2flC7jwc/O6gCNe/e07FUUY0Z4jtvqYpQPY8USXrUowBZUsmrWr10mfJjJIsReLtz1YUhrdlYdC7pconk7Orumds0423Za2pPGs0apve26eooytObO3oSyWXjeMobICt8LGzZ8+NJ37c9wOy5f14rCQn48CYWZHDn6bgqhXWj63H5ElbQ4HwGTR9fPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kUCGM7rzb4gZQ7C2n/2nTMfy7Qs6upzszWDZaAR4a1Y=; b=LhHKG+/Zgw13VNCJ03diBffeHvbQ3z17yi+3ZgupXxxmCZwa236bM5DlhEVVCGQWkJS4NFk3sDzeT6IfeT9hbgwlqoFo3x1DgwgpHnc5bJDWjlVwczwSYFLVOLxsk6R81WTWfY1ZQb0+Zxpcq+eVEQEEabv50Hs/m0Ff+qwenZ/t7WYfxIVn3zfNdyo+c+rgX5+rHK8KOmEqnQ8a4lJZ0imNFbegshDIHVzEvqRlhmmanLGlibqZH8Eqz6Qk4XH1GnSvjPyC5p0WokaQPFIx+DouwLqIZ4N2IpflB/VsqqeGmxfnwPagKH7UsBV1N58VZ94fLzuxRn6epk0xXTzXMA== Received: from BN9PR03CA0452.namprd03.prod.outlook.com (2603:10b6:408:139::7) by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:17:31 +0000 Received: from BN8NAM11FT060.eop-nam11.prod.protection.outlook.com (2603:10b6:408:139:cafe::27) by BN9PR03CA0452.outlook.office365.com (2603:10b6:408:139::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:17:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT060.mail.protection.outlook.com (10.13.177.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:17:31 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:17:27 +0000 From: Xueming Li To: Jie Wang CC: Luca Boccassi , Qi Zhang , dpdk stable Date: Sat, 12 Jun 2021 07:03:48 +0800 Message-ID: <20210611230433.8208-134-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18be92d9-7f01-4299-2ff8-08d92d2f1679 X-MS-TrafficTypeDiagnostic: CH2PR12MB4309: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RTRQ/gemy7Rvin+VWOB8ynr3vwzEpQAKCtM/g9tW18epjrfHgbEis0l8/5VMjUnWRrz2yRzqAKwpFWKByenxzVOhouLotGzReYMgpmNz+LVylHAe+IZaMGIpjqkWEsKgVhggOW7rtiGfLZcTdfkTJQym6zKBPJFPOLmfHrj6KA2sHgM1LMBJrtNs+4IaP766sa54P4ngksRvxlWbyT+ES8I6KWZEOKW+MXblSNbDfa6Mzi0N8aSvvFsx7dbFRbYGWHW/zsUtbQt/LLLcDj4sj1PSSQTyR08CFeOhyfppfPXVobXuZmAbf6rCdzMHrYdhgURVcDf6tCo6sPQsgRBLOJ3IkVRW9ThbjkXucwq4HEPdP8ce3D6Drlkv5d3JwjvmkFnBChWfaggaZt1pX/yUnLp1eMlvc8XMHeNgWm+ym4Z57ifsj1NNzFGZwnT46jHk72NF654dVxsdlkSccmXJST9qahnDnq7vX9UzS6Oz6HiP1XMJNHvGB4196UdoimTu2TzK7+8rvn8rf88uUk5fJQM2MHKQ7ECmvyEDZZ+lTZXB2UGic+FEU+T59dRkeSUZc550pzSICK8DaizVQJZorwPUsAVpD2IcdrF1DKPgG3hvieZZAZi43JT6zM1sC9/H5Nh0gE3Cz1MM5qnmwkaQWc2W4+ZqTOqH5f7WE3LcEi7gZ556WFQtvIY8QgfUJmhpi3sKgggkS64LifPI/OGWZiqRGnO0HAyQ6vYd00zuaxU69YrLvVNs3IjQAK1tb5VcO7AtAJvaFTVXR6zNiGNhfx4tqCqm6wX9OH7zO2WtD0YUCIeY/povkNKMzItdnzGJ X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(36840700001)(2906002)(6286002)(316002)(70586007)(82310400003)(55016002)(8676002)(8936002)(82740400003)(1076003)(4326008)(6666004)(336012)(53546011)(36906005)(70206006)(36860700001)(426003)(26005)(47076005)(36756003)(186003)(7636003)(54906003)(16526019)(966005)(83380400001)(5660300002)(356005)(86362001)(478600001)(6916009)(7696005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:17:31.1020 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18be92d9-7f01-4299-2ff8-08d92d2f1679 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT060.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309 Subject: [dpdk-stable] patch 'net/ice: fix VSI array out of bounds access' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/2e077407fee708a0f6052ed44b33e7abcea598b7 Thanks. Xueming Li --- >From 2e077407fee708a0f6052ed44b33e7abcea598b7 Mon Sep 17 00:00:00 2001 From: Jie Wang Date: Wed, 12 May 2021 03:14:07 +0000 Subject: [PATCH] net/ice: fix VSI array out of bounds access Cc: Luca Boccassi [ upstream commit d7ea27d065ebe3206c0739c67bf66510c0ac79a1 ] In the loop, when the index of array "vsi->rss_key" is equal to "vsi->rss_key_size", the array will be accessed out of bounds. Fixes: 50370662b727 ("net/ice: support device and queue ops") Signed-off-by: Jie Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 2d265fbaa6..40498f038a 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3227,7 +3227,7 @@ static int ice_init_rss(struct ice_pf *pf) /* configure RSS key */ if (!rss_conf->rss_key) { /* Calculate the default hash key */ - for (i = 0; i <= vsi->rss_key_size; i++) + for (i = 0; i < vsi->rss_key_size; i++) vsi->rss_key[i] = (uint8_t)rte_rand(); } else { rte_memcpy(vsi->rss_key, rss_conf->rss_key, -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.018108600 +0800 +++ 0134-net-ice-fix-VSI-array-out-of-bounds-access.patch 2021-06-12 06:53:56.580000000 +0800 @@ -1 +1 @@ -From d7ea27d065ebe3206c0739c67bf66510c0ac79a1 Mon Sep 17 00:00:00 2001 +From 2e077407fee708a0f6052ed44b33e7abcea598b7 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit d7ea27d065ebe3206c0739c67bf66510c0ac79a1 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index f742d07fc2..5fd5f99b6f 100644 +index 2d265fbaa6..40498f038a 100644 @@ -22 +24 @@ -@@ -3040,7 +3040,7 @@ static int ice_init_rss(struct ice_pf *pf) +@@ -3227,7 +3227,7 @@ static int ice_init_rss(struct ice_pf *pf)