From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F16C5A0C3F for ; Sat, 12 Jun 2021 01:18:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB3974003F; Sat, 12 Jun 2021 01:18:02 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2073.outbound.protection.outlook.com [40.107.244.73]) by mails.dpdk.org (Postfix) with ESMTP id E535E40E46 for ; Sat, 12 Jun 2021 01:18:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ggv0mgcJZaPQNiS+LS90nlPrVYIke37z6iEIWeWxQo6LwTHxasO55Dto4XUdMOgzmAGqXFxtsLaKR03dwkrUkfK73F6plCO75dI2YgXC+SQ8Oyd5jvpJkjgXnGZMoilj5pZ0suDJLSy+zWxorSo+PI9WFcJWCQ8pWPY50aGAZrGDgiEqpjjuvxc4yay35V6xXiZwnvwDft6d4q2dTp/X0CdeTySLlow6wCnpYuNzqCmi/eVQVXoix0QJSkInsc3Bv6hJ9xblZCr4gc1mNPSPSunQvGb5gmX8Re7iZPeAb1SVCb1b0x56ROdkNl8/lvfrec3fFbzhBUrooAwY+JjQ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+OXT/28lGnI0Sh3y80wx832Ca8GvVt+kK8raRC8Ii94=; b=WRWbKWBvfx/G8AByHZg5d6gKooQ8fmK86vqotYyigDrLDdCt8yRVNIUjc/kPlX5p5pxQhghPOMvkaaBn0y2RrwSpvH3prWhuTevSh/7mLZnrGxqKhk4NdR/gwEbW+Xto0okcqYZ0Knxwb/8KeGCHUOtdGveH6FTeD4ctTOvv7tzoXzQRiP8J13EFPGt3CJOzZCszOXakF+xR5szyd/aaVu6lRW6Fsa4pIW9G7mjxSkZN8oPL9VvqNm15qrIYQrMAk74aMpJxDMTxwQpBIDV1kGfLAG2JFgnslTCIheP6Q1z9K7axNzG9TZBEMzMqSMTXSIJYafHKzt/wbFidhFElTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+OXT/28lGnI0Sh3y80wx832Ca8GvVt+kK8raRC8Ii94=; b=lFF9QgSpgOLc0HYDQGtwVObzwoqh6HVZVmQPJ4yXNpraXwSsBR6AVKVLMANv6APJg+E9qhQuYB5DAlIsunYLwdEqtkyDN6N1XamWEvAf3IJRfSx0uHj/qlCgpoqNmbxWzfT8aQHvgLKKS6hMNT0v09wb+u0SMtneIioS9BP/+Fkq9AAZB+D94gLu7HPf2C4MsmjOJtvNQDAWpUGtIDHbTEjcHBOs2lu3F+defGBQgD+K8TxiydBfNrCVeymwIZ4BWXYsmf2pZgsxIgsUiiM8gJ3kfMdk/UYoOnIfzTkRzPfGdMl2+Z2Nv12kHnVckRZvqqV6fjY9GOH6up3/hphWgQ== Received: from BN9P220CA0007.NAMP220.PROD.OUTLOOK.COM (2603:10b6:408:13e::12) by BN8PR12MB2850.namprd12.prod.outlook.com (2603:10b6:408:95::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:18:00 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13e:cafe::e0) by BN9P220CA0007.outlook.office365.com (2603:10b6:408:13e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:18:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:00 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:17:57 +0000 From: Xueming Li To: Ferruh Yigit CC: Luca Boccassi , Kevin Traynor , dpdk stable Date: Sat, 12 Jun 2021 07:03:54 +0800 Message-ID: <20210611230433.8208-140-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d170b323-56aa-4303-d62d-08d92d2f27ba X-MS-TrafficTypeDiagnostic: BN8PR12MB2850: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yCGB3gjkbfJhcZdDqgogzAnS3ULMpYQMmhVysEg8kkMGnNWVxwlYrt1wuJ3quwj3AXoNy3molpl+6Cu6L0S1LgVn7kE6drniuAnaN3E+Ao24okyyRbrHm9aPg5hPj0QaQ+u79j6CkMBQqRw2PLxp4nZjJAePhgvkhneydtG1d8hPQKSGdJ3cJy1MS3vX3YuQXVCUGotFlz6BmZAhOAy0ImKPsTAain0nOUAHrPDZnmGg1MG9VpETsprkvM+q4ladyL/OYeccceFBMIh/8zSEiTtk1KN6RPI2o4mPbbATV5mu0w4v5DyF2RtQHK2wmCnJhE8W1S29dNOU10i2YMvr8G0oGZuNlOJxVoBWZbhhSgvBDWt9MnIEuf/8GNKp2m05qtgex1pryqMPdmvRJy7hEem84dpk7KCUitCEB5g64DR6WUUMeWJ9JQ9bmiZD2u7UVfS4OUl6LVlGXv33iAIyRMlLCioPyptCi2JWzZ5uUYfoX9Ce+D5siuCL8+WcmT8GAwxGQjphA7LtDweboqD7ZareE2mE/qAkolO/e9ccUwJFB0eD9sy/RqbfL5oECcQMQehLLGtlxnBlhBthIxr/BeEb3VmL7dJhgRBMMfdMTsxRW4pyhBHaGPy+2KPlrjs7gf+Of8yDvvDGW4pkv8+CcMdQ8lGVw00VpXH+BHpxmn2K1uBZ1C759ujbAHBII9jrPYAcFXYtR5mrrYcsDmJF9YAIofPF4Mf8kmYosBPoOZ9ju9r7r3nWCbXiLUo/3tu2C5FmyH0hbsW5lBHw2DRs2C7dQBrw/sJNLa2Yv8NbWEEsPsxK+ArbHtEldEA7s2Nd X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(46966006)(36840700001)(4326008)(53546011)(86362001)(7696005)(83380400001)(8936002)(82310400003)(8676002)(966005)(2906002)(6916009)(26005)(7636003)(82740400003)(478600001)(5660300002)(54906003)(16526019)(36906005)(55016002)(6666004)(70586007)(426003)(47076005)(2616005)(1076003)(316002)(186003)(336012)(356005)(70206006)(36756003)(6286002)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:00.1145 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d170b323-56aa-4303-d62d-08d92d2f27ba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2850 Subject: [dpdk-stable] patch 'net/tap: fix build with GCC 11' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/071855618a655b8ade45f8545f0c5da2f63a75a3 Thanks. Xueming Li --- >From 071855618a655b8ade45f8545f0c5da2f63a75a3 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 11 May 2021 14:14:35 +0100 Subject: [PATCH] net/tap: fix build with GCC 11 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Luca Boccassi [ upstream commit a625ab89df114bb813a9c8bc3ee3a8f5735bd5fe ] Reproduced with '--buildtype=debugoptimized' config, compiler version: gcc (GCC) 12.0.0 20210509 (experimental) There are multiple build errors, like: In file included from ../drivers/net/tap/tap_flow.c:13: In function ‘rte_jhash_2hashes’, inlined from ‘rte_jhash’ at ../lib/hash/rte_jhash.h:284:2, inlined from ‘tap_flow_set_handle’ at ../drivers/net/tap/tap_flow.c:1306:12, inlined from ‘rss_enable’ at ../drivers/net/tap/tap_flow.c:1909:3, inlined from ‘priv_flow_process’ at ../drivers/net/tap/tap_flow.c:1228:11: ../lib/hash/rte_jhash.h:238:9: warning: ‘flow’ may be used uninitialized [-Wmaybe-uninitialized] 238 | __rte_jhash_2hashes(key, length, pc, pb, 1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/tap/tap_flow.c: In function ‘priv_flow_process’: ../lib/hash/rte_jhash.h:81:1: note: by argument 1 of type ‘const void *’ to ‘__rte_jhash_2hashes.constprop’ declared here 81 | __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, | ^~~~~~~~~~~~~~~~~~~ ../drivers/net/tap/tap_flow.c:1028:1: note: ‘flow’ declared here 1028 | priv_flow_process(struct pmd_internals *pmd, | ^~~~~~~~~~~~~~~~~ Fix strict aliasing rule by using union. Bugzilla ID: 690 Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions") Signed-off-by: Ferruh Yigit Acked-by: Kevin Traynor --- drivers/net/tap/tap_flow.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index 1538349e9c..2e471832b5 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1300,10 +1300,16 @@ tap_flow_validate(struct rte_eth_dev *dev, static void tap_flow_set_handle(struct rte_flow *flow) { + union { + struct rte_flow *flow; + const void *key; + } tmp; uint32_t handle = 0; + tmp.flow = flow; + if (sizeof(flow) > 4) - handle = rte_jhash(&flow, sizeof(flow), 1); + handle = rte_jhash(tmp.key, sizeof(flow), 1); else handle = (uintptr_t)flow; /* must be at least 1 to avoid letting the kernel choose one for us */ -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.154756000 +0800 +++ 0140-net-tap-fix-build-with-GCC-11.patch 2021-06-12 06:53:56.590000000 +0800 @@ -1 +1 @@ -From a625ab89df114bb813a9c8bc3ee3a8f5735bd5fe Mon Sep 17 00:00:00 2001 +From 071855618a655b8ade45f8545f0c5da2f63a75a3 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Luca Boccassi + +[ upstream commit a625ab89df114bb813a9c8bc3ee3a8f5735bd5fe ] @@ -38 +40,0 @@ -Cc: stable@dpdk.org @@ -47 +49 @@ -index 1ee6fb30ab..c4f60ce98e 100644 +index 1538349e9c..2e471832b5 100644