From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C048A0C3F for ; Sat, 12 Jun 2021 01:18:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46592406A2; Sat, 12 Jun 2021 01:18:25 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55]) by mails.dpdk.org (Postfix) with ESMTP id DB21F4003F for ; Sat, 12 Jun 2021 01:18:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhwDpKLzbxhs0Ji0wIDFkedu/R+8TqxEd2Z8qac6FToNwVoyEfP5TarGRC2yfmlKjcvtuGF0rTJAjmndr0FUFBViM9v5Fy3QVx0FsNyDEem1K4WyN+y+7D6yCu1dX+q4S9S0psm93dFhVZ0M8MpDTzPbPOdVNLQIa1mudb7tLiBF/04LiH02XsmzoJAa2Kz+EvwaZy/TEqEzIbqHxsQpO8cKPZhnFyJJuVnLcnA6z9M6g7mmKMgD02ttdhd8zM63ur0NKd7P56r5sn85222IcqzV0CT9LPjlxvB8vmXU4xvjXL/jFu+B2we4PtjlL5E3Ta8FwL5EAdctk3JBilI+GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zFdH9vhpOpCj4MkMBlv+Z6eINzqxBt3KNtOsf1SgDtA=; b=Lm9KhZ/kNhmOz85MJcXB+Ty8eBwKv7c2lm+rpMauH60Sp42w93+WvpUhZe0DhjZi5HielpemZ5jOSQfiJNs98KSeGti/eB065tX0wYIlAilVD4nJEPA/i0Gqkrio6LmSNDBm7buO5LsWiceTT1s8qUImNbXclortZB2Zj+aUgZZpdn30WOrkQ1BSL9CXL2hrGx+TUSWJZzdBHtmLRFBts9hshAMUhNbXULkik4MxfoPjNdt5lNP06KdWRILqbn1lEz6h+ebPvb0Idwt/7rL9JiT42gzWiuWr/QdipMtFF2qKYTiJdCeejBgMu0fd9hrcZpgtHeaY11HExxZF9UJOLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zFdH9vhpOpCj4MkMBlv+Z6eINzqxBt3KNtOsf1SgDtA=; b=uhYggoqxAbXNd6LUCD3q75PAlp57nIvDoHSHgl9ToBpLQpSE4TCJJuo610sop0eSkSUxIyDmledZtaz6/xOgt9G1AMFwHj8imUww5hOkF7FzCA8Akkg66fc6g7TYA7d7SYsf6pN2HvmrWO6bovib10JWHdqdf3vq6QBMalGF5mpFQxT4pFTvK+UAANv6eIHQnzN/QWYfmla90wymRqb6HO/M7FQ2zb7uBS8xeD/gi9Yhr/vCoi3er/5a1s+zOAmgr9n7mjzNK6jaoG3h2lreURkuvZKKzyFdnWFuWtvGRqnNDlCSjmLiyK+gW8QIVrgTEHWfmlipibSGnRq1/wWsgg== Received: from BN9PR03CA0929.namprd03.prod.outlook.com (2603:10b6:408:107::34) by MN2PR12MB2942.namprd12.prod.outlook.com (2603:10b6:208:108::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21; Fri, 11 Jun 2021 23:18:22 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:408:107::4) by BN9PR03CA0929.outlook.office365.com (2603:10b6:408:107::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:18:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:22 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:20 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Viacheslav Ovsiienko , dpdk stable Date: Sat, 12 Jun 2021 07:03:56 +0800 Message-ID: <20210611230433.8208-142-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40b083b6-c089-4b05-8003-08d92d2f34dc X-MS-TrafficTypeDiagnostic: MN2PR12MB2942: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KVv9q0z+kIzDbGwumttkG49xhzismYeCW7OUSVGwDVn0INK4jMOqCfPWQgkZPpqwMC5p+lvjCmoKN5zNdTWo1ix5GoC8+krbPA/Gta6icGAaNYIcgUHkGvKhOJQwwrVFnwnEYoMSlSSzwIEllsbuW8FFFd8OOREr1L3OCawbO5unA451Ez4XL/1IdiEONNtmjAxe9R4TjkwcUEgmrrF+2+KXlktxkzSnfYnUFtU/ZM2s4RXsbw7JyYwRE3jV4LsV49Wey/SJ1Bwl5poW0h9khDSmGA0SXhHU/v0AKBUqEspvxFuxwj0hp9XgayE5Y1Nhk8O8ZOSbjFn2oGR6ERCUuKMTg9q3VNnMsyLHOcIvYH2mtdjj6o4xu9cEowYzwMDuyQmbkl3hMYUf5foIuICATnOwSkW2Iw7D5u+1zLG/TmW7a1fN0PJNu+yL/hv7mFl3BSXomPNdO0ien6Z4SAvnOSj4bOlQxCCdRlMqXvuNSxEI4QcVWZ0k01PPeMdxpeS3UN62t7sb04KCiWkEpd0d7bxz8Rv6fUr9mJ9mfTIAl+0kpjgOHQkoyKO/EJmZlTiyFsmdyeISVD254E5a3UpjWPQEIDQY+iXQzb+GEpsZuBX32TpGERjDeQ4lddITd4dNFR0mkRzfIvKHqh4HJyfqKtSM2ywEeQsNqiQPZanbHZcyZ+GBoWQHEVx5WXL5SXqr/xS6X4GERao7oPls9Jyu+1+lC/9nVvGZZWCk8f2KNJwfGfqZfk8u1vX2V2YeuniOG6IX2LcqDLgXA9V7yBE6UDUAtBU1GF7DvnmPagvtjBzQfHTsq9e6gUH/oh57GO6R X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(36840700001)(966005)(82310400003)(7696005)(316002)(55016002)(8936002)(36756003)(6916009)(478600001)(82740400003)(1076003)(47076005)(8676002)(83380400001)(86362001)(5660300002)(54906003)(7636003)(336012)(426003)(2616005)(36906005)(70206006)(4326008)(26005)(356005)(6666004)(16526019)(186003)(36860700001)(70586007)(53546011)(2906002)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:22.1505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40b083b6-c089-4b05-8003-08d92d2f34dc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2942 Subject: [dpdk-stable] patch 'net/mlx5: fix secondary process initialization ordering' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/cb97d5942878f53de74075e704f62e6119d4795e Thanks. Xueming Li --- >From cb97d5942878f53de74075e704f62e6119d4795e Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Mon, 10 May 2021 20:06:03 +0800 Subject: [PATCH] net/mlx5: fix secondary process initialization ordering Cc: Luca Boccassi [ upstream commit 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 ] The memory barrier is used to ensure that the response is returned only after the Tx/Rx function is set, it should place after the Rx/Tx function is set. Fixes: 2aac5b5d119f ("net/mlx5: sync stop/start with secondary process") Signed-off-by: Chengwen Feng Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_mp_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/linux/mlx5_mp_os.c b/drivers/net/mlx5/linux/mlx5_mp_os.c index 95372e2084..8567e43471 100644 --- a/drivers/net/mlx5/linux/mlx5_mp_os.c +++ b/drivers/net/mlx5/linux/mlx5_mp_os.c @@ -130,7 +130,6 @@ struct rte_mp_msg mp_res; switch (param->type) { case MLX5_MP_REQ_START_RXTX: DRV_LOG(INFO, "port %u starting datapath", dev->data->port_id); - rte_mb(); dev->rx_pkt_burst = mlx5_select_rx_function(dev); dev->tx_pkt_burst = mlx5_select_tx_function(dev); ppriv = (struct mlx5_proc_priv *)dev->process_private; @@ -147,6 +146,7 @@ struct rte_mp_msg mp_res; return -rte_errno; } } + rte_mb(); mp_init_msg(&priv->mp_id, &mp_res, param->type); res->result = 0; ret = rte_mp_reply(&mp_res, peer); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.202393700 +0800 +++ 0142-net-mlx5-fix-secondary-process-initialization-orderi.patch 2021-06-12 06:53:56.590000000 +0800 @@ -1 +1 @@ -From 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 Mon Sep 17 00:00:00 2001 +From cb97d5942878f53de74075e704f62e6119d4795e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 69b44d6bce1c9990e522a08f693d5f9f2e2e5067 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index ca529b6007..3a4aa766f8 100644 +index 95372e2084..8567e43471 100644 @@ -23 +25 @@ -@@ -132,7 +132,6 @@ struct rte_mp_msg mp_res; +@@ -130,7 +130,6 @@ struct rte_mp_msg mp_res; @@ -31 +33 @@ -@@ -149,6 +148,7 @@ struct rte_mp_msg mp_res; +@@ -147,6 +146,7 @@ struct rte_mp_msg mp_res;