From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9EC2A0C3F for ; Sat, 12 Jun 2021 01:18:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B464340691; Sat, 12 Jun 2021 01:18:32 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2087.outbound.protection.outlook.com [40.107.212.87]) by mails.dpdk.org (Postfix) with ESMTP id 17D7E4003F for ; Sat, 12 Jun 2021 01:18:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tl15tjmYhnZLRB3gopC7ErUi5T84TZSvMPYhJ9Yw5++x1qThduIDtvKzBJUUwuvpB1+AdcJhT7xOp0OEwaMPzNVj6xvpB14ebcZAyu3TNQCocnbZGhHlzpJtY7YMcqm+F7qQu5t/wqH/hamQcjIUMecRgufrACMOJuXJU49qDGISq6lcZS49rJu8eYpX9gi/p2OihjeN8IsSFzQv+YxrYPfHfHyC/ER530+7okkUbQWEAJlNV1UcQ17fjxIS10zgCiyscv50g7gyo9I+mEzgBJLGmpRibO5IPZEXzNMBeA+GyJI2d3emb9shcJ6Tcyti3o9VXF8ahteQXVunHiyo5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X00rKpV7M8mxHrznXEKkYPSCMTL7t8Emnam5GDMH710=; b=fqWPooyEjaLEx6po4r/y80RtlbXb9RzUVtuqBCvh+/ypvhGCsVDWn4JPwFmaUZSSw3ywChEuucv1iSxSUpdHQzutOzS6OzjHtv+FXNuWE8/nXqSnaKdZMmswiSTnvGY0M2dSWKKi2U9v2tgFkTfOt2ul/831urGHS2RFm7I7eS/Kek30EJqdKZUZjq0sVIPcjO7C5kcgpJ4PIVe6TNytFnmkm9zmGtKK7xin2cCMYG+tIMHwNfCpsvYrBwLGwuZRNqSuDYKXVKEk9aUxEpKgquVVyLpl1+9w0TQtFljoVvXvaF9Nrha7gtkeAiADIiFDGN812itATFu3OmNNTINlbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X00rKpV7M8mxHrznXEKkYPSCMTL7t8Emnam5GDMH710=; b=H7Y62zVWXLsOeeZgGs3sJA4qq8MowCfCTNHRab9JsqC7XiLTFg1xSwF6Q9onO3TEvz7C+KOvDEwgJhoHB0cV54UcXRl4g44qDmU1r+fl4wABj/DOqPffUGgTCwYmdlgk9cQAvJ+gLGJAo/E0utOGtpsunlUZS3/E6uFsvA/8qxetKI6th5mmvlCOQ1UNGo0xFDejQFnAbNaJftiZ9eyuuxyeeCEQlivpgR4P8TihrfqHNDxphF5CSiO7/5Ms/xTozO5BnqLzdb8HryA+vLlvW3O+xamj4T18knc+VFowvVpN5oci0LPyu6JDWPPaO+p4cN7f8cqa8M1zD82c3XSRnQ== Received: from BN6PR17CA0004.namprd17.prod.outlook.com (2603:10b6:404:65::14) by BN6PR1201MB0258.namprd12.prod.outlook.com (2603:10b6:405:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.23; Fri, 11 Jun 2021 23:18:29 +0000 Received: from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:404:65:cafe::84) by BN6PR17CA0004.outlook.office365.com (2603:10b6:404:65::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:29 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:27 +0000 From: Xueming Li To: Adam Dybkowski CC: Luca Boccassi , Fan Zhang , dpdk stable Date: Sat, 12 Jun 2021 07:03:59 +0800 Message-ID: <20210611230433.8208-145-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 319ef23c-d097-4eff-9ac3-08d92d2f390f X-MS-TrafficTypeDiagnostic: BN6PR1201MB0258: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v4ZIuhDPnK/29jgfgYu6ofgJ5Z4Bttz8MIbvsplzBTq6+N2JaBoTBbboGqphDWRLrOuKZTKb0A8hT7IJytpXMBzNrApZ5K9nAPkUJI4iM8UnlYb586BmwxnMQ1uzlIT56mmz+UqEKHG+dso/7N2W4wSBlcO9evjow2g+rMqNUBC78VpXA3vXvjniufFGMAe/gtj/vPzI//NPtLCLOHm/hOLkxk/Ac4wMNBg8tz7fDUd/zhM7DPbFoDXQ5+aPSmqXReZzEo5Xj3WEm0zOPlxdAZoy3P6VGWNx4qNvmmtl1CFltMtDerawkbZ1jfskU0enyUPvYB/y/HaJtHllOdy7Ccng0YxZv7rM9K70yaE8iUDFfjjFQy9xwQ63DJ/GkWeEv0tDzfYun9l2L94YnyqRBXRYDmrbiW9MaFcoE0SmQwRkuH0Ei6FvB2BcyLWBfyAGcD2/BuoqB/I+ZB1Nne5VIwlKs+vUxqFw7waodN69m4xS4RB2irDRzXxaMZn2IRvuYtL2KtWiGEnmPZHRsodbE8KTyqaEn9FSTugPMVzw7Mvy9jv6oPDDvasa96zGfnq9HZ5ZkGsGsfceb/ndKdjGWO0gjUUKv5Spc4Dty0WDJ3JaIVeyAbmWCpstSE6cDdDxQjRzXQ3MylMT90WUw8x0WbC+2l1ePwl+Ckd2HZOnBs/gFln/+D8sjjGQBDXmz1beePokVx5oBgngygaW70GBESavnm+61X75PcE+BzPgqWgBWhxG8gHetWXzj5pXb7QeXjsqp7Efyn+cezQ3MINikf7NKSBdYxrDaAA8i4XCF51uNMmAWd8GbxaGZungTACp X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(36840700001)(46966006)(47076005)(356005)(6916009)(8676002)(7696005)(8936002)(36860700001)(86362001)(53546011)(55016002)(7636003)(82310400003)(6666004)(966005)(82740400003)(316002)(36906005)(83380400001)(478600001)(5660300002)(2616005)(2906002)(4326008)(70586007)(36756003)(6286002)(70206006)(16526019)(186003)(426003)(1076003)(336012)(54906003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:29.1823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 319ef23c-d097-4eff-9ac3-08d92d2f390f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0258 Subject: [dpdk-stable] patch 'crypto/qat: fix null authentication request' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/cfd635034c73b364ec063a9e646335cb76d2b721 Thanks. Xueming Li --- >From cfd635034c73b364ec063a9e646335cb76d2b721 Mon Sep 17 00:00:00 2001 From: Adam Dybkowski Date: Mon, 10 May 2021 11:20:11 +0100 Subject: [PATCH] crypto/qat: fix null authentication request Cc: Luca Boccassi [ upstream commit 5cce3bd6b2fc9e272a8defc7b8971a96232d4529 ] This patch fixes the NULL auth generation case where the request shouldn't contain the authentication result address. Allows to run ipsec_autotest with a QAT device. Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO") Signed-off-by: Adam Dybkowski Acked-by: Fan Zhang --- drivers/crypto/qat/qat_sym.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c index a6cd33be37..299605eb30 100644 --- a/drivers/crypto/qat/qat_sym.c +++ b/drivers/crypto/qat/qat_sym.c @@ -333,8 +333,10 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg, } min_ofs = auth_ofs; - auth_param->auth_res_addr = - op->sym->auth.digest.phys_addr; + if (ctx->qat_hash_alg != ICP_QAT_HW_AUTH_ALGO_NULL || + ctx->auth_op == ICP_QAT_HW_AUTH_VERIFY) + auth_param->auth_res_addr = + op->sym->auth.digest.phys_addr; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.271178100 +0800 +++ 0145-crypto-qat-fix-null-authentication-request.patch 2021-06-12 06:53:56.600000000 +0800 @@ -1 +1 @@ -From 5cce3bd6b2fc9e272a8defc7b8971a96232d4529 Mon Sep 17 00:00:00 2001 +From cfd635034c73b364ec063a9e646335cb76d2b721 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 5cce3bd6b2fc9e272a8defc7b8971a96232d4529 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index a1f5676c04..9415ec7d32 100644 +index a6cd33be37..299605eb30 100644 @@ -23 +25 @@ -@@ -399,8 +399,10 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg, +@@ -333,8 +333,10 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,