From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 348B8A0C3F for ; Sat, 12 Jun 2021 01:18:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D20940691; Sat, 12 Jun 2021 01:18:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by mails.dpdk.org (Postfix) with ESMTP id 9AC794003F for ; Sat, 12 Jun 2021 01:18:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UPvw49Tiq9apY50XADjgggH9VtBbQsVd2g8q4IMXOsGz6ObWMgTNvt5WLBmTXB5DoA9zJ+vu7/nBZKDuui5IrZwHpXLy6diBtS4e3GfsMZ3TFMDHvnuvwWZeKDdD0kmpmKUCIlQ5bQPHZHEnKQ7gOdoZ6jYyAcu91IjXoitQEuCMXoMv0BLWLHtR2Oo5G4ST8pPdWtvKvkopJb5nI27FO4LuKFVF3i4Z8aNpXFZ8YIQPre/NANEaJ9Xa7FQQZx9qQz12H7auSy6fZVtfJHB1btT/nSfH7GWMGZwd7iyDlH5c0be154M0hvqz5f+ZOmbrv3aO56vduWSojbbM6Je4Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx+nHGlbVTlRL1ZV+bzLKnUQRr7Yt1hSoMNOPxLHmjc=; b=GTtmI/AoHwyQU5DQl9Cd9AvsVfTxUuXx9ZquCgI7mvFJriUEfLJxzgofvPiC06pSV3Ad8eFbIX/Z3qR77TGDJmVJcvV2aJx5cfEDmjwHFLGUsTb9QuRw5enysMwc/bNet4gcEFvEvZBvMkznGwDXnK+2lXvYoDRj8JXnxaS+i56OXDmD4jy+cEiL23AUQSd4b5rtY2urjpi7/HxK500inqxOtCOqSNTIW1dXHcmKuJLSRRphzmO5uJ1jsdK29aAKn6iPDWc2S+iPhbmPdOO2VzSW+nCc9miuUWIVPdPgoJHHHd9UbVbuumpNXhpf99tNylR0mGDJp/iS+WHgpAy0Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zx+nHGlbVTlRL1ZV+bzLKnUQRr7Yt1hSoMNOPxLHmjc=; b=KYxSV4kR0MV4LrDfzt9shdJWVUQlUA4vzbcQfIv6SoiKHt9SHP/ZMZR9ya2aVX8arJ9w878H/HDibLv2MjveuNjnllj7BPlec9vzpmZJkvt4Edwm0iFEZaddtZB6r3aHYjKZzJGMWYy2Ey8k5sjaOrAEgsMV9w5c50A9xCTtj+XkU7/I3ujWcPYM5IAa1iEpyAG7dOoZMzwwQY5rSrdhYVJ6rUlZRnXFsMKr9J23wDnKM3NuZxzK86EzcfAE4MedLZa5iak66exS6FbinXwjaMGnnL49mbTejhn+O3PiboN3sa4QbrI1CBIX5UPnUm98iabupVgEhJMcaxOwhdj3BA== Received: from DS7PR03CA0100.namprd03.prod.outlook.com (2603:10b6:5:3b7::15) by CY4PR1201MB0039.namprd12.prod.outlook.com (2603:10b6:910:1e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.27; Fri, 11 Jun 2021 23:18:55 +0000 Received: from DM6NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::44) by DS7PR03CA0100.outlook.office365.com (2603:10b6:5:3b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:18:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT018.mail.protection.outlook.com (10.13.172.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:18:55 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:18:51 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Bernard Iremonger , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:04:02 +0800 Message-ID: <20210611230433.8208-148-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10949bf2-9d80-4d51-4d58-08d92d2f4880 X-MS-TrafficTypeDiagnostic: CY4PR1201MB0039: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7S4dmU5qNQBsVGMAnB2gD90FQ/pyfKxNiYKrtCOZcHAV+NoqddSDcGadXwPFMW2swmdmZIJNaCaxDb7t1tH6r9eZzaqEoBZKF2AOJAVJCTO4JXbarYIYndbNwVLUHXYKZkLRBYbu6LWJihFRhpJ9m6oTxSiuWvZe+TQ4duXQwg1gRaB9aUREVHlQKuV4qJ2BNCm6vc751MJA6GyhUisHu/aSvY9KRFJtD8AwtRumdpGssKBP3MBX0I+rPLWhdTFotP+k7pgr5TZnAcXJPvh0O3+zjK3CfSe1SAkWV01oq5kWHlTte91P0Badt7lmaEBVMaR+LijhKfpTizzxOL3szh2s0agkfrg9Ib67HbWEhSOjwvRfnBSZ4QvxXEWQ6Ii7qR6CJwkKM7qY5jud5jTVHH5qVFSar+m6KjCy3tX5W+mAVR1hmxH8aAAjJPd+HddqHKZ59lC/VMpy0wIpvRqNYXro0q90nWIXfeLxHsh6qYeDFUK/z5hEaGhOzjfe5sjH568vBfujJdSzt/MRSo9wWl7xA4b6LgxD7ay1VRrnymVgKlisL69a0EXLxtHb+XL9YZt3q1UrYLJnwW262aWefDWreKTJ4YryLRVSKOX2RY1cQ4Lv8mpAl3xxG6sFnx5e98W84FnSgOPNYWErNcqnaTpWGAQW6O8lADfU7xqr45jJEMbOU4LOTO2pfL2d22fcgnhs/upKdFBHti9rwJ6DuZHx9oEkfIs9pdbSAeK2Npc5btfSlS1ZI5XuGOrP5Pn3jhEPR24qZnjPA8NXlDOkqhEXmbEBu86D/Lyc7FBWjw0b/d1sZ1F5ob8HEuMPg6Ai X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(36840700001)(5660300002)(1076003)(7696005)(6666004)(4326008)(70586007)(70206006)(8936002)(2906002)(6286002)(2616005)(26005)(36906005)(426003)(6916009)(316002)(336012)(478600001)(8676002)(16526019)(7636003)(36860700001)(53546011)(82310400003)(83380400001)(54906003)(966005)(47076005)(356005)(82740400003)(86362001)(186003)(36756003)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:18:55.1737 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10949bf2-9d80-4d51-4d58-08d92d2f4880 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0039 Subject: [dpdk-stable] patch 'examples/flow_classify: fix NUMA check of port and core' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/110a22070f7301d8cd0c17b89dba4c72d2a08913 Thanks. Xueming Li --- >From 110a22070f7301d8cd0c17b89dba4c72d2a08913 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 29 Apr 2021 08:50:46 +0800 Subject: [PATCH] examples/flow_classify: fix NUMA check of port and core Cc: Luca Boccassi [ upstream commit 78a5545ef92b48553be4a244514a2514ca9b09b0 ] According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -a 0000:7d:00.1 -l 93 Here: 0000:7d:00.1 is on numa node 0. core 93 is on numa node 3. The two are not in same numa node, but no warning gives out in old codes when device is on node 0. This patch includes the node 0 in the check. Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") Signed-off-by: Min Hu (Connor) Tested-by: Bernard Iremonger Acked-by: Bernard Iremonger Reviewed-by: Ferruh Yigit --- examples/flow_classify/flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index 5c3e111cfa..94c1553648 100644 --- a/examples/flow_classify/flow_classify.c +++ b/examples/flow_classify/flow_classify.c @@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app) * for best performance. */ RTE_ETH_FOREACH_DEV(port) - if (rte_eth_dev_socket_id(port) > 0 && + if (rte_eth_dev_socket_id(port) >= 0 && rte_eth_dev_socket_id(port) != (int)rte_socket_id()) { printf("\n\n"); printf("WARNING: port %u is on remote NUMA node\n", -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.337936200 +0800 +++ 0148-examples-flow_classify-fix-NUMA-check-of-port-and-co.patch 2021-06-12 06:53:56.610000000 +0800 @@ -1 +1 @@ -From 78a5545ef92b48553be4a244514a2514ca9b09b0 Mon Sep 17 00:00:00 2001 +From 110a22070f7301d8cd0c17b89dba4c72d2a08913 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 78a5545ef92b48553be4a244514a2514ca9b09b0 ] @@ -21 +23,0 @@ -Cc: stable@dpdk.org