From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A39E9A0C3F for ; Sat, 12 Jun 2021 01:19:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D5734003F; Sat, 12 Jun 2021 01:19:22 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) by mails.dpdk.org (Postfix) with ESMTP id ABE0B4003F for ; Sat, 12 Jun 2021 01:19:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LUI0Yu+R9sAOqZITeQTlQ3MEFoVyE9cHjiQOI1q0lyQGetb0moT8DriTUXqt8Rg95oCkcIVMbJpepb8JQdz3gAdM1LqFXwueZ06gvIKlZZcViNhzEOjGjZsXZs+AYVTFpTAgb2tHyoCr2EA2pVgC5bcAf9MyWdafruhj7YunWxJc1koSyr+xQIiBX8tu0MkXPX4o6fwI1+D2SWjrWkRkdBimPUbeLuE0NrQeFvA1GC0ZXJW9eVMTPuigC6Q471NxsX84Oj0CspQDMHc8powMWYGs4BvSiUzuphmZJzl+iXNGwfQzBZjh5ILGoVEqnfKO79G/qMm/S/4mx0tXJevN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A4gptvSAOGTxE4AQ+jpTebpSuBTo7uB887Imzw8tGsw=; b=INvuxWtuFCmbivs+LMGmxaxJGfAoYZYWpff7ec7m7j7jjs02I9BMVqDx2P2zOROrvxMDFXyShpS7QF4gxyGK0O8dt3T2HJsnlnBKMhCCQwE2K/I+qipMq4feRhce+0P/ptzP4HVHRaHa2HPgEOgZwmrWthMV6gMGpR5Gg1ngfmW212XwOG5DOeU7f5cqp8DyQIe2X6i4S0AC+EOvp4xPlnmUPxAKsSJFoY8lPluzuQZ8sMxcGKNxRyoJSAOK9jvx141PlFuvjV312UuOfuw9u+BgDbnVaHIi+kNzFJN9S5Q14Zl4WlyALt0XEeaD7hmLqZhRaHh/OCas2g3+yTjX8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A4gptvSAOGTxE4AQ+jpTebpSuBTo7uB887Imzw8tGsw=; b=hFvc2rTnatjegRmT4Iy21ezfpRUph4+YxPccJDOiAn8Tw7H+r7Z4m3zUXYoWN/BgR645fndPHQudi/GfZiZKtV0aCP4cDa1o1f7QgU66jZKO1tJ3GkOF5XMMEjURfMxIHY332dnWs4ssB4OoOO8NgvJbXDXGImlTcw2d0qnCTDnrwAmajMjvrrofPy18H4ReiWgBj1j+01jD9v55cBnCVxb+Jf7I5y6RsHB9RrVCcvqunh2AoGh22dn6eVjF2OXOi2RAVxdBeUjCA19Ne1cfaFB+gwnqVA/9T9EW9jdA1GvTo+DupkXpG6HtzCvQXjpyV1PjsJS8OWbZ5gi6KGIXKA== Received: from DM5PR12CA0016.namprd12.prod.outlook.com (2603:10b6:4:1::26) by DM4PR12MB5341.namprd12.prod.outlook.com (2603:10b6:5:39e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:19:19 +0000 Received: from DM6NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:4:1:cafe::59) by DM5PR12CA0016.outlook.office365.com (2603:10b6:4:1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:19:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT045.mail.protection.outlook.com (10.13.173.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:19:19 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:19:17 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Bernard Iremonger , dpdk stable Date: Sat, 12 Jun 2021 07:04:05 +0800 Message-ID: <20210611230433.8208-151-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45d24f44-b071-4291-dbf5-08d92d2f56e7 X-MS-TrafficTypeDiagnostic: DM4PR12MB5341: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iU4oHsaegVdJovYq2cVbE0Rh0blL72IKiqDcFHrz+/vim2pzeIqmaR0x1n4YRDbubowxqljeELguyFfPRCIy5zmFCWdXdbti7151NLIpZz14LHf0ibBCyw5ivc7F93/7CedhfyQxWn6ySupJ6A2rPuKHTzPfb7D82AXszdIWRsL5rtvrI52ei3URtCbx1gaKEd9NeV93XiVNWIAvYlOUNLH1k3Cc10BI18/qGZDIF6tHv2RsJabIpGScCeaz8CoZGbf4Hfa3fsEpSLUBKs6IZS8bABZOfy5Fro6zWQYp4sYIXlrFvZ46UQAk73FxhkJXaHTH9OvaO0APS9yJK8T7maN2jZnYPXMK9m1lCjK+2xfpgIqDD/XdSDGnZuxrPJjAH2hso349KWejb4LO1PS+vhpy50BNdeaG3XYirkhXLXHZ7oDsH9NLKJxz11WTb04ntuwMw3tRhXTpvxNwjFTLiuPfcYWQxt78cXcw0oqLgPvCSKPfneITxt0DeCNJg5R0Vs6vp1PnONNokWUm110Jec51+k74Zz/Ge13v/Nkc7gZqmlGVl9u+ukb5M8eztcARL5pKczU0NGNF3R+2fb8r34wd5s6nZYHi1Ff8fyCWuzJdiRSLuYulA23Wk3Oo/PXSmpiPRsGSFbWPItSAP4SLnsAAO4LmHj1W1gPJsivuSLDaOOph4fKfaroNvBcL6+azk4+vlCqOBkcVDqOQ2UUnrOSMFt7CkVdoMTWFTEzaBDCiZK/F0UFtnxTRNvsq1PA9EYTUX9P6WFhULiAszsqGGD1Rimi+LVMhb80SUUC60UY+JCDzRew+q1//ntmS7x5D X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966006)(36840700001)(70206006)(82310400003)(86362001)(478600001)(82740400003)(5660300002)(8676002)(70586007)(1076003)(426003)(2906002)(336012)(2616005)(55016002)(316002)(356005)(36906005)(47076005)(7636003)(54906003)(53546011)(36756003)(966005)(6666004)(6916009)(8936002)(186003)(26005)(36860700001)(16526019)(7696005)(4326008)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:19:19.3235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45d24f44-b071-4291-dbf5-08d92d2f56e7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5341 Subject: [dpdk-stable] patch 'test: check flow classifier creation' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/9a1044da2579119ae9b163f964185352f57e235a Thanks. Xueming Li --- >From 9a1044da2579119ae9b163f964185352f57e235a Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 14:13:54 +0800 Subject: [PATCH] test: check flow classifier creation Cc: Luca Boccassi [ upstream commit 705b04af1c100c464b6d9238408e84cfeffc489c ] 'cls->cls' will be NULL if flow classifier create has failed, then segmentation fault will occur if the variable is used. This patch fixed it. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Signed-off-by: Min Hu (Connor) Acked-by: Bernard Iremonger --- app/test/test_flow_classify.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c index ef0b6fdd5c..951606f248 100644 --- a/app/test/test_flow_classify.c +++ b/app/test/test_flow_classify.c @@ -828,6 +828,12 @@ test_flow_classify(void) cls_params.name = "flow_classifier"; cls_params.socket_id = 0; cls->cls = rte_flow_classifier_create(&cls_params); + if (cls->cls == NULL) { + printf("Line %i: flow classifier create has failed!\n", + __LINE__); + rte_free(cls); + return TEST_FAILED; + } /* initialise ACL table params */ table_acl_params.n_rule_fields = RTE_DIM(ipv4_defs); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.402493700 +0800 +++ 0151-test-check-flow-classifier-creation.patch 2021-06-12 06:53:56.610000000 +0800 @@ -1 +1 @@ -From 705b04af1c100c464b6d9238408e84cfeffc489c Mon Sep 17 00:00:00 2001 +From 9a1044da2579119ae9b163f964185352f57e235a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 705b04af1c100c464b6d9238408e84cfeffc489c ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org