From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9AE2A0C3F for ; Sat, 12 Jun 2021 01:19:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E34F54003F; Sat, 12 Jun 2021 01:19:25 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2050.outbound.protection.outlook.com [40.107.220.50]) by mails.dpdk.org (Postfix) with ESMTP id 75D1E4003F for ; Sat, 12 Jun 2021 01:19:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alKcIJVXcJunxR99lgID+/v3gHWZPmU6dAzcB2619J8iO5i+gLXYxA+BjmOoM/35Utqq1x69uxE801F2Vdr9uSEDIT8Ko7phXlGJsr6sKkX/QQ5WL8S8jCiQboaK7zkSEfKE5SmfDDGRC4sCaGxKsjmGOJLSVIT37FmtpGnP2sEm7Zw90XHYc64lpuIRJiNBwnEgXYpo69R7PMUXp93X1ibv7a2zDnfX7ZBkj1PMyTP+Y5gP3N/eDzRMEH5/h+l31awfl16nhqIgm+Oy+gPHbof/TyEoC1jXqHXxhYjuz077IRZJ6aIvckBSmf53e3096/rQZtyJ+ziIY3ecupBKig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ha31ibseSbKKQ3TZGwliLSrPhSL3gKchf1knm9Wq3Z4=; b=SljuPTL1JktU1jm3G6OmSp4ktFvd6xXzAnnJvC+tYdG03eRpEJT8SB+TEFYysAYcdt/mY7EjPj+r8cR3rS/+gPQkgGZEq/8XA5EFNeCpw8GPchv7mNJWzI+rOfEFMs8BRoldtYGjvyUERRi6ajiC7BSls0C8oDBU8JGCRkE/3iusAaB0PXBE95BMJvzQAJNxX6YQbBNlaqgdX73Pxk9fGUUsuRkSg7pVJ+P3k3hr8c7QsFjouWsPibOrciHHJoCSkEJZhTwj2OlzAJfExj+hY65C62nt06sE6xAdj31Oe+V592p/rMz19Dwp8KM/knhNDWslwpRXcL+OhF23ktcLdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ha31ibseSbKKQ3TZGwliLSrPhSL3gKchf1knm9Wq3Z4=; b=NvvZh6ChWOqltgUR7d18+j5tXUJasEdIHGatdXI1g2ur8j/6GbIcOPDk19d9MNPGofSn9uQxWThQ2fIow4gkgYZbvjr4eEGXn+Wa/dnpNotd5/yIPyJntYs8sBPpaJ3g45+EHuMamRgr4/bU3nJN/eWjFAen0VuraHoIah58sPPOgGUVwfhvSfgDve3+Whh2ceimSD5ZkGAvyk/Q8NH0pM13/+ZN0NOZ8rvKddtj0/10XWzKKAJT4RBrIE5ZS0Z/Kz1+7uXMo+JVwdiRdc46DHzH6IZaYuzLsbAP4lKaLZXXDwXpONKBH6ykXWXiOTnAJTv+l75NJZEXPR5H6sUN1Q== Received: from DM6PR12CA0016.namprd12.prod.outlook.com (2603:10b6:5:1c0::29) by BYAPR12MB3301.namprd12.prod.outlook.com (2603:10b6:a03:130::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:19:22 +0000 Received: from DM6NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1c0:cafe::c5) by DM6PR12CA0016.outlook.office365.com (2603:10b6:5:1c0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:19:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT011.mail.protection.outlook.com (10.13.172.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:19:22 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:19:20 +0000 From: Xueming Li To: David Hunt CC: Luca Boccassi , dpdk stable Date: Sat, 12 Jun 2021 07:04:07 +0800 Message-ID: <20210611230433.8208-153-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ac7f1339-a0d2-4492-5625-08d92d2f58cb X-MS-TrafficTypeDiagnostic: BYAPR12MB3301: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LJWTd9RxLVeez7DrsD302OkIPHBVsmnJTHHZbsUORXxycwIV9+ECU9rxjPbd7nkb+2JadqfJRqrCEKpypkX18QxTfUv7tGaM3mwQII8bHFJE5AZO9qgmMVV6uzIIyMwDGJIou62lZoQKDe78wgtqkZT17n3c+HJqQkp4D8zmIlLURH7DLUF1eTuMckrdKtwiqnVdqRIwNkipmY1Sz+ULOjYVh49SAx+W9kPO6Jyk3Avzikd3iYj+NJKtobX5pVt7VjVlvHw22zA1T6cgTJ5qnTETuwTKhzS+n2z4TKtoXlSOjdAeH5146hdyLvO1XfPxB7pacZbxBsXtLQigxLn3xS7t+NUI5p4IMdox+wWELsehG7qJLDDr7iWspNmi2QS3SfgjqdHrM0JHeefrrDkL2UKpRW1/4fckiXjSZUu1BpUABq+0zVeCHmDnSTeDR1RAdCn7mFqxEOtay4ppT4MDyN/+PeGBrk1VIQj6ur3pcHTufxGIRAP9SgUe5xWxRI4HcXFovIK1s4ONU8W9ljV9RcVcHHbUZY69CiF8vFzxN4vvvdEN7T89OBa9bhZzFccs5N98WF333QXm0MBzxjIOg90LYoemCAccN+5s/XcxgNz41yj88tXJkqOyOwDji6VbSgl9KuPLkBnjoKMtqfgHyT5F7HMgOhbsl7SbYef24jUC9yLx7CmlpBJCa2Ke1F6GRnGLOrLphm81MhZavqIfujjvY2ptks0Jq411eQoAXKxMcM2WT+3Fr5rJCkRUAAtuuIL0ZiUggnCIwHo31aQCCNEL3DYGcOWnyY8G4m1habaFysnFMJ1nSi/eZfsrXqbF X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(46966006)(36840700001)(7696005)(5660300002)(86362001)(47076005)(55016002)(1076003)(316002)(36906005)(6916009)(70586007)(82310400003)(6286002)(36756003)(36860700001)(83380400001)(336012)(2906002)(2616005)(4326008)(966005)(26005)(426003)(16526019)(478600001)(186003)(8936002)(356005)(54906003)(82740400003)(8676002)(53546011)(7636003)(6666004)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:19:22.4710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac7f1339-a0d2-4492-5625-08d92d2f58cb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3301 Subject: [dpdk-stable] patch 'test/power: add turbo mode to frequency check' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/c5a5a60d9e18d949f42c9dd8411453a585b7bba3 Thanks. Xueming Li --- >From c5a5a60d9e18d949f42c9dd8411453a585b7bba3 Mon Sep 17 00:00:00 2001 From: David Hunt Date: Wed, 12 May 2021 17:32:52 +0100 Subject: [PATCH] test/power: add turbo mode to frequency check Cc: Luca Boccassi [ upstream commit 6db92b3b9bb130acf0bc9d774ab2d75ea67d00df ] With the intel_pstate driver and turbo enabled, the top frequency in the frequency array is the P1+1, i.e. 2300001, whereas the frequency shown in scaling_cur_freq could be a lot higher. This patch adds a flag to the check_cur_freq function so that we can specify if a frequency is greater than expected (turbo mode), in which case the check should be successful. Fixes: aeaeaf5f2d62 ("test/power: add cases for turbo feature") Signed-off-by: David Hunt --- app/test/test_power_cpufreq.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c index 52f58ef8b2..2b4728d2e1 100644 --- a/app/test/test_power_cpufreq.c +++ b/app/test/test_power_cpufreq.c @@ -48,7 +48,7 @@ static uint32_t total_freq_num; static uint32_t freqs[TEST_POWER_FREQS_NUM_MAX]; static int -check_cur_freq(unsigned lcore_id, uint32_t idx) +check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo) { #define TEST_POWER_CONVERT_TO_DECIMAL 10 #define MAX_LOOP 100 @@ -90,7 +90,10 @@ check_cur_freq(unsigned lcore_id, uint32_t idx) / TEST_ROUND_FREQ_TO_N_100000; freq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000; - ret = (freqs[idx] == freq_conv ? 0 : -1); + if (turbo) + ret = (freqs[idx] <= freq_conv ? 0 : -1); + else + ret = (freqs[idx] == freq_conv ? 0 : -1); if (ret == 0) break; @@ -183,7 +186,7 @@ check_power_get_freq(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, count); + ret = check_cur_freq(TEST_POWER_LCORE_ID, count, false); if (ret < 0) return -1; @@ -233,7 +236,7 @@ check_power_set_freq(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1); + ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, false); if (ret < 0) return -1; @@ -269,7 +272,7 @@ check_power_freq_down(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1); + ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, false); if (ret < 0) return -1; @@ -288,7 +291,7 @@ check_power_freq_down(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, 1); + ret = check_cur_freq(TEST_POWER_LCORE_ID, 1, false); if (ret < 0) return -1; @@ -324,7 +327,7 @@ check_power_freq_up(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 2); + ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 2, false); if (ret < 0) return -1; @@ -343,7 +346,7 @@ check_power_freq_up(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, 0); + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0, true); if (ret < 0) return -1; @@ -371,7 +374,7 @@ check_power_freq_max(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, 0); + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0, true); if (ret < 0) return -1; @@ -399,7 +402,7 @@ check_power_freq_min(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1); + ret = check_cur_freq(TEST_POWER_LCORE_ID, total_freq_num - 1, false); if (ret < 0) return -1; @@ -433,7 +436,7 @@ check_power_turbo(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, 0); + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0, true); if (ret < 0) return -1; @@ -452,7 +455,7 @@ check_power_turbo(void) } /* Check the current frequency */ - ret = check_cur_freq(TEST_POWER_LCORE_ID, 1); + ret = check_cur_freq(TEST_POWER_LCORE_ID, 1, false); if (ret < 0) return -1; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:00.447182800 +0800 +++ 0153-test-power-add-turbo-mode-to-frequency-check.patch 2021-06-12 06:53:56.610000000 +0800 @@ -1 +1 @@ -From 6db92b3b9bb130acf0bc9d774ab2d75ea67d00df Mon Sep 17 00:00:00 2001 +From c5a5a60d9e18d949f42c9dd8411453a585b7bba3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 6db92b3b9bb130acf0bc9d774ab2d75ea67d00df ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org