From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id CFCE7A0C3F
for <public@inbox.dpdk.org>; Sat, 12 Jun 2021 01:19:52 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C64F44003F;
Sat, 12 Jun 2021 01:19:52 +0200 (CEST)
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
(mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50])
by mails.dpdk.org (Postfix) with ESMTP id 9F59D410F7
for <stable@dpdk.org>; Sat, 12 Jun 2021 01:19:51 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=K3ez5T/xnJ720XVqv2GmRbM94/PlvoUeyCstcflmyHDu2jm6xNXziG34/W35SxqIODYXnrqFs87zUDoFDGgio5P0fYwm47/QIXh6Sf19jjuC66nCg23Q+L42Go6wA0gyzrrKcZVaSJ83MjnGio/SxKb5rfJMWMjXVI02oqFbm6JwsNLDcGoZRksERjuRhvY4j1XEWYNAr8aKK5PYsdXMv7FK4IQmTH1Pq7cMTtVO7uoxa+2VChHBSpxZgpwWV0i9PwB9hpnzRTkJWy4iwvam7QQpHao6uEkQLyoQUtjN51hOPhfvhb71zEAQ6FUoSOstuZa/7nkOzNUqbQeGebMGKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=uIz/HL+fRjxZwxXzm6RPfFxa4PSjcn+H79z/hHL31JY=;
b=DHZ3BgGpZXhZyhe6CsBwhFA1uMeiIyMEIUVrmjzeqhXgnf8jue1lJ6PQhRsTPoX6z67KW3R26ctRvLdjqlZ14FdWb1JeuzU9e35kxa24EhYqf1YnjtLJ69JEVTD9Svx8pgrQwgkcKn9qrfNO4/a5/ul5VMAQ5bo53Xa5rgV173W6WanzbQ/nqAC10kD4YYzSKNw4lWWNxlnmVBEv+8DDZ+IwCyteyct/yT/E0hmLSVZF16xmISEbsHLJlQh4oj9Wab6Rc2CmcoXgrjjo7NTbFbvoDI3ZfezRuOhMQbVnDUnHfz/DB3iZVir9cPuuMo4aBvx1ydpkkLQt3slhLa+e8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;
dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=uIz/HL+fRjxZwxXzm6RPfFxa4PSjcn+H79z/hHL31JY=;
b=Cbvjl5RConOXU6k513M9Nmk/DV3f0MOBapd1CayHWWSLRRfrGHFU2xtJu9TKNskjj9QJj7qV/sJ4/iZKL4jrhRhgyvmpPewWWkwPT59/mjDth1Mh/EqEzJFS4Iljrftjvf5vvDVOwyRaR3aOBZDChijqJEYBQnGYcG7jlmQ9fUykovZ5E8IzWSGzGUcU2sgW14ajgbNSvss11+ByHVb7ozhwGJl6tFPdKkaWvDp9G0htq/9AN9Fy3ONunAPWPPgpCWTgldRm49hqByqK6p6L1o7lFG0mNyV65d+Li3RpdmE6D79Go6h1g/uooXiLDbFRtG42U/U6m0ornylkpf/Npw==
Received: from DM5PR19CA0003.namprd19.prod.outlook.com (2603:10b6:3:151::13)
by BY5PR12MB4323.namprd12.prod.outlook.com (2603:10b6:a03:211::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun
2021 23:19:50 +0000
Received: from DM6NAM11FT014.eop-nam11.prod.protection.outlook.com
(2603:10b6:3:151:cafe::4c) by DM5PR19CA0003.outlook.office365.com
(2603:10b6:3:151::13) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend
Transport; Fri, 11 Jun 2021 23:19:49 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34)
smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.34 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.34; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.34) by
DM6NAM11FT014.mail.protection.outlook.com (10.13.173.132) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:19:49 +0000
Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com
(172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun
2021 23:19:47 +0000
From: Xueming Li <xuemingl@nvidia.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
CC: Luca Boccassi <bluca@debian.org>, Bruce Richardson
<bruce.richardson@intel.com>, dpdk stable <stable@dpdk.org>
Date: Sat, 12 Jun 2021 07:04:12 +0800
Message-ID: <20210611230433.8208-158-xuemingl@nvidia.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com>
References: <20210510160258.30982-229-xuemingl@nvidia.com>
<20210611230433.8208-1-xuemingl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [172.20.187.6]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
HQMAIL107.nvidia.com (172.20.187.13)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 08999399-2d1f-4374-8f5a-08d92d2f68f8
X-MS-TrafficTypeDiagnostic: BY5PR12MB4323:
X-Microsoft-Antispam-PRVS: <BY5PR12MB432346021DC0CCEDDC7EAFCEA1349@BY5PR12MB4323.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pmeTTteWJeodx65nSMmYeXv0ETWJOza6hkHN4lwUY/5nBfQXqaxKK4pV8Nda+4oKhlc9n1GrQWm0xJijV7leNd/2lc46WDCB5N9vf2+9jFFdZZnvqwzTXzAf+DoCMIdi7AH52inYk3Rbt0m6+PmYz4dn1RBGlLrz2qzomFq4t330dF9789jFYGS2QdhnctVezE/oKXOs92M1xD2owEnQex/T8xAxRPxNnprwcqVPApjsaqmHHGN6iIeY87eLpS6KXZCqGBqg075vhHDth1v20S0wHVcgdeDAKbFA5Ho1aL/flFmcdRglOsErFssX/nlYnzl5HjhB141twI+ERktycd4knpPI6Zzu7IDJFKY1ykXml5R3tLY75sBneCgLUKghka0IbZgrkQJsgyZD76BRPkhPO02Pv/3HexsP2aGQbF+G9FJBRAcPfmwn8DLprLz9xfYje5Qp/Yewy46hiTvfAlTYGU6UFYdldktOlS6JOHPBoK2NsHs4RBiPRnt8bivR6/d6a0/pFManyNIoxZodQCSGYy519ttbUfjziHDrceou5rYeS68ElJKaDrwNikNNyLLvMZ687UvMeZee1O2gLfi5YZ53FYyS/kNS3t83FRKrMYOwkNCgKRm/bT6VqbGQK2mBBoJ7Tymfg4TyLa3eHLKdYGxq+RzjDec/gL4lYBl2ipuVlH2klcV82mR3vmAKDZhlgblFn8rxvWf0eeEQRzyMuEWxTKRX1C6Fp+pU0g9qahbLm+OyZMen/620PwfkmjSQXP4QWUO+s1/N9lH8Ft2KftZ5gfT5jMK6OkC3Ub9sIsCkEd3Qmim7rdMPqi12
X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;
SFS:(4636009)(136003)(396003)(346002)(376002)(39860400002)(46966006)(36840700001)(36756003)(82310400003)(8936002)(36860700001)(70586007)(7696005)(6916009)(2906002)(8676002)(83380400001)(356005)(82740400003)(7636003)(55016002)(53546011)(478600001)(966005)(70206006)(47076005)(426003)(54906003)(316002)(36906005)(2616005)(336012)(6286002)(4326008)(186003)(1076003)(16526019)(26005)(6666004)(86362001)(5660300002);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:19:49.6269 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 08999399-2d1f-4374-8f5a-08d92d2f68f8
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT014.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4323
Subject: [dpdk-stable] patch 'test: fix division by zero' has been queued to
stable release 20.11.2
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 20.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/934abbb8b8cd9156856c98daac1105558a3f4501
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
>From 934abbb8b8cd9156856c98daac1105558a3f4501 Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29@huawei.com>
Date: Thu, 13 May 2021 09:10:37 +0800
Subject: [PATCH] test: fix division by zero
Cc: Luca Boccassi <bluca@debian.org>
[ upstream commit 07b3c7d8e3b6513044d8f5cc45359cc42c14eb18 ]
Variable i is used as a denominator which may be zero, and
this may result in segmentation fault.
This patch fixed it.
Fixes: 948bc3d6d095 ("test: add reciprocal based division")
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_reciprocal_division_perf.c | 41 ++++++++++++++----------
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/app/test/test_reciprocal_division_perf.c b/app/test/test_reciprocal_division_perf.c
index a7be8aa71a..4f625873e5 100644
--- a/app/test/test_reciprocal_division_perf.c
+++ b/app/test/test_reciprocal_division_perf.c
@@ -71,10 +71,12 @@ test_reciprocal_division_perf(void)
tot_cyc_n);
printf("Total number of cycles reciprocal division : %"PRIu64"\n",
tot_cyc_r);
- printf("Cycles per division(normal) : %3.2f\n",
- ((double)tot_cyc_n)/i);
- printf("Cycles per division(reciprocal) : %3.2f\n\n",
- ((double)tot_cyc_r)/i);
+ if (i != 0) {
+ printf("Cycles per division(normal) : %3.2f\n",
+ ((double)tot_cyc_n)/i);
+ printf("Cycles per division(reciprocal) : %3.2f\n\n",
+ ((double)tot_cyc_r)/i);
+ }
tot_cyc_n = 0;
tot_cyc_r = 0;
@@ -111,11 +113,12 @@ test_reciprocal_division_perf(void)
tot_cyc_n);
printf("Total number of cycles reciprocal division : %"PRIu64"\n",
tot_cyc_r);
- printf("Cycles per division(normal) : %3.2f\n",
- ((double)tot_cyc_n)/i);
- printf("Cycles per division(reciprocal) : %3.2f\n\n",
- ((double)tot_cyc_r)/i);
-
+ if (i != 0) {
+ printf("Cycles per division(normal) : %3.2f\n",
+ ((double)tot_cyc_n)/i);
+ printf("Cycles per division(reciprocal) : %3.2f\n\n",
+ ((double)tot_cyc_r)/i);
+ }
tot_cyc_n = 0;
tot_cyc_r = 0;
@@ -152,10 +155,12 @@ test_reciprocal_division_perf(void)
tot_cyc_n);
printf("Total number of cycles reciprocal division : %"PRIu64"\n",
tot_cyc_r);
- printf("Cycles per division(normal) : %3.2f\n",
- ((double)tot_cyc_n)/i);
- printf("Cycles per division(reciprocal) : %3.2f\n\n",
- ((double)tot_cyc_r)/i);
+ if (i != 0) {
+ printf("Cycles per division(normal) : %3.2f\n",
+ ((double)tot_cyc_n)/i);
+ printf("Cycles per division(reciprocal) : %3.2f\n\n",
+ ((double)tot_cyc_r)/i);
+ }
tot_cyc_n = 0;
tot_cyc_r = 0;
@@ -190,10 +195,12 @@ test_reciprocal_division_perf(void)
tot_cyc_n);
printf("Total number of cycles reciprocal division : %"PRIu64"\n",
tot_cyc_r);
- printf("Cycles per division(normal) : %3.2f\n",
- ((double)tot_cyc_n)/i);
- printf("Cycles per division(reciprocal) : %3.2f\n",
- ((double)tot_cyc_r)/i);
+ if (i != 0) {
+ printf("Cycles per division(normal) : %3.2f\n",
+ ((double)tot_cyc_n)/i);
+ printf("Cycles per division(reciprocal) : %3.2f\n",
+ ((double)tot_cyc_r)/i);
+ }
return result;
}
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-06-12 06:54:00.557539800 +0800
+++ 0158-test-fix-division-by-zero.patch 2021-06-12 06:53:56.620000000 +0800
@@ -1 +1 @@
-From 07b3c7d8e3b6513044d8f5cc45359cc42c14eb18 Mon Sep 17 00:00:00 2001
+From 934abbb8b8cd9156856c98daac1105558a3f4501 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca@debian.org>
+
+[ upstream commit 07b3c7d8e3b6513044d8f5cc45359cc42c14eb18 ]
@@ -12 +14,0 @@
-Cc: stable@dpdk.org