From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 200F9A0C3F for ; Sat, 12 Jun 2021 01:21:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19A924003F; Sat, 12 Jun 2021 01:21:45 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2057.outbound.protection.outlook.com [40.107.236.57]) by mails.dpdk.org (Postfix) with ESMTP id 7F7664003F for ; Sat, 12 Jun 2021 01:21:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFIdbI8q2zFuiH1Lq0gvSfFvqGWlhvdfiEsJolz1TBQq5hkc7Qi2IlMhwyhS2ne3vFSsNKvmcJPo3lr6fnMRcoqELwAuB7TFrinZVAkWzoJxGmgdKuamCOyBR/k2IHMrGJP7pa0SR7LLbZ9IxFrrF1gwh8QCWPYYbRZ0RXCiBCxAf2tjXnN7IUmrDE4qmV+ydbKDfGDmjWdReg7jIAjtrJtsa18dDhOL1Dtel8ilFjSNcokBrkb3gEoQD4ALHVBHTBp278N4bHa4IYCG9uGFOA0llOCwPPcm3ZPML2MCfCt1odZ2nODsPb4qk0p8PW5hOSC9nIQv5PNVi3ge94TnRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQ92/x/bJWpB3eKQMyBcGTJUr9QA4QdHlyBSltc26eU=; b=HavIiugMzeWL2Jo9wrZWDlmIno055QhKPZIGJNr4qXw3TZDD+xSoNTzRg85796k5LsoiSC5xUsrX7R8QLYCNsHJqYAixRXpsJgGj/mLzkd6m6G1cMsnTU1ru4a4r8buidFR/ssbQ2eCqhlsqfqE0AklkLTioFV8k3VeFkCOuNLmUjgcLQGhC0J6MvmenLQRc8JSFgEGkdd/zCNe+xHogr3Vcdw+ddNQ1uZ5loplhFZe3sxBSdYc12IXB5sHGRDZ4tjvTUl/XaOBBsO00m74hqIkViWA85Aod3HUOpS2tHJIGiG8jxdqhfq4NN8/sww1bT5NjLsVqY6qLQVmrg8tRXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQ92/x/bJWpB3eKQMyBcGTJUr9QA4QdHlyBSltc26eU=; b=T1ZnAooP6RWaq2uqvHJXsj39mtVlddVdFcKDj2ikngRHJp4zHYFENnfsF8V8rOLLlnezGlY5YkFzPxcjXDgni442Gg/Ksw60V9Qo8MjBgH/wiQ0xzmCfd3ZMioNo+BLw5/IigHmPP7J0i4OCUrt2jlLdAYNe8BmRa3TE4hPSC25pbjsl9BaFRSo+JrHbI9zcRlH8QyMCugUYliw8o3VsSmYAVH56pRMw80KzEvBZk4wtxIPJkWaYbXgBT3vk/sVjMQ//paAzbieYb/3wgS6cseFCetxWN+AOhqxLsdddFEh2AuQESJARg1+iwXwmi5gpv8PjdtORsRU5tc9JUfVMRA== Received: from DS7PR03CA0032.namprd03.prod.outlook.com (2603:10b6:5:3b5::7) by SA0PR12MB4543.namprd12.prod.outlook.com (2603:10b6:806:9d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.25; Fri, 11 Jun 2021 23:21:42 +0000 Received: from DM6NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b5:cafe::f9) by DS7PR03CA0032.outlook.office365.com (2603:10b6:5:3b5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:21:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT033.mail.protection.outlook.com (10.13.172.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:21:41 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:21:40 +0000 From: Xueming Li To: Timothy McDaniel CC: Luca Boccassi , dpdk stable Date: Sat, 12 Jun 2021 07:04:32 +0800 Message-ID: <20210611230433.8208-178-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a872e5c1-ad95-4a21-31be-08d92d2fabfa X-MS-TrafficTypeDiagnostic: SA0PR12MB4543: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y5cTunBHcXqxxDesbojTsMiLRHDOmyb+kJ7Xq/NBY0tHnm8XdBzSAKUxa+XrJLOgzjhp8oGn/TZhsVbzSWzubiMPku/BqqCMlyINBq5wPHwBLZG+8tCuk4huuQPQUvQEoTxHfzTe8MuEQykZPoXvdGr8BxGbDgZTyiXnDWupZvmCjRcqghIBXCIrYpsAZJ4d99TY76tDaACJuuU4koWucJbGCtw7+m8t5HNWpFGZbt1B19+7Y2H6Te1aJsoz5THJzq1qAlXe5o4ebXbn0s5q1MCUydHsA400P2aBPZOAAGH9ajC/lATLItwFCt6CQ3enhRwnApszx+Gid2ZZWuZTzzutattq9oMK/ejE0exeNkiiO7GjVviMLlginjl0kfycZZDf7LGzJ2xl4smU9pA71nXWZO0vAK4S1avCzIgz3PbRhvYixlAyL0Q1d9MWz9VElpNtO3WHz9EHgEGL3RT/qEmu02+x2XixlbWkMLS46IoAFo8oSfnX+295xL7qIQoapHAQCOHo0G+QHmR9bvzRIJGHTZPMi35uxgow5OOtpfw7HYH4HqdkWJQmCKnE7mfL6T6SAiWYroh3N5LM3X2E2ij8ogwTvx1GJNhqe2KG/q2C5Wnm8SzmM7/cDVUOrlX2CHvIXUrHtpM0PKLD2TqXuM3tmCg70AMBTbcmSsCvVftEl18PGhiW83LZhiMbXu+enkVa1MmLe9GQrm1q1l+5kp124aGbqsbLawtfcmB4uA72kJ0pulH6+M26wRnMsOUs3h4wIaTX9/3cCgpsnQpm/bHzO9MW1z9QNY5OUbDtxwpBtS3p0dxS7kliYGDqrkMb X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(36840700001)(46966006)(55016002)(83380400001)(36906005)(8936002)(54906003)(26005)(6666004)(5660300002)(7696005)(36860700001)(6916009)(82740400003)(2906002)(16526019)(478600001)(186003)(8676002)(6286002)(47076005)(426003)(4326008)(966005)(336012)(356005)(1076003)(82310400003)(2616005)(7636003)(316002)(53546011)(86362001)(70206006)(70586007)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:21:41.9790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a872e5c1-ad95-4a21-31be-08d92d2fabfa X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4543 Subject: [dpdk-stable] patch 'event/dlb2: remove references to deferred scheduling' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/8ba82ed84d54592b07a202ab5c945866b17cdc64 Thanks. Xueming Li --- >From 8ba82ed84d54592b07a202ab5c945866b17cdc64 Mon Sep 17 00:00:00 2001 From: Timothy McDaniel Date: Fri, 21 May 2021 11:11:34 +0200 Subject: [PATCH] event/dlb2: remove references to deferred scheduling Cc: Luca Boccassi [ upstream commit 0e94408f0028f888c638810973a7f2ddbfdbb795 ] Deferred scheduling is a DLB v1.0 feature, and is not valid for DLB v2.0 or v2.5. Fixes: bc62748bd7d4 ("event/dlb2: add private data structures and constants") Fixes: a2e4f1f5e79f ("event/dlb2: add dequeue and its burst variants") Signed-off-by: Timothy McDaniel --- doc/guides/eventdevs/dlb2.rst | 21 --------------------- drivers/event/dlb2/dlb2_priv.h | 3 --- 2 files changed, 24 deletions(-) diff --git a/doc/guides/eventdevs/dlb2.rst b/doc/guides/eventdevs/dlb2.rst index 94d2c77ff4..6ba67f278c 100644 --- a/doc/guides/eventdevs/dlb2.rst +++ b/doc/guides/eventdevs/dlb2.rst @@ -314,27 +314,6 @@ The PMD does not support the following configuration sequences: This sequence is not supported because the event device must be reconfigured before its ports or queues can be. -Deferred Scheduling -~~~~~~~~~~~~~~~~~~~ - -The DLB2 PMD's default behavior for managing a CQ is to "pop" the CQ once per -dequeued event before returning from rte_event_dequeue_burst(). This frees the -corresponding entries in the CQ, which enables the DLB2 to schedule more events -to it. - -To support applications seeking finer-grained scheduling control -- for example -deferring scheduling to get the best possible priority scheduling and -load-balancing -- the PMD supports a deferred scheduling mode. In this mode, -the CQ entry is not popped until the *subsequent* rte_event_dequeue_burst() -call. This mode only applies to load-balanced event ports with dequeue depth of -1. - -To enable deferred scheduling, use the defer_sched vdev argument like so: - - .. code-block:: console - - --vdev=dlb1_event,defer_sched=on - Atomic Inflights Allocation ~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index b73cf3ff14..8a01938785 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -27,7 +27,6 @@ #define DLB2_MAX_NUM_EVENTS "max_num_events" #define DLB2_NUM_DIR_CREDITS "num_dir_credits" #define DEV_ID_ARG "dev_id" -#define DLB2_DEFER_SCHED_ARG "defer_sched" #define DLB2_QID_DEPTH_THRESH_ARG "qid_depth_thresh" #define DLB2_COS_ARG "cos" @@ -498,7 +497,6 @@ struct dlb2_eventdev { uint16_t num_dir_ports; /* total num of dir ports requested */ bool umwait_allowed; bool global_dequeue_wait; /* Not using per dequeue wait if true */ - bool defer_sched; enum dlb2_cq_poll_modes poll_mode; uint8_t revision; bool configured; @@ -523,7 +521,6 @@ struct dlb2_devargs { int max_num_events; int num_dir_credits_override; int dev_id; - int defer_sched; struct dlb2_qid_depth_thresholds qid_depth_thresholds; enum dlb2_cos cos_id; }; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:54:01.041480000 +0800 +++ 0178-event-dlb2-remove-references-to-deferred-scheduling.patch 2021-06-12 06:53:56.710000000 +0800 @@ -1 +1 @@ -From 0e94408f0028f888c638810973a7f2ddbfdbb795 Mon Sep 17 00:00:00 2001 +From 8ba82ed84d54592b07a202ab5c945866b17cdc64 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 0e94408f0028f888c638810973a7f2ddbfdbb795 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 31de6bc470..c60c454d6b 100644 +index 94d2c77ff4..6ba67f278c 100644 @@ -23 +25 @@ -@@ -293,27 +293,6 @@ The PMD does not support the following configuration sequences: +@@ -314,27 +314,6 @@ The PMD does not support the following configuration sequences: @@ -30 +32 @@ --The DLB PMD's default behavior for managing a CQ is to "pop" the CQ once per +-The DLB2 PMD's default behavior for managing a CQ is to "pop" the CQ once per @@ -32 +34 @@ --corresponding entries in the CQ, which enables the DLB to schedule more events +-corresponding entries in the CQ, which enables the DLB2 to schedule more events @@ -46 +48 @@ -- --vdev=dlb2_event,defer_sched=on +- --vdev=dlb1_event,defer_sched=on @@ -52 +54 @@ -index 3140764a59..b1225af37e 100644 +index b73cf3ff14..8a01938785 100644 @@ -55 +57 @@ -@@ -32,7 +32,6 @@ +@@ -27,7 +27,6 @@ @@ -62,2 +64,2 @@ - #define DLB2_POLL_INTERVAL_ARG "poll_interval" -@@ -585,7 +584,6 @@ struct dlb2_eventdev { + +@@ -498,7 +497,6 @@ struct dlb2_eventdev { @@ -69,3 +71,3 @@ - int poll_interval; - int sw_credit_quanta; -@@ -620,7 +618,6 @@ struct dlb2_devargs { + uint8_t revision; + bool configured; +@@ -523,7 +521,6 @@ struct dlb2_devargs { @@ -78 +80 @@ - int poll_interval; + };