From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4E20A0C3F for ; Sat, 12 Jun 2021 01:06:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F91C4003F; Sat, 12 Jun 2021 01:06:34 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2067.outbound.protection.outlook.com [40.107.92.67]) by mails.dpdk.org (Postfix) with ESMTP id 8336640E46 for ; Sat, 12 Jun 2021 01:06:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7+JfBBkU+tnxlOjjeRhGrzBIhQXEbCnbEd1Rn4WbfBakscYYJ1s0aHsk5HLUKv3jzIE+raFXddepu0pLSUdjw/5I7NQWQkdsFhbip8r5C62dKIQbZm5HgzvUABFsxRLt3pWdZs1AXjw9oVRRxsdoisOoIycimhTbCpuZLdsznTwE+RADOLO15dlU++4mVkj1LsFbgD09srvXtgDNJPAjNV9si8N2QildSF4n+V0SDCm/FBcDxSSMFPdW+s0V04C5Kio4XeWioYbiK0dbqSi+RslmgjhKqsDyQBEupWyBIW7wxP2hCAFnC4DXvBtGj5OYT8gfnCa6VpM9gvO+trz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QV7TiQ06DRFZzQPAZIo8AlubxeFJsPeY1YqO4IwuFTw=; b=Kk4mTpiyG8dgfiYaq07E6+j7Qrm/+poetiLa7vkWpLsR+socg2Nu3IBo/jz3BTM2Y23dEmZAHf787Rk02S2VOs6EhoCdTLZsnLqWUVKpCWWaIUOpHz8RTA+aHEKwcoJVUWRqf0JpVSrip9DtCpudVNkBAM8E9PpB136N0bohJ9r17W49/8yP3VvgNjwcJkq6QTjzN/vf36KMXLRLS2TShQgYyJZUey7vIOk2cZI7+zNxGXGmBaYSJ7VvYI6AvUwwRVQ6aj6zJDci0dxKtfG5KRyg1o3xjpDMPJnjeoYLPP9zM7EroVOEd+DlBqJxSP/PqYjFXDewK14hLBQ219wo7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QV7TiQ06DRFZzQPAZIo8AlubxeFJsPeY1YqO4IwuFTw=; b=XZX3U55WpKtmU6GpH7nC9LSCIcvbp77MBJRSVFHgpE2WO33FE6Zch8RRKaVl4gWT9eqm+5i63VFvhVEI16vK8TmML4KeYJRv5fLOOT2Vx1AYk1BHj7qelVqIZu+UPmVdQVYl83OldJeNR+B7kWIYvcDyE1CpBxLwg+g5BuHKOVs8ecw/6aH82y+3CqfN5TpG1MjLPhFKrB8oyAFsgDzcWNLl6hV8QRkDl1VkrioCOT9nx0nV+l/NVEEWscQgihaTE3kGRCaO0LMQZRSvkN9TRWAPZ3F6NPkcLcgn+cgaijZtjffiTFxcTSJdWJ+dGfpLWGuSCZbuypCR9ddzTkiwpw== Received: from MWHPR20CA0031.namprd20.prod.outlook.com (2603:10b6:300:ed::17) by DM5PR12MB1948.namprd12.prod.outlook.com (2603:10b6:3:10d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:06:32 +0000 Received: from CO1NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:300:ed:cafe::6f) by MWHPR20CA0031.outlook.office365.com (2603:10b6:300:ed::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:06:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT018.mail.protection.outlook.com (10.13.175.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:06:31 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:06:30 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Min Hu , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:01:53 +0800 Message-ID: <20210611230433.8208-19-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dc45b52-3979-49dd-09ee-08d92d2d8d7c X-MS-TrafficTypeDiagnostic: DM5PR12MB1948: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E1f6ees3gvuNWuyUxLUWMFEuQfbSVosODxZfIRo3ULmn0OARHSQjtbQ9WOzXDIpyqQib91dsVGLL36EEo+YUDi32Gb8IDXOSgijfZoFFI2IlnAblXj4OeR4LAq7mQ5oPNBG6+xpF3fZ7qIIHvQsrJNFOdmqVa1o8jh7C/+TsIB5c0a/8WJkqtvK4tD4NvGhKyocCadodD5flyg67Aj23BO4kdNqycn/jMCKEPg01WP/w1gk88A3azfRaoiXm3hG3uHzuQm7LmaW1Scp7PIBkborGiM+WxDHhGD0xlP3f6UHYnWwXN3vSriEomtwUfgmwjRC9Jvmabjx1KXFqepM0sXRasWHQ0zr6WxL0l3XeF1FPJETgS3g7AL6YAKwyiZFGixRT5xrrxQmWvrx2kprwfiL/MwdZclBM76E99XPPWR/JqCwzdiDXI3gqfuRO3uURRLViI9zwWTOu6XIZ4szR7D4w1LAU+ASV31LhQFQPreHuhK3bzBFh3TchhUYMB+asKql9Eo9MMd9zeH2VNyvmXrYopAGe/SDDmjlvaJJJVpwVaw6EDgfabW+2dMEOSBr9kuZIx4GI2R8BDtKurdXFldvTzW2KiOOFMN/muZSLA+eKg1gRYx5I63zKgjU9jYXgJX4DNT2cuQOxF8yI3v7WD3QGLOhmqbLNcAo7RHoSCrxHBG7xhlxcP9vwTMwpRX4hTmkyRlaAmzaBatA0ae1+UQxX7q9t50pTjJAZgJfjE5cUncdQe5ioXhaX7/pb8ifFJ+m39rD/vndl6YSSdbImQ0GqDy8PnqRXA2A+L6z0n4oSCbzExg6vOkIUWDr0g9Ll X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(36840700001)(46966006)(26005)(6286002)(7696005)(83380400001)(36756003)(316002)(2616005)(36860700001)(1076003)(47076005)(186003)(4326008)(53546011)(86362001)(16526019)(70586007)(8936002)(8676002)(55016002)(54906003)(5660300002)(2906002)(82740400003)(6666004)(7636003)(478600001)(966005)(6916009)(336012)(426003)(356005)(70206006)(36906005)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:06:31.9041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dc45b52-3979-49dd-09ee-08d92d2d8d7c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1948 Subject: [dpdk-stable] patch 'net/bonding: fix leak on remove' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/448c880b6e95911ded654811d755db122b4f1c96 Thanks. Xueming Li --- >From 448c880b6e95911ded654811d755db122b4f1c96 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 22 Apr 2021 10:05:02 +0800 Subject: [PATCH] net/bonding: fix leak on remove Cc: Luca Boccassi [ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ] If the bond device was created by vdev mode, the kvlist was not free when the bond device removed. Fixes: 8d30fe7fa737 ("bonding: support port hotplug") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 057b1ada54..9bcef952ea 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3459,6 +3459,8 @@ bond_remove(struct rte_vdev_device *dev) ret = bond_ethdev_stop(eth_dev); bond_ethdev_close(eth_dev); } + if (internals->kvlist != NULL) + rte_kvargs_free(internals->kvlist); rte_eth_dev_release_port(eth_dev); return ret; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.191938900 +0800 +++ 0019-net-bonding-fix-leak-on-remove.patch 2021-06-12 06:53:56.100000000 +0800 @@ -1 +1 @@ -From 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb Mon Sep 17 00:00:00 2001 +From 448c880b6e95911ded654811d755db122b4f1c96 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 2e9cea5b8e..25b1f771a1 100644 +index 057b1ada54..9bcef952ea 100644 @@ -23 +25 @@ -@@ -3467,6 +3467,8 @@ bond_remove(struct rte_vdev_device *dev) +@@ -3459,6 +3459,8 @@ bond_remove(struct rte_vdev_device *dev)