From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A57C8A0C3F for ; Sat, 12 Jun 2021 01:05:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 742C440E46; Sat, 12 Jun 2021 01:05:10 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2046.outbound.protection.outlook.com [40.107.101.46]) by mails.dpdk.org (Postfix) with ESMTP id 0E9AD406A2 for ; Sat, 12 Jun 2021 01:05:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4YHrezgSvt26scnH/0xAlGWS0I/MQtD4AKP5y6bfrpReMVolNwlsVlP7MysXf6vrEOrjx2sCC/7eY0s893zK7kib95OuVw90bES+KEw2rqap2dnTb/sJ0Pzbyq5RjqILV97YCmf2APoY0MkWO7pQpF1QLoW8ps0ibDakWlbOgJwl2M8oDSA4KdUAqEVl4APGL1IZaRh8oeDp9kfblOXRE6fmK01i3W0Ig7vUhz7QDjVAX2ScKg0SzcFxIZ9V63+hpdu6BMX1w1PilUoRmZRC+f1wEupbZVfDnQsooXR2pkR9W7dpReYYG5mI+dcoX1dTTlDW2+Ok282XKXfmPnZ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y0r1cJ5A9zz13VVVi70VobLlBtABxI5T00etJOYITgc=; b=ilmtebL5URSRY+PQkiBxALX6ygG426JTNSDcqpgI7rccaiKN+duNFxhsbNLy8XI30NrrLFO9QsekEMQ6nXTGC3cpeV9xc3J10zqEA1c4QmjZ0UXlk+Rc+XPG39E7knGNd+CbqrC+KMkxUCGN6ZtcYedvldYGdoaatN1LIqCPDRRn25pXj/Zb+hgRqyx1m34foM+aoHLAgeBvAsmSfvVprhBN+3BYRRy/fttsUhHA13AyjdppQ3PpWFBtyOrSIBnVP5TSv4yPQGEewZBcSdTfWPKBKTyxg0zKg7QBUCLlfA9qH7xKd0nDn5ZuTnpoNTFOwTVEoFSYzAJeiufE0RL8XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y0r1cJ5A9zz13VVVi70VobLlBtABxI5T00etJOYITgc=; b=Y3qJmmsQAaqo0LaZnzFk5aE/VKMn2Dtb4y+1Pd01dtH+m51yyFgJ3J0njY32WGTJn9ZR3D71DurXhkrvmelPfAQv8eOcnFQLQcdalkW9LfM0QT7uptcmactegpI7Hu8FroWKugkGv8HzD5IXk9TL2B3FkbPSzPdEuFa04EQIBkKxU8smI77HQ5MsDir4hUxljSYht3UNDvOof47nEdFaPUrl349/GANA17UoOczZCJ/IT6EyLva8V2bl7qsWzT2I2K9L1z5B48S04XgXV6Gtqn6/AJaT37xv5VwJPgUYFzNrs9Uos7MaJwIXcAJbhw575GGCBp6JQmXQXWhxqjP5BQ== Received: from MW4PR03CA0342.namprd03.prod.outlook.com (2603:10b6:303:dc::17) by BYAPR12MB2838.namprd12.prod.outlook.com (2603:10b6:a03:6f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:05:07 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::1a) by MW4PR03CA0342.outlook.office365.com (2603:10b6:303:dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:05:07 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:05:05 +0000 From: Xueming Li To: Bruce Richardson CC: Luca Boccassi , dpdk stable Date: Sat, 12 Jun 2021 07:01:37 +0800 Message-ID: <20210611230433.8208-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1467ad35-fa31-4b3f-970b-08d92d2d5b05 X-MS-TrafficTypeDiagnostic: BYAPR12MB2838: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9yLNimbwJOMcw+Y3gEY2wIrAhGa2YJZgy6/BSNZ6eFY6TtwUZyrhnAvQHKF3rCWS89/dN3YHwRZG96QX3u5o4Fwd53hW1e/ihkGj/1+VcvxiHsia/B80sSEzYkcEKjDCHc9aoJokO8Wo06EyQ5uW00E/jSJORyOOuJrod7iUkzyy0mFUlzSgUxAtv0IdI7ZzVIunJr7X8cGeDxDeS7gtFNmZDE/71SBOhCrsYdqErWhS7trEXd6V+Bo+E2u+0tX7RLhAng8taQNFlqn47We67rC5A43JmctQTeeEUgsOGxNVJ3BI7y3LjIBaQCp1Ns+HpiyHrISUj/U6GLSOcUaBEcvid454YbIP/Js4txy5tLN5ffNFuwVLKkVOmrxb+/De2rp7kUactiApZWntUqv5tzulLwuoj7qlZSqosg5oqmXdf5Q3FBRiMVNebjsdXlZHiIn7soRRh8iFsMpcGLBmxDlMF20kXuBJzeq6oyRyrfBQ9dbxbBmuZmkNMh6eP2gGVBZQjwvebvfFbq5Q3b68ufxjYQejJ2oaTHVWXbF7bW+iVaNJs3IoMbG3RTznHzSHeVEkU+QabEy5pAYj6q2TISUzx8lzUiR+9RMvFFg2lM0JLaRsASj3eVvQfDUvtCYxsAObNaEvn6R66eUA3FBQMF+Gtsa/obXu/oV/dxBLt5lGPskLu4ygUsinZtzFiP7MjweLg1twTEcLySiikfLvrD5icdh63WyhMQw7GNRFr/fu/K593wuxxHTB6m2s6wR0j/VfZV5D73fGvvVTT+u2v15QadVQgVILrxljv4tLKKcI0UmDiPa0+xfIWopIl0mx X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966006)(36840700001)(82740400003)(7636003)(83380400001)(8936002)(316002)(6286002)(4326008)(16526019)(36906005)(6666004)(1076003)(8676002)(356005)(86362001)(36860700001)(55016002)(36756003)(54906003)(5660300002)(478600001)(26005)(966005)(6916009)(70206006)(70586007)(2906002)(186003)(82310400003)(336012)(426003)(53546011)(2616005)(7696005)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:05:07.2367 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1467ad35-fa31-4b3f-970b-08d92d2d5b05 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2838 Subject: [dpdk-stable] patch 'raw/ioat: fix script for configuring small number of queues' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/35ad25c5b12c43e64ec2a0382963530e7379fda8 Thanks. Xueming Li --- >From 35ad25c5b12c43e64ec2a0382963530e7379fda8 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 4 May 2021 14:14:51 +0100 Subject: [PATCH] raw/ioat: fix script for configuring small number of queues Cc: Luca Boccassi [ upstream commit cfb286ab2b487b6e40f958a096fbe8cd13aa055d ] The dpdk_idxd_cfg.py script included with the driver for convenience did not work properly where the number of queues to be configured was less than the number of groups or engines. This was because there would be configured groups/engines not assigned to queues. Fix this by limiting the engine and group counts to be no bigger than the number of queues. Fixes: 01863b9d2354 ("raw/ioat: include example configuration script") Signed-off-by: Bruce Richardson --- drivers/raw/ioat/dpdk_idxd_cfg.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/raw/ioat/dpdk_idxd_cfg.py b/drivers/raw/ioat/dpdk_idxd_cfg.py index bce4bb5bd4..56e44063e4 100755 --- a/drivers/raw/ioat/dpdk_idxd_cfg.py +++ b/drivers/raw/ioat/dpdk_idxd_cfg.py @@ -39,15 +39,15 @@ def configure_dsa(dsa_id, queues): max_queues = dsa_dir.read_int("max_work_queues") max_tokens = dsa_dir.read_int("max_tokens") - # we want one engine per group - nb_groups = min(max_engines, max_groups) - for grp in range(nb_groups): - dsa_dir.write_values({f"engine{dsa_id}.{grp}/group_id": grp}) - nb_queues = min(queues, max_queues) if queues > nb_queues: print(f"Setting number of queues to max supported value: {max_queues}") + # we want one engine per group, and no more engines than queues + nb_groups = min(max_engines, max_groups, nb_queues) + for grp in range(nb_groups): + dsa_dir.write_values({f"engine{dsa_id}.{grp}/group_id": grp}) + # configure each queue for q in range(nb_queues): wq_dir = SysfsDir(os.path.join(dsa_dir.path, f"wq{dsa_id}.{q}")) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:56.787495700 +0800 +++ 0003-raw-ioat-fix-script-for-configuring-small-number-of-.patch 2021-06-12 06:53:56.000000000 +0800 @@ -1 +1 @@ -From cfb286ab2b487b6e40f958a096fbe8cd13aa055d Mon Sep 17 00:00:00 2001 +From 35ad25c5b12c43e64ec2a0382963530e7379fda8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit cfb286ab2b487b6e40f958a096fbe8cd13aa055d ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org