From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C344A0C3F for ; Sat, 12 Jun 2021 01:08:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45FE04003F; Sat, 12 Jun 2021 01:08:24 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2040.outbound.protection.outlook.com [40.107.212.40]) by mails.dpdk.org (Postfix) with ESMTP id 9D3124003F for ; Sat, 12 Jun 2021 01:08:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGaOxI+FBxwxQBU9sDFAPJF+OwS56bIzkBhJsWg4RMiQ2vmIWSWpDIpquwCzfr6GRQ+uoX5dZdN8HydzG/UVYhqRylDgwHzxVmCnBAf9KjUdZm4l4G/fCejZqnJyWLirnSqwZ68qXtKCttDw7CPJZXYs55g4+RLmN+OStaFaZBZ0Q1yAFVtc5BupaH7ktQzpwYPkZk0vQZl04H8gAL2r+Gx/KiEkI2HIQfzL8nCg99+fb2bzPomYZFWli7ZYXzHcNPx2jLd6MPg5I/wWPQBMPSfyhmuk78nW1AZBh3fa5Lwesogk7og+mzPc7uS8UKfYeFmi3/cPV0LnrC5h2CYMwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzKmNMG8jwm29xEOFwTXxdracyNlvWr25wGH+7yFav0=; b=OB6WidynB2HUVR72ZNWXZtcVh9bDgyGShBjgujh/5SbAmUCmULkdep08rvLB1WWRup38KZeppQhKlGizfiy3IYTbehjcEcJVS3J9due5lRSW/2qiCjbHv02aFNyKM9JUuNfVKeXWwWf4fvJt9KafrNvJHMYKmIuKrtGs89lBkCa3lhuQq+53eUTpM1gnCF4xRB+cuJL/c2SijzmROSlt60NgYiUJakRa9UyQgu4vhG1ItvlCZRnv4jYmlt03Uw98KN/jDQdFXd1LBQBpKbyHD6flfPfQiCPxjg8mRegajyPLuzZAtEq6CvG+E0459G/kGJ6tr5x8x1KAPSh4Ut11Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzKmNMG8jwm29xEOFwTXxdracyNlvWr25wGH+7yFav0=; b=czPo/XLWzy7VOi9vr+QNK3nvd5DYa2nbJMFOhzoIC7EY1ciGNWSOXa4AzD/sKm5OyWDSZTJyoN+EntipQWhdao4RSibeRRrUmy+xnZG9F4qaGMEwv0HuD6ar5Ms9yrKAmTErNv8T/AFvJZB8Fq0oddslNPl9VcS7HDmcXAvokqyrx+rowb4FAXBu4b/Sf84JoVtqsQhAY5JPk3W5K41DsCjZnpar+np1MHnqpaqjPD1pFM6J3REXRpwTJz4EScM8bqB/MtP67R8CTFWrEMC6mp6mkbE0F3gpKwojc5KRPUtrqqH8LPUOZWg1mkIEGFUu/tap2569aOXsTuFanVeDaw== Received: from MW4PR03CA0142.namprd03.prod.outlook.com (2603:10b6:303:8c::27) by MN2PR12MB4343.namprd12.prod.outlook.com (2603:10b6:208:26f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:08:21 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8c:cafe::5a) by MW4PR03CA0142.outlook.office365.com (2603:10b6:303:8c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:08:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:08:20 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:08:19 +0000 From: Xueming Li To: Jiayu Hu CC: Luca Boccassi , Maxime Coquelin , Yinan Wang , dpdk stable Date: Sat, 12 Jun 2021 07:02:10 +0800 Message-ID: <20210611230433.8208-36-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43364567-01e4-4820-b49a-08d92d2dce68 X-MS-TrafficTypeDiagnostic: MN2PR12MB4343: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UbMtlmmYzA4g8HKgjKmQlLpHzGIUnH6yReYDr16cPuErOmeKk8kHHF95kfx+LhCpMVq4Ynl0kmVjo1EScfcoBFWgWcJvlBj9qioyy0V1SrwaP3A/ykR0WFfz8gQEuNozUTaXuecmKJzLtRWCKNwohxzMArlqstB5Fg2caCG2e25oJDaucKtVZd2CY3fZRU7VfX3bp9eBwU0n9x10MoxgUNkhfC6DG3OwHaKMYxsiAU8PPUSL2UBK53t+jCWGk9iqo+/SSrqy9l0xKzO8HmAsxbPi1s3WGNZCMikFYHeXCmPkmzxWMTXvo6bzx9sHlNHwvPWA/5jZ59vdvZSjXkSkwiUoFPMWrNEkZ4V7Tg4KmM7NjNqPRf+BjvnAX7VHCJ1q5Tvw5mBX1txJIh6+zy+VV4YpaywG01i2y85FKadM6el5UY8bN91a6Z4AFHTago+xdR+6xvmThSgmd5eECTWI8WwSmnfEdB6Pff+et4NULUOJRy6H5u/sVMLnSV3FbgVRbS1E5lSCGKhjxzS46X76cQcgSFo5qYh64nNwFl2d4iit//Cm1/8t3SogTSfKwprs6aaqEdMBdGUJYuc35HjBA8RuzpgaLzHoKzlK0Yj5wOwYM54umTpBHT81oyB6Ly6gGgpEizRjVWhZLRnVbLZoah8xPvwNdBjv3cMJEI1yh1CLuvhu4exla7/aH1quKhHpCpibXnd/WGvQryLAvsiPiDUNaCAr09eCzkr6iYjtRuVOfPjf9OrWqZ8EOsENXo3StMKGZuZbHzGH+ip3COVn+Ucw1MrTdw0A8zOW/LZSit1nI7chzUkqIcEFPZGmsYCH X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(36840700001)(55016002)(966005)(70586007)(8676002)(426003)(1076003)(6666004)(26005)(7636003)(36906005)(336012)(86362001)(82310400003)(4326008)(2906002)(316002)(53546011)(70206006)(478600001)(5660300002)(36860700001)(82740400003)(36756003)(16526019)(83380400001)(8936002)(6916009)(54906003)(2616005)(356005)(6286002)(7696005)(186003)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:08:20.8373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43364567-01e4-4820-b49a-08d92d2dce68 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4343 Subject: [dpdk-stable] patch 'vhost: fix queue initialization' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/b0a7aab7d885cb771cf6520e405c495c7ab0c18c Thanks. Xueming Li --- >From b0a7aab7d885cb771cf6520e405c495c7ab0c18c Mon Sep 17 00:00:00 2001 From: Jiayu Hu Date: Tue, 20 Apr 2021 04:57:43 -0400 Subject: [PATCH] vhost: fix queue initialization Cc: Luca Boccassi [ upstream commit 678a91efa23a50a16cd3c5a2b18a117daef3c840 ] This patch allocates vhost queue by rte_zmalloc() to avoid undefined values. Fixes: a277c7159876 ("vhost: refactor code structure") Signed-off-by: Jiayu Hu Reviewed-by: Maxime Coquelin Tested-by: Yinan Wang --- lib/librte_vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 4de588d752..90cad7fffd 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -598,7 +598,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) if (dev->virtqueue[i]) continue; - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0); + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0); if (vq == NULL) { VHOST_LOG_CONFIG(ERR, "Failed to allocate memory for vring:%u.\n", i); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.609535600 +0800 +++ 0036-vhost-fix-queue-initialization.patch 2021-06-12 06:53:56.180000000 +0800 @@ -1 +1 @@ -From 678a91efa23a50a16cd3c5a2b18a117daef3c840 Mon Sep 17 00:00:00 2001 +From b0a7aab7d885cb771cf6520e405c495c7ab0c18c Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 678a91efa23a50a16cd3c5a2b18a117daef3c840 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - lib/vhost/vhost.c | 2 +- + lib/librte_vhost/vhost.c | 2 +- @@ -19,5 +21,5 @@ -diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c -index a70fe01d8f..ea38cf2b75 100644 ---- a/lib/vhost/vhost.c -+++ b/lib/vhost/vhost.c -@@ -608,7 +608,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) +diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c +index 4de588d752..90cad7fffd 100644 +--- a/lib/librte_vhost/vhost.c ++++ b/lib/librte_vhost/vhost.c +@@ -598,7 +598,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx)