From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 727A3A0C3F for ; Sat, 12 Jun 2021 01:08:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C87B4003F; Sat, 12 Jun 2021 01:08:26 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id 7E3DD40691 for ; Sat, 12 Jun 2021 01:08:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CpPbAtOMapvWjeGb5KfFGPyiOfqizlGiihTdh0BjWUr/AxRBGBLDFOA9klEvZwNKKzpOpLg+EUi+QXB2jMXiny/KyBA7dY1PNrw35L73zvsqcrnOpaXftBAsT9vo9lloc746fn28D2ciUUcHnrLGNYilLB5gaLFVPjTPNOOeaTiKQnvmi/TrCwqGtcb2jvSqmXSWEAyYlRxAIuxGLAiaJfBMEIv9H+Vi8sDciRtGlKp+T/zRvgmcf11WPRuDXwylv1uq/UCf+JnZi0R+MG9oF4krawaMZYwbUdqjQ5d80U1I0Awckw3Pa+vMkPW98+pnX7tIdOYlSY9an5XAfPf6lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svV+1L/iHwqfnExcnI9JmUOgBdn78plKEJUbq7Na1LY=; b=cZJepXDTF5u7Jt/quf9dS605rgULU9QtgYE1bzCeaUHTx5FUL7nYZKrQ3XXoi5pPuNxB2job87+qnjTqf/B1ixri/jQxJivqpkK/9MHVqA1+iLcSl2/zJ1BQwKAbG8k4hISDNJZ4tmQshH62OaooO0p5BY5xEFSM8reaCABJGnin3x0HGy7RGp2ito0EKjM8ZMLUr8jyXXZ4lQDAPoz5nCLkzRqqy7jegpIC8arW8jLU48VYFIJi78vtQUU03EhPra33P5/o7xdOUFB5tGoapCsEFOv2FWKrDrW1t1urDjV5rxWbT8egk3VmFc2MXL6xbEDI5Dgbym3Z5gXZg4C5cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svV+1L/iHwqfnExcnI9JmUOgBdn78plKEJUbq7Na1LY=; b=jhMIGJQto5tjQZvRcEfkxVcHjS6UXKbVnVs8/4qK6V46TKC5NXp9VQJtJnZFNkQGDadGeX9riRaos1w+cHmqx8Yr42nSCcRD1zZKfT9fiVqV30iQ/UJtAPs4nDRQE4FRO4DRrKVs9+cMS6HbNnyGBoEawA5ESKJlan9IQtwTq2JVS7B1yxODpVoVz0tk1z2zJ+UN3twXxp4oZRCu2APlUQC1TiFsMYLXHZKYCdMP9Ou1dg1Vd4LzOhbiG+uiFOu+WIKAY9NNquqSZk1OjUMYmGWA4Odtb1m8lZHP5fjjn/S/xiQs0d+MDm2zyqIQ8pKGDt6eTeR3T+/x6KgzPMz92w== Received: from MWHPR1701CA0021.namprd17.prod.outlook.com (2603:10b6:301:14::31) by BN8PR12MB2881.namprd12.prod.outlook.com (2603:10b6:408:9d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:08:24 +0000 Received: from CO1NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:301:14:cafe::bd) by MWHPR1701CA0021.outlook.office365.com (2603:10b6:301:14::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:08:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT025.mail.protection.outlook.com (10.13.175.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:08:23 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:08:21 +0000 From: Xueming Li To: Jiayu Hu CC: Luca Boccassi , Yinan Wang , Maxime Coquelin , dpdk stable Date: Sat, 12 Jun 2021 07:02:11 +0800 Message-ID: <20210611230433.8208-37-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e28024f-f068-4626-d98f-08d92d2dcffe X-MS-TrafficTypeDiagnostic: BN8PR12MB2881: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: leR44NhmijX7llswJdxbXOW6erf3xZboR99nxTf3SX02z6k+JFffudO7GCMRcs5TF3+ks/WczfW4BsI0cHrY+G5vo2LHcTMA7vn/puZYpFJa1vU981R940k4dKZWCF689Geh526lH1rkV9R7ECNcTe2SX6ErFcC0JqV98cygv7k7mpyV96sATpqdrYCrxXaWJqWTk6uhwbxxYKrP8yCQ1gRcYfmT4+8n5XI3fJUdlMP8cOUabn/GClyWo8LAxC9xJuDsyYjN25hMBnPhA1puMzuSTSsNaBVM7ONPJd2lrjHylPiX/NrEiU3an4/rySGXX/0nzWGq/93AmeXx5ElZKJ5ZhNK/wkIzFXEaSEs7Pqq7HBdgZTFdAdhJQQsYnqwtH2fvCWhG+omo+4eRtnfQQZqym0RHFXS2gKPED5Zeijjw0uMOiXiVxzlLb5GOW9b5SNl5b92E7LhlhqUoU2TGPOXiyo0qke+od6vYPuZOhK3cj3XkhXEnvnwfq821q2Os7hZXqvR97Ypj3wE9c0ietFWD6ikJ/6UlJVY3E/nwB+tfQXWVoV4g1yl7laTUPvfPGsUS4b3wfL2AN6erC3L+xuOb7JaOE+tu0riCEGYEsl0W6hdzJOEyTzzjw2nI9friytjBWtUobpd2z16MuYafMeZRLI/Qtfx+o5f7TltIeDpkr2qqRHIgQ5hYD8dIyp+P8O56ovsStAES3gkFxEVV5VXm4h19VHtOkZVyk+Nt2ZJDVNPR+/YCpEmiHKP3F/h0bNEa7MFmKj+tlCuPXP9WTdDjdctfWxeSqLDRGSM169S1KB2SXGTFqZ1UsSqgbIKn X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(46966006)(36840700001)(8676002)(7636003)(426003)(4326008)(336012)(82740400003)(70586007)(70206006)(2616005)(83380400001)(36906005)(356005)(8936002)(966005)(5660300002)(478600001)(2906002)(54906003)(55016002)(6286002)(15650500001)(53546011)(16526019)(316002)(186003)(86362001)(1076003)(6916009)(36756003)(7696005)(47076005)(36860700001)(6666004)(26005)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:08:23.4850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e28024f-f068-4626-d98f-08d92d2dcffe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2881 Subject: [dpdk-stable] patch 'vhost: fix redundant vring status change notification' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/24743b77a7384ada2f25bf9e6a6c34921fe4f325 Thanks. Xueming Li --- >From 24743b77a7384ada2f25bf9e6a6c34921fe4f325 Mon Sep 17 00:00:00 2001 From: Jiayu Hu Date: Tue, 20 Apr 2021 04:57:45 -0400 Subject: [PATCH] vhost: fix redundant vring status change notification Cc: Luca Boccassi [ upstream commit c94c9f3152a37fb31553e410ab7fd06f23802c71 ] When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, there is no need for vhost_user_set_vring_kick() to notify the application of vring enabled, as vhost_user_msg_handler() also notifies the application. This patch is to remove unnecessary vring_state_changed() call. Fixes: d0fcc38f5fa4 ("vhost: improve device readiness notifications") Signed-off-by: Jiayu Hu Tested-by: Yinan Wang Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 45c8ac09da..78fb49b311 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -1876,9 +1876,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, */ if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) { vq->enabled = 1; - if (dev->notify_ops->vring_state_changed) - dev->notify_ops->vring_state_changed( - dev->vid, file.index, 1); } if (vq->ready) { -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.631516200 +0800 +++ 0037-vhost-fix-redundant-vring-status-change-notification.patch 2021-06-12 06:53:56.180000000 +0800 @@ -1 +1 @@ -From c94c9f3152a37fb31553e410ab7fd06f23802c71 Mon Sep 17 00:00:00 2001 +From 24743b77a7384ada2f25bf9e6a6c34921fe4f325 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit c94c9f3152a37fb31553e410ab7fd06f23802c71 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ - lib/vhost/vhost_user.c | 3 --- + lib/librte_vhost/vhost_user.c | 3 --- @@ -23,5 +25,5 @@ -diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c -index fa8929f563..611ff209e3 100644 ---- a/lib/vhost/vhost_user.c -+++ b/lib/vhost/vhost_user.c -@@ -1922,9 +1922,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, +diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c +index 45c8ac09da..78fb49b311 100644 +--- a/lib/librte_vhost/vhost_user.c ++++ b/lib/librte_vhost/vhost_user.c +@@ -1876,9 +1876,6 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg, @@ -30 +32 @@ - vq->enabled = true; + vq->enabled = 1;