From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0810A0C3F for ; Sat, 12 Jun 2021 01:08:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9DEA40691; Sat, 12 Jun 2021 01:08:35 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by mails.dpdk.org (Postfix) with ESMTP id 54BD74003F for ; Sat, 12 Jun 2021 01:08:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YaA/WMOIuj48Kd580xkn4CSL/gGzbwRuIFrMjQS818ufxj/ogA4czVa9wCf2Kui3VdkUE+9zUlEQbQWEO4SJ+4e5n3w8N0SNllLad4MF+xSF+PbwkAnAlyNoOy+iUG/JNGMJviYX217PHvTyEwoH/O5rw5KSEieMukRaMl0Bk7eJaTLoJVA0P5YWJfKQ/jMH0Jdg3jbOwmbg5CjGeUaycjxqJ/fPAUsSU0bVcyJkolbaDgXX0fZqL7zcF/giNe8BVHv6Su5VGbO1Cf/REwCGzZiS7t5MMThk8Op/DjhjsR19ofGYrgHqDGeakueU7g4NLsIKJ6VoTnMQuRCGnM0Kwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FtH4aPL5/aZ1brnWNklyPjGW4fXJbLRcdHkqr3C8Jyk=; b=YWwJ8c+BaUVPX6oLMliV939ebNBBvqB30zSKBvot0W/xaZcWUez8z08TiOpRexqxI1g0/jX2iqojV0i3E0tbhFzWRcHUNP+Y2F8DyMhkgpdv58RVW+/z7D1LXpbzbWiD4Dv5kcFZK03KKzOTcBrzRzyEuPcfkzfEi0ubL6zsTlLigA/+SNoOEC10BKuxOag4UnjAi4oXKxjqXd94p+KGGno+BQgU6G/7gFl0jjnBcP7f4pfegj1W1tETJ0z7SNWKbU68MaKD9bO9cPIhwkAzTlyMj4FXTg1gTN7uwvAqbcL1Sz5PxvippSysahbgmAeHRFW4k98EtVaKyes3zBou5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FtH4aPL5/aZ1brnWNklyPjGW4fXJbLRcdHkqr3C8Jyk=; b=edxYXxjpHxl8v5VqZjT4mdMZyc85teO7+f/hEQbOtdaeT06KLQXBsuRGExs2i27DVD64LtirMW7lsyVElk/cyGbClnA6CIGWruhoBDROmOizI3RpXq8OISPsHlViZr3SAfWLrBERqL326FDhY/7L0mjvC8lVJ+rwnXnlYs5qKt1qGyhwEgoHfAB/BKtFBvZK8R5qhMDUijV2QplCbsvL0/pKSaDSaURSznsw19muJuAmee4OaWOEEdyv9BnmzYN8bP6EpCKkTzSnTI2PT6KMIlelDqpRoTpON2suWPlRJI44NupPtcU9J6t8CCZAKStbsIsmPN/6AnJRrY3G7q7Otw== Received: from MW4PR03CA0340.namprd03.prod.outlook.com (2603:10b6:303:dc::15) by SN1PR12MB2368.namprd12.prod.outlook.com (2603:10b6:802:32::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:08:32 +0000 Received: from CO1NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::10) by MW4PR03CA0340.outlook.office365.com (2603:10b6:303:dc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:08:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT048.mail.protection.outlook.com (10.13.175.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:08:32 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:08:28 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Somnath Kotur , Ajit Khaparde , dpdk stable Date: Sat, 12 Jun 2021 07:02:14 +0800 Message-ID: <20210611230433.8208-40-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a777989-459c-44ca-2a47-08d92d2dd52a X-MS-TrafficTypeDiagnostic: SN1PR12MB2368: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Se1VXaB13k2XOOCPzpQ2h0uT0T6jD2CbGSh/NpgGcUhPHDsIIeon+edVPBQOPwWRSxYUBXhr6IF7Y8WItMvUkMvj6TDdnYUpZS8nagRhcPcmDq2kRHptAjtipWpoVrbCKymz7Wtv5gUG9jSN7Vl60qeBXamZ79kxRhL7qbSNKmdHRMV8sigm9maymwV2tSTOETdLYEK1mxfhC471bF/nYpbSt5hFZ905nettFSISNYXEWkCariAMtOOfNmDskH7ORAehhNdxWujRofNmHFILz8d6pW+WoQh2HCnmPBQydC0eRL6M/q8SN/gvo0Rc2j1oRpDHUp9Q2LRkD9dxiuVCX+tfVZEKYdDOUohiarNn3aFMYnuoze4tAWVInSVcMNKXAaifF71cOmh9gFCmLJ/XQHxD+sXNJa0zQxa1sDA3OKbQqO0RoE4E+aGf4LnoGJnG/oON52wJOiXGaDYLMJ4VPk9OZnXheNMoEVU4fWP1d7G9sPIxvuqZIYSgPl3wSZGGGME/RaWuq+9s1Rj6wYnPJJixEiCaUm0SYm+a+uJquCypYRQz0591FlFlSrrxUOqe4YTivFNl0+PpHLuR+bRl6uIFi7MULiFVtsAeJWUoC6/jnmaae5mEWap1WmYWyYH7DYdBXPEkjLuJfMqn7slbFx7ENPeL37M1wYPZSSZSaqoVDbQor8cj/4tnQRwIJgAIUD0+WF3yalmW/+nNYO6IrbQ9jueNcdg3S9ZKpUkRZsWAcUPs430jS1LwVqx5z46ouUBQmmgJnIlnd+f3B6obVWnzl+MY3fViUTCmmCKzUVBrcDjoxn5W7K+0JlQuKHTO X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(39860400002)(46966006)(36840700001)(36860700001)(6666004)(55016002)(47076005)(6286002)(426003)(36906005)(4326008)(1076003)(316002)(336012)(5660300002)(7636003)(2906002)(70586007)(8936002)(70206006)(356005)(86362001)(26005)(82310400003)(82740400003)(186003)(2616005)(6916009)(7696005)(966005)(54906003)(53546011)(8676002)(83380400001)(478600001)(36756003)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:08:32.1645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a777989-459c-44ca-2a47-08d92d2dd52a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2368 Subject: [dpdk-stable] patch 'net/bnxt: remove unused function parameters' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/52d2337eac089e365c240e532bb38f45c220c8f5 Thanks. Xueming Li --- >From 52d2337eac089e365c240e532bb38f45c220c8f5 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Fri, 23 Apr 2021 10:49:29 +0530 Subject: [PATCH] net/bnxt: remove unused function parameters Cc: Luca Boccassi [ upstream commit 91f7a2d437b9370bc2932125e0c17384cd9aac44 ] 1. Clean up unused function parameters. 2. Declare no external referenced function as static and remove their prototype from the header file. Fixes: ec77c6298301 ("net/bnxt: add stats context allocation") Fixes: 200b64ba0be8 ("net/bnxt: free statistics context") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 ++++------ drivers/net/bnxt/bnxt_hwrm.h | 4 ---- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 67509dc8f9..5ed38c9427 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1771,8 +1771,7 @@ int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) return rc; } -int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, - unsigned int idx __rte_unused) +static int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) { int rc; struct hwrm_stat_ctx_alloc_input req = {.req_type = 0 }; @@ -1795,8 +1794,7 @@ int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, return rc; } -int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, - unsigned int idx __rte_unused) +static int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) { int rc; struct hwrm_stat_ctx_free_input req = {.req_type = 0 }; @@ -2461,7 +2459,7 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) bp->grp_info[i].fw_stats_ctx = -1; } if (cpr->hw_stats_ctx_id != HWRM_NA_SIGNATURE) { - rc = bnxt_hwrm_stat_ctx_free(bp, cpr, i); + rc = bnxt_hwrm_stat_ctx_free(bp, cpr); cpr->hw_stats_ctx_id = HWRM_NA_SIGNATURE; if (rc) return rc; @@ -2488,7 +2486,7 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp) cpr = rxq->cp_ring; } - rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr, i); + rc = bnxt_hwrm_stat_ctx_alloc(bp, cpr); if (rc) return rc; diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h index dbde8f69fb..a67a17b3d4 100644 --- a/drivers/net/bnxt/bnxt_hwrm.h +++ b/drivers/net/bnxt/bnxt_hwrm.h @@ -165,10 +165,6 @@ int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx); int bnxt_hwrm_ring_grp_free(struct bnxt *bp, unsigned int idx); int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr); -int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, - struct bnxt_cp_ring_info *cpr, unsigned int idx); -int bnxt_hwrm_stat_ctx_free(struct bnxt *bp, - struct bnxt_cp_ring_info *cpr, unsigned int idx); int bnxt_hwrm_ctx_qstats(struct bnxt *bp, uint32_t cid, int idx, struct rte_eth_stats *stats, uint8_t rx); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.700289800 +0800 +++ 0040-net-bnxt-remove-unused-function-parameters.patch 2021-06-12 06:53:56.200000000 +0800 @@ -1 +1 @@ -From 91f7a2d437b9370bc2932125e0c17384cd9aac44 Mon Sep 17 00:00:00 2001 +From 52d2337eac089e365c240e532bb38f45c220c8f5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 91f7a2d437b9370bc2932125e0c17384cd9aac44 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index cb2064dd57..931ecea77c 100644 +index 67509dc8f9..5ed38c9427 100644 @@ -26 +28 @@ -@@ -1899,8 +1899,7 @@ int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) +@@ -1771,8 +1771,7 @@ int bnxt_hwrm_stat_clear(struct bnxt *bp, struct bnxt_cp_ring_info *cpr) @@ -36 +38 @@ -@@ -1923,8 +1922,7 @@ int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, +@@ -1795,8 +1794,7 @@ int bnxt_hwrm_stat_ctx_alloc(struct bnxt *bp, struct bnxt_cp_ring_info *cpr, @@ -46 +48 @@ -@@ -2594,7 +2592,7 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) +@@ -2461,7 +2459,7 @@ bnxt_free_all_hwrm_stat_ctxs(struct bnxt *bp) @@ -55 +57 @@ -@@ -2621,7 +2619,7 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp) +@@ -2488,7 +2486,7 @@ int bnxt_alloc_all_hwrm_stat_ctxs(struct bnxt *bp) @@ -65 +67 @@ -index d9771eabd3..90aff0c2de 100644 +index dbde8f69fb..a67a17b3d4 100644 @@ -68 +70 @@ -@@ -168,10 +168,6 @@ int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx); +@@ -165,10 +165,6 @@ int bnxt_hwrm_ring_grp_alloc(struct bnxt *bp, unsigned int idx);