From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DBBBA0C3F for ; Sat, 12 Jun 2021 01:09:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 780B940691; Sat, 12 Jun 2021 01:09:25 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by mails.dpdk.org (Postfix) with ESMTP id A23924003F for ; Sat, 12 Jun 2021 01:09:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XhqXIES7WG1gKSpZ7eiEwjkz56UUqTkmkKOmgKpz9yLp0Outvj2LcRZOZDZgclfIt+i2D35/PSKIOgUayaedLKhf1olC7OlnwWGlOe86YjIJxzF4c4VBQh1gyKBdhyIM6d1CSMZFhCdUmW+laUI7dN8Hu3puZ1nulOQEcK9AQf44ZhDwGcuNsx8dXEQQHLbOaZYFbEjypxl0GanbcDEAhmyD63ZqO3k4Nkt4JoShgWxs8dBLzho6i8jaq+6HttU5AyOaBP4qUIsWtIyr0vmKiiWvStmqHGW2fAAFb4UsLXXloZMmSHpSJvl4zsAj8UediKbhAzneUw5nQ6nmIdU8Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5edsKugaYvbPMo5gTn+kdgEC/BC1ngPz2wltkR2R/iA=; b=NUnEOCwd1rULJiYJCBsbM15UTMTX0ANFGW29BSERcAPsGykARESicx1Fu+B0nyC5Sb1GFqUEDw16poozz1BaAJgBe13PGCUtWm/sLwdTEaTcaSbDRknReSSk6bnsGmKSs0hQ0bl4E25Vbs/MvRNaNbzuXNjU0FTobAwtlADND5VU5wbzmf4FpdAtVqAJT7Pt/vt1J3/ObqQbsZVeXYd37Y2pgZspg1p3lTMviUJIq2GjiDGLaGSuQhTI0LBh1Zu1ykgMzB05/V5LmXIs/msuatw3DZgKnb/zdIGk9mSTuRjuozdz92hMJ8KFaXDT8aiTkbF1nDUfJ2idNhXvRnO3qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5edsKugaYvbPMo5gTn+kdgEC/BC1ngPz2wltkR2R/iA=; b=ihn7Lcydg8NqK9tML6dGLybEGauTxNUoYu5bPizHcZi8N24N8xC7PNwm+cCqcj8E3GaQHryisMNgtSE8mF+Wt9turoM28VFvWb1xmHezkEBB4pXZAselqMk5KwFVoLpV0pw5ticarrzJu/GoKKJpFyXDeNP+K6Tw35xdDxI9xAPklQuye3h8206D/ljvoIkb81s62Uxl1V9WXsevtQdW2lBw1TnIW6sgav4bHwkBRyrWjLV8lajE1wj+ePs6Ss74rjBZQvImMEt9TlbJA07s0oMjIYi0CqnXEIXdk4VAmPu6S6YaJk9qorW9EVi4C4H5hhJq68zK94XteIaQa46n3Q== Received: from MW4PR04CA0390.namprd04.prod.outlook.com (2603:10b6:303:81::35) by BN6PR12MB1140.namprd12.prod.outlook.com (2603:10b6:404:19::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:09:23 +0000 Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::54) by MW4PR04CA0390.outlook.office365.com (2603:10b6:303:81::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:09:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:09:21 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:09:19 +0000 From: Xueming Li To: Chengchang Tang CC: Luca Boccassi , Min Hu , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:02:22 +0800 Message-ID: <20210611230433.8208-48-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83d32b9f-3573-46ed-04ce-08d92d2df2bb X-MS-TrafficTypeDiagnostic: BN6PR12MB1140: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TXIiP3S0Ez1ft2d3mlNz+0ydJjxapMauqI5z+FFYC+wkk/IUN0Cie3lvAQrprhdkDpNrzrRO6iSj2ad1x9Xh8EU07awCagj4Nvk43skFFyvEZf+dg/EvS7yrjxc0RJwpKxueUBBYlNQAlerJ6ayYBDEYwoWRr7p5i5OLWXXVROmZzBbh4AUvNWMMM0rSSjLiuV9uVtjq3S4sZ+wPzsa1SnnC473PotoolYn12J+QgGCM+xfu6rvINDx5A4we1N9XeOAyV6f+rCvRQv3B2Ft/vIvMYiDGz6CQGXNxEuIxrAm7HiE9l94sSrU/clcMYT8eFcFJChtd0rfD29+W+0yZn9wTBpCtPA4EpNu2ybQS+hRL9N9TSmF9XM2VZhrOa8hIRtUD2o0XOoi2gXRT1mjnqWb4DjdMrnoDy0RXKsfZlw2+D0ovDt4QVfQKvc/oB7ck0xIuGLM5GGtfPn8YaKejasaHrJEX1wdRopr0me1nOqN5Nu0qoTClsAJoLPMZEJAUPlxYtfwToTznbZvWLd/9dJG+SN5IG5QkGezwE5bzGp3vYRYFr/S5YGHnUF94QGpCLaWqNou9jeAbpvQzXqu6s6ppxQOb+GULLE1lOFEp6g+IiZPn63LE91mBxxXaRIoEeafSPcxopEuj3wz6W/+IvlKRtE073+8k6mjNbvaGeWk5J1NATMGNQ77AmbqFQFwZ9DpmiplMXz0fmOKEWONHWwDCbZttqJtcCLZT7SOjCcAn2UUcqSgiydjWWEdv0bmb2tYUWYw28O5XMN/bv4/3iMtN3dYNIGWeZ6rY0lkCXncGKFP9OWmLAzylZ3k9FBQC X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(46966006)(36840700001)(6916009)(82740400003)(356005)(426003)(8936002)(54906003)(83380400001)(82310400003)(2616005)(1076003)(7636003)(316002)(336012)(36906005)(8676002)(47076005)(4326008)(55016002)(6286002)(6666004)(7696005)(966005)(2906002)(70206006)(70586007)(36756003)(5660300002)(186003)(86362001)(26005)(16526019)(478600001)(53546011)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:09:21.7677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83d32b9f-3573-46ed-04ce-08d92d2df2bb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1140 Subject: [dpdk-stable] patch 'net/tap: check ioctl on restore' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/3caffc544754a9ed914795dd4cd5128f3e8fc4cd Thanks. Xueming Li --- >From 3caffc544754a9ed914795dd4cd5128f3e8fc4cd Mon Sep 17 00:00:00 2001 From: Chengchang Tang Date: Tue, 27 Apr 2021 08:54:22 +0800 Subject: [PATCH] net/tap: check ioctl on restore Cc: Luca Boccassi [ upstream commit 8f3ca7f9a8b1df13f06236b8ab2dbed238b65ba4 ] After restoring the remote states, the return value of ioctl() is not checked. Therefore, users cannot know whether the remote state is restored successfully. This patch add log for restoring failure. Fixes: 4810d3af8343 ("net/tap: restore state of remote device when closing") Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 2542de3065..c0a348a641 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1133,8 +1133,11 @@ tap_dev_close(struct rte_eth_dev *dev) if (internals->remote_if_index) { /* Restore initial remote state */ - ioctl(internals->ioctl_sock, SIOCSIFFLAGS, + int ret = ioctl(internals->ioctl_sock, SIOCSIFFLAGS, &internals->remote_initial_flags); + if (ret) + TAP_LOG(ERR, "restore remote state failed: %d", ret); + } rte_mempool_free(internals->gso_ctx_mp); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.904604400 +0800 +++ 0048-net-tap-check-ioctl-on-restore.patch 2021-06-12 06:53:56.240000000 +0800 @@ -1 +1 @@ -From 8f3ca7f9a8b1df13f06236b8ab2dbed238b65ba4 Mon Sep 17 00:00:00 2001 +From 3caffc544754a9ed914795dd4cd5128f3e8fc4cd Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 8f3ca7f9a8b1df13f06236b8ab2dbed238b65ba4 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 68baa18523..854abf4b30 100644 +index 2542de3065..c0a348a641 100644