From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0F06A0C3F for ; Sat, 12 Jun 2021 01:09:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B5774003F; Sat, 12 Jun 2021 01:09:27 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by mails.dpdk.org (Postfix) with ESMTP id 4AB5340E64 for ; Sat, 12 Jun 2021 01:09:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QO9ItWp+5Mclw5aZMceeytYCyYpP6zfrIMBdikc80eat+1bUiVIbyXLL7jiM5BtWQxBuDzzX4nZ88ohx4OzGm14oUSIrJ8/F4JXV6OirKxaoqrOCwv7g4bRpFHsTwqOjGRYcWPgVHYt48kd4lCZo/AF2dqmXikGIXMSvlG62prwsGUQlBP5iKsFoflm4yQ7qwitvRxcC+yNn9DidMdIQ+r6GCBxM937LdhGWAivuj76utUfiTlaM1sHm4jyopXFAO29ebEt15CL4OZivED5pIV4FsKrZX7rTiql61oae7JD3AeG8dBQ42fylYOF4S5Zj/yzhZXIZE1mEhb6VAG6PKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rj4UkQfN43hE1XX22ldCxlLT7jwIuEtOLjy1YuEpA+U=; b=lJbWm7FNOIExNA+TRbcPQeM8cXoFTKi+0gW1UTnXh7hXGcDR30Jn6Vhx9+LxNjW7TZ0dUBRis3gqjc87VaEb102Po92ylMs0fmVHytgRHs77OTKePfJzBeKrxGB2tJGt9rD82VEcnfE8ZjyfBCDmHJsCeSocRBFH3RbwO/QBZxP+E3RAVpBGNriFs6Gln6Z2C2MIfl3XYsU3LB/tZkAITTdLDp9Owp2bpFAjKi3fPiAndYkH45/ujpbiMJa9SZge1gT1zaOIuE7EbYRuTG6pAt1iblABlJHI2UND30X14X4Wx5C4PK3DfFa3eiuGohEwOD7siy9eiPpHVmwR/bY9bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rj4UkQfN43hE1XX22ldCxlLT7jwIuEtOLjy1YuEpA+U=; b=MXKLanzRNz7bsyrLGcRm+JGrIEHdTUXg6RTrZYF2Sz52p3DHubppjDrkRIzPw2Tulz9dY7Zb8XUNK99AfbGtnF6xEoGE5x/YNzS6M1dAByWcGcncGqoahDCRH3vqrhbrKY5zlf7+6u8NsY36WUNu2JwgP2O4Tv7lst1DRbWuxo4mhtuEir/RnOjrAMoWuOtAhFbA9haWJhYVf4Je50JODvcGVzkAdsSYOqHZ4Kru3WWP8vDdKbWxmhJyHPKN2SP71s55hgEfNSTMDe0CdgpXcTVRKAr0f7rZIDZ2NctIqCe/s0zNdSzf/x9czhSgmDk7SdqK0oVbSU+mloP/vezpGw== Received: from MW4PR04CA0374.namprd04.prod.outlook.com (2603:10b6:303:81::19) by BN8PR12MB3380.namprd12.prod.outlook.com (2603:10b6:408:43::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:09:25 +0000 Received: from CO1NAM11FT011.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::1c) by MW4PR04CA0374.outlook.office365.com (2603:10b6:303:81::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:09:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT011.mail.protection.outlook.com (10.13.175.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:09:23 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:09:21 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Ferruh Yigit , dpdk stable Date: Sat, 12 Jun 2021 07:02:23 +0800 Message-ID: <20210611230433.8208-49-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 726fe7a8-2f0f-45c2-d7af-08d92d2df3dd X-MS-TrafficTypeDiagnostic: BN8PR12MB3380: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I4/kjgYOYXm91TOnM6qMOpVWMYo8WBoEdhV/fY0pIRCd2lxFb9QpFw9N7d2s8qN3XKI+6/9pG+9BUy6lgp6fLO0YrP7OHHYY5f19zWwUftSPbOBQcpxwMJebGCSw8ib18lOm3ZyJ+qVNsIYqIHakWXD4cSZE41qm3aPB1aqr9Bm6uRkkLzt6f13nQ+EqHiYDRkEevB+dCSs+0jj3Gjj0KGEXj8ekAv3j6nuB7egm+GFpIdNDh/xngo0DrW9vmlnCBO2NMeAwcdhmKmRkpG9AzWDS8l7Zx54g6ukY+qewZXVfddsZ092cr9BjYnDTKoOcmC6Z6x1tV19DZzSjCadaEg5Iv3M1bX5qDOkyVrQfRZNjSFFAvITKtwy6+E6QSEe9LmwDar1mwPdw/x0EXh/GkbCHzW0zTbraqXHXIL5vU/ZWjNlfLPqcaXgmF/ks61dohTD2QdC//IZ+bQVKHDt1LtrSDmunqo/AzHrcKG7r5SO5ip0DQJT5fXmSyTOuGVim/Zoljvg0iPHh5/qwhCOJS1ebk8URD5w8AeXQakGcYAPQkumEo+d71T/uErXs41Aehfq6mIh5W/ub2A7covy9GMn0LLVMrrGQWL1nlkkJB4u02tKm+mujmHLRF17C2ydHQ68LZno/uVgA3i+bKAizojhUAXKzK/o73UiEj+Nvzh7iwJktWB+NWBSWCAF0wSQl2nuwsDZ3ViJB4kPYi1c2bK0hjY+j9/z+JmjpMDSIKXSlQYlBCgkCYgtpqib075gBo5Nys8M8K+Ts1p0A2rpHr5DWEyog2P8iRFuKHB/s5BZZFGGHnhB6dWOAqWYvZKgk X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(346002)(136003)(36840700001)(46966006)(36756003)(54906003)(426003)(966005)(8936002)(55016002)(7696005)(53546011)(336012)(5660300002)(83380400001)(8676002)(7636003)(70206006)(478600001)(6286002)(2616005)(2906002)(82740400003)(36860700001)(356005)(1076003)(47076005)(6916009)(86362001)(316002)(36906005)(82310400003)(26005)(16526019)(4326008)(186003)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:09:23.6686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 726fe7a8-2f0f-45c2-d7af-08d92d2df3dd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT011.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3380 Subject: [dpdk-stable] patch 'net/kni: warn on stop failure' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/9874e06dc5788832ba924480918fbced7dbd17bb Thanks. Xueming Li --- >From 9874e06dc5788832ba924480918fbced7dbd17bb Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Tue, 27 Apr 2021 10:08:45 +0800 Subject: [PATCH] net/kni: warn on stop failure Cc: Luca Boccassi [ upstream commit b752fb4d626c4a0f4a90f04df3684cb5318c376f ] Return value of function 'eth_kni_dev_stop' passed to 'ret' is rewritten later, and this is unreasonable. This patch fixes it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index aae6dcb54e..5d8fb1451a 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -211,6 +211,9 @@ eth_kni_close(struct rte_eth_dev *eth_dev) return 0; ret = eth_kni_dev_stop(eth_dev); + if (ret) + PMD_LOG(WARNING, "Not able to stop kni for %s", + eth_dev->data->name); /* mac_addrs must not be freed alone because part of dev_private */ eth_dev->data->mac_addrs = NULL; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:57.930095300 +0800 +++ 0049-net-kni-warn-on-stop-failure.patch 2021-06-12 06:53:56.240000000 +0800 @@ -1 +1 @@ -From b752fb4d626c4a0f4a90f04df3684cb5318c376f Mon Sep 17 00:00:00 2001 +From 9874e06dc5788832ba924480918fbced7dbd17bb Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit b752fb4d626c4a0f4a90f04df3684cb5318c376f ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 4d2a42ddab..51daf08591 100644 +index aae6dcb54e..5d8fb1451a 100644