From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 183C8A0C3F for ; Sat, 12 Jun 2021 01:11:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1363940E64; Sat, 12 Jun 2021 01:11:21 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2048.outbound.protection.outlook.com [40.107.237.48]) by mails.dpdk.org (Postfix) with ESMTP id 9E44640DDB for ; Sat, 12 Jun 2021 01:11:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1/cCmS2iO33XwLBmBglp6efk6D2ItWP+xldALO1RNOCW05HdaOlPTGtckh0bOQQEC8biPuZEh3DyS7gvpMj7B3NwgZ/87I0i/CDvqPuvycdc5EPcDHG2RCvNC1MMght/RDWwSGKON0o+PuhlEvwlX+BH5WcdbIf6mnJKicggVRFPsSNduc7JoB5NRK6jkKQnOifNdpZjmGvnbAlIO9NYd8qyZwgJ8R8KdYB72VBECeYugjGvPNsV5ZVjBs0RQkKHjGxxnr7ulsIxk+VjXhwEul1eo16RFbObfnqC+PGGO62KS1z36/gVIKDMZ5hmzHT5WOiw97fMiDT6NOpIBb4HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TY703bVSnXHFkcT59BIuGrdyu1sf+bdsGgSedFP/T0=; b=JeMqvQA18DrFpnC2K9w4VeiCTiFrH5KuNbcsheEgI01OkeUS0sLMS6L1a/ptsGQCU6Fz8ZUpXerV7FpGXoRqoY5pZ/O6n7XG/y/NjjHaXtRE5YrFheqikh000v2KWthF3pNH9KxjfyQ65geFspALtuJNQsmRi6nTCuGkq+WrmeoW6G07Lo5SMvJCgH7Ts1BRdw2et0ynpysA8MU4Wkpf9hurkSr2pVCED7TFthV77JVtfkQf3NhvCXnS0o8i0UCeXdMUCxgWcGkb01CYhhCPButGOu6CM5q0rqZ2/i4c3FGrDgC8I7jQtzVrAo5+7UPXY6YanuTEz9NlzLYHHHqzmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=partner.samsung.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TY703bVSnXHFkcT59BIuGrdyu1sf+bdsGgSedFP/T0=; b=tjjvN8ZnEomjUlWqIG7BMhHNuRQRqAFmMpoLvhK196BwafY9vI5JEf/8sn2x28zGSzmKsyDi5y+d2eTvSug1IGesqtkzNQBZYA2LqJ0dyqtjSOfSa7aQ1gvoh0ZLlXm9Ok5bH0p4biECVIwLe7J0JFeMgcz4xZnoOA3COZBNwjQ92H9571NTGOmM7jb+jI6sjo4EKEZKiG7PS0Qx38l15R+4nb/tUmpljkBfCY/gDn45NCGpahcGCPUQHtElYPxlQFdcscSI9WLEjdLxa6mL0Qx2+ihk9ICH2RyRY+PIjqFP9BW4etUR9WYazvK0c9NN00T5kaxUMckrqt0FWK6Ckg== Received: from MW4PR04CA0348.namprd04.prod.outlook.com (2603:10b6:303:8a::23) by DM6PR12MB3178.namprd12.prod.outlook.com (2603:10b6:5:18d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:11:18 +0000 Received: from CO1NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::ca) by MW4PR04CA0348.outlook.office365.com (2603:10b6:303:8a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:11:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; partner.samsung.com; dkim=none (message not signed) header.d=none;partner.samsung.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT042.mail.protection.outlook.com (10.13.174.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:11:18 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:11:16 +0000 From: Xueming Li To: Stanislaw Kardach CC: Luca Boccassi , David Hunt , Lukasz Wojciechowski , dpdk stable Date: Sat, 12 Jun 2021 07:02:43 +0800 Message-ID: <20210611230433.8208-69-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd4479db-d40e-4bcb-f8a7-08d92d2e380d X-MS-TrafficTypeDiagnostic: DM6PR12MB3178: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qxJGSWpSXpnPSx0knfgSWXT+YTl9N8xyqXVPNBvUfWgRQdLdMCuHVbM2llD2eUXMNnc3QiZ/HCCCGtem6+xwa1dPfvUmEYwywLW9XhOFcS6CW2YmaCepgDpMR2ir16gdABM/3tvNfajaAZaijdq+Gi9bVCVIbqqGYu67haobubS+W8VW9E821sKMG1cJ9xi101btvQHLtA6XJF39IJIb9Si83kSc8ntvZo8DHTQl3grV5lb/+g1x3nloxNruuhVBSHzT7M/BuQVxzl6M/QmZ9Ed474+IvIdS6qdmrMlM7Btfxumz6GjWyP0Ink5GQYkighuHFbbgGD6EtP4f/qVrwxhkT7raZ7QHh1pY7o45iJMvmVKLluAwj3fYiNf34AfIi3mojPh1jJiR5N+e4YrzRWnVwwHeKDqFWmivR5bi/559Ryy5dib5RV4vlJ/inK3ChKvM+73O9JOtC3U89SHHt4yAMnoc5ivM4iDGETe9Yodx+JT0IfZIDdWKEWxDCDtobYNctmBoXf1/aM//YqPg0qgvTHK/w42x8w4/sAUN1ay1k7OG1OrV+yLqKIFJX2nowh6jdGsbGm/4NHFH7dj97y+6ctjkFMbZGNvNt9JTSjcdk0QPEk0ohFLmJ4pdy0D0aEY1USb1+so286rnFRWlPs4pztoZwzlLgndmJyjEUqFD97+HZp3K9fKGy/PZVg34eZYwS63dbjyYtI4BFv90SWBg87hR3u7gPLVLIuMr3eIDDL2o9BxgpBOyl6asa8+w+xZaU2cxd7iSXdPUyq89cLY7MR56vzwO2lt1Ry5Mozdj+JqhxxhygGANAZKwbw2V X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(36840700001)(46966006)(70586007)(966005)(55016002)(70206006)(336012)(426003)(1076003)(4326008)(316002)(26005)(7636003)(47076005)(82310400003)(53546011)(36906005)(8676002)(83380400001)(8936002)(186003)(2906002)(6916009)(36756003)(5660300002)(6666004)(356005)(7696005)(478600001)(6286002)(2616005)(54906003)(16526019)(86362001)(82740400003)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:11:18.0611 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd4479db-d40e-4bcb-f8a7-08d92d2e380d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3178 Subject: [dpdk-stable] patch 'test/distributor: fix burst flush on worker quit' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/31619530c8fb788188202ca91e58cbe9e43dcba9 Thanks. Xueming Li --- >From 31619530c8fb788188202ca91e58cbe9e43dcba9 Mon Sep 17 00:00:00 2001 From: Stanislaw Kardach Date: Wed, 28 Apr 2021 16:25:53 +0200 Subject: [PATCH] test/distributor: fix burst flush on worker quit Cc: Luca Boccassi [ upstream commit 6cda39af86ffc629732aac79058207cb4044e952 ] While working on RISC-V port I have encountered a situation where worker threads get stuck in the rte_distributor_return_pkt() function in the burst test. Investigation showed some of the threads enter this function with flag RTE_DISTRIB_GET_BUF set in the d->retptr64[0]. At the same time the main thread has already passed rte_distributor_process() so nobody will clear this flag and hence workers can't return. What I've noticed is that adding a flush just after the last _process(), similarly to how quit_workers() function is written in the test_distributor.c fixes the issue. Lukasz Wojciechowski reproduced the same issue on x86 using a VM with 32 emulated CPU cores to force some lcores not to be woken up. Fixes: 7c3287a10535 ("test/distributor: add performance test for burst mode") Signed-off-by: Stanislaw Kardach Acked-by: David Hunt Tested-by: Lukasz Wojciechowski Reviewed-by: Lukasz Wojciechowski --- app/test/test_distributor_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 371a14ba4c..fdbeae6d2f 100644 --- a/app/test/test_distributor_perf.c +++ b/app/test/test_distributor_perf.c @@ -196,6 +196,7 @@ quit_workers(struct rte_distributor *d, struct rte_mempool *p) rte_mempool_put_bulk(p, (void *)bufs, num_workers); rte_distributor_process(d, NULL, 0); + rte_distributor_flush(d); rte_eal_mp_wait_lcore(); quit = 0; worker_idx = 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:58.404285500 +0800 +++ 0069-test-distributor-fix-burst-flush-on-worker-quit.patch 2021-06-12 06:53:56.330000000 +0800 @@ -1 +1 @@ -From 6cda39af86ffc629732aac79058207cb4044e952 Mon Sep 17 00:00:00 2001 +From 31619530c8fb788188202ca91e58cbe9e43dcba9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 6cda39af86ffc629732aac79058207cb4044e952 ] @@ -21 +23,0 @@ -Cc: stable@dpdk.org