From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CB8FA0C3F for ; Sat, 12 Jun 2021 01:12:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8204A4003F; Sat, 12 Jun 2021 01:12:16 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2087.outbound.protection.outlook.com [40.107.95.87]) by mails.dpdk.org (Postfix) with ESMTP id 86AAD406A2 for ; Sat, 12 Jun 2021 01:12:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ghfgDX1gkn96Y+5SAcoNlH3ILr/Xn68B8jMPWh01xnKqfrGGBf6jFuLeNq2Y0VsAT8PMOC/xqwxzbi7j0ay5Xk571CqkTWgfUW8k88hxhCNDzOgw5UxtHYqADihJ5ZdYPZkyjB/SClynQ3Pwv6/JQJmq/fKrPWtM65vcQCzQ4R5kRooSL1XkQwdZkdwGZ4PW1vmTuQMA/Ohvy96hPkJzbKKyrc8slmD8L80Xtbhz54EpV6uSUWqN1AqHsFzagzVicpeRTF/VN0Wsz+Ce6VbvSch8KVbP8gw7P8pSWWl4KcgumBAtyCxoIvnWkFbwTn0ztoAo0/bhmUCtxhtJVG26FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IlWNKLLaEg2/k1T+2QAcxeQbU77+bPFr7CDvvmrWc90=; b=S67zsvjiT3D/moYZebCjejzbj1z/bf9l+Bu0Ag4zi6OmsiPB15EiQpDue1d5jVYj+X/FOB+lkR9p4AddfuCI63VdytnB1RVvwBhtqtIcZ2X1LGbjyBJ1oMTgwfFPGPjTB9Oc20m2BvAWbEqmRcktxmK3G7xsZ8VCnif2qJJu/h15Cp2aBkhyfdX33vXkTvSNnzj9ehKGs98TbgkJIGhAJwwSmESBWKxxr+l5pZk3eLe24BrrPhP4JqZazwqC2CEN/IZMXPhQBrGQwvUoq82Njj3wCCe5p6CNxwyVPmMDRtM1jmmQNRbyIjvzrEOSl2EroFfyMfxmiGjRgU40CtXeGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IlWNKLLaEg2/k1T+2QAcxeQbU77+bPFr7CDvvmrWc90=; b=dZtV18R5ld+iNICbnE/ZonIJQxjkRFwXwX2vRoYPWaBg4UlyArffh7+WouV7kViaF/wcgYPCRsnCqqBE4I91FKDsyWIZDSOlOFmuLiya0o3pbEgzWEN+vrkzptU+P9oxZt+ye5sVmxcRpye4NUYa3ZlWpHNWIFWvWtZ4JnZg8J9olWR6Q4AO7MBpWM3Nt7mrqB4zh3eLaDKLvhKfimKVbg+7gWNSh1iTFOTfswERGybCoDaP/N7yp5LUTe8wpxpKphjvB5+CO+rz2zVbei7oHE7zFww3SFILDMz98xhNl9bka/Op78yBSGNB7fHrCyRWyOYPBr2VpQ3caGx1nym4zw== Received: from MW4PR04CA0061.namprd04.prod.outlook.com (2603:10b6:303:6b::6) by DM6PR12MB4811.namprd12.prod.outlook.com (2603:10b6:5:1fb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:12:12 +0000 Received: from CO1NAM11FT057.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6b:cafe::99) by MW4PR04CA0061.outlook.office365.com (2603:10b6:303:6b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:12:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT057.mail.protection.outlook.com (10.13.174.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:12:12 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:12:10 +0000 From: Xueming Li To: Ajit Khaparde CC: Luca Boccassi , Kalesh AP , Somnath Kotur , dpdk stable Date: Sat, 12 Jun 2021 07:02:52 +0800 Message-ID: <20210611230433.8208-78-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 295ef8f9-59be-4a21-6ca0-08d92d2e586e X-MS-TrafficTypeDiagnostic: DM6PR12MB4811: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pE11ZCnpB1hdWzUBPcEGT5Gnp2xD56ikO/IcIovXvdGLb/Bhkj7BYI83/hFovBZszfGx2dturVBgPSS04OZ1TfcB1SXa8auozHsDPknRkM9Y5dQTZtC17kaoMugDAn0DTExrIYM4jx9yJGKMZjGR27OVXbvKPmIXY1NmGGnMXBcT1bvuC4MAEzLOJsVqaScHkaZ3UJaVSVTAskwWsNt+r2KoH5IB03yF4qaM3UdQfFhT1mxPt40nJWuUVHgnU31m8hwlGJj3lPujCD3vEliHTPkUnLEcU8L6oYxPutLW1172VcZEB4br4ZvannUZ2USDpXnhuIZuCITQnrpcvhsDGaSDzM2OSulRv8DueqkT+xLGA2hhmTsevr3bpkFF2tInk0NJ2YRDmbeEWxiTmd2cy9TTb1s9Bml8VJj5FedJ4rfrUTDu1UNLomYKYQeNjGgDNX1O7bGf7yXM6L6Z9d9XRBZi/VyGVVG/kF5iFS1WjuY9gtDceFr7RkOEFX98kvjzvvbVywX7dsWjVoOx2MtVe8x7pvtF3sW+NMvqFXtGqV/mmnbOHGku6v/h0CPZBnN3XEJlq8k7Zafs3b//f8nh7Xw8y8MxuTNEUV+ob8lGi2ZhqE0aF+ENzT1Xk/3405zByB2K/PgxQoUdsfaKVdUd0dErMhXJ9SgsuWdlD47lwUJySexfs707IJf4DyeqT748I80yvDSS/8ikYWz3GiYdTstDLtRUDkHPwDgorckArHNtpkHJ5QR0Nn8Og1OcQKywt8PRoi6Vwc/mebRliUgrl7AkMWMnJ4bYL/DvInooc45+8yCsIqfbIlJpt/znqUFQ X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(36840700001)(46966006)(36860700001)(70206006)(47076005)(70586007)(186003)(478600001)(86362001)(2616005)(16526019)(966005)(6286002)(2906002)(54906003)(26005)(316002)(82310400003)(1076003)(6916009)(83380400001)(36906005)(36756003)(8936002)(336012)(55016002)(8676002)(426003)(53546011)(356005)(7636003)(82740400003)(5660300002)(7696005)(6666004)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:12:12.3923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 295ef8f9-59be-4a21-6ca0-08d92d2e586e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT057.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4811 Subject: [dpdk-stable] patch 'net/bnxt: check PCI config read' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/e00127b7777942fbb73efa904647f252acbd8857 Thanks. Xueming Li --- >From e00127b7777942fbb73efa904647f252acbd8857 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Fri, 30 Apr 2021 13:14:11 -0700 Subject: [PATCH] net/bnxt: check PCI config read Cc: Luca Boccassi [ upstream commit 52c33734587a135b55ff968626eabbd1167993b7 ] Return value where return value of rte_pci_read_config was not checked. Fix it. Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 25f99fbc70..242841a598 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4138,13 +4138,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index) struct bnxt_error_recovery_info *info = bp->recovery_info; uint32_t reg = info->status_regs[index]; uint32_t type, offset, val = 0; + int ret = 0; type = BNXT_FW_STATUS_REG_TYPE(reg); offset = BNXT_FW_STATUS_REG_OFF(reg); switch (type) { case BNXT_FW_STATUS_REG_TYPE_CFG: - rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + ret = rte_pci_read_config(bp->pdev, &val, sizeof(val), offset); + if (ret < 0) + PMD_DRV_LOG(ERR, "Failed to read PCI offset %#x", + offset); break; case BNXT_FW_STATUS_REG_TYPE_GRC: offset = info->mapped_status_regs[index]; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:58.619321700 +0800 +++ 0078-net-bnxt-check-PCI-config-read.patch 2021-06-12 06:53:56.370000000 +0800 @@ -1 +1 @@ -From 52c33734587a135b55ff968626eabbd1167993b7 Mon Sep 17 00:00:00 2001 +From e00127b7777942fbb73efa904647f252acbd8857 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 52c33734587a135b55ff968626eabbd1167993b7 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 115acda9b3..719eb68847 100644 +index 25f99fbc70..242841a598 100644 @@ -24 +26 @@ -@@ -4159,13 +4159,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index) +@@ -4138,13 +4138,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index)