From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D74CBA0C3F for ; Sat, 12 Jun 2021 01:12:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD38A4003F; Sat, 12 Jun 2021 01:12:20 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2060.outbound.protection.outlook.com [40.107.101.60]) by mails.dpdk.org (Postfix) with ESMTP id 7B9384003F for ; Sat, 12 Jun 2021 01:12:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YlGiRqCs4EN6nnHFzRtaEt7adZkMOBeRvk6dKXO3AN+4nrmFicuPPELygIESw/3QGDlL4b4JzWByP6hdxfwG4yKDqi6nD+odIxLIuIkbE6w3Tw7yW9DbTqjoMnpzTowdMJ/BgycpVYXLy5SQkyL4ns8QsoVqtQuCRFzFmXVfiPeHShH0PxBBjnYTaLazfTpQYTsfQxQHZlX+LdjKI721a0aPy6Uc2MpiKkzIL0VEtOw0HDgYa9I/adxNepAn9+eON9Eh0OSdT5LRxC0YLH5b5uR+1y41b6vIKyJ8TiQ0z2SdTAQ6+UipkZQ+B5iBl2RZjaWlt6dDZ6IC11EzxaJQgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BA45K2cZ+R/AvIEy8xrNKRdO/dgqMVDt4ueSUd9VfmQ=; b=JWPbxQlgw39OBBn5lXlrCEgo8moaQOZ0dScf4As2BfVc6rmtngHnZBeX+9u04A9kCqCjc0nZKWMGqCo2No5v3PFfCg6dJqOebIJwfe23bzFq7YjZozfxuXKd9wF5eH2BgzY6pxY62BvZag48zfGf+2tVaNUMZ81zyfInHbo9zWykGKrcGEatpxEsJw7CMH7N7sheM/trdJ8Uh75VzHX0XxcbNd6zeMXwI/pgCgxo9WDNRTqy79OhkTXRM3I6QQyvQukevqKmOafcg4l/Z9lALSVxvjBv3aThXhtsc0XA7J9576+49LwI9q9E8AXnXy0tXoWkdBzpQa1ho9R5TguCSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BA45K2cZ+R/AvIEy8xrNKRdO/dgqMVDt4ueSUd9VfmQ=; b=RIr5Qouszqg+59yUzQXT1xVqq5K5VS4ir4slImkUbUolqXCdu0yYaTbRTy+8U79KV+mw5pyHldPYq2vAYKkuDOJLurx9FLebuo2fYfR7ekw5FI/SEDrEPERHx8qXw1Jyus6+4MBcM+NydFWZ6L9TUEmmSqDZ7hMOw0ntOPuAizhT5MMAKtdXBrwWSXuUfze4AFwRQJ4h6+C6w1QNrG6VBzEmR9tD6cnALiyqGUVKg8h4cXO6pzkRznrJv3D9aTDa69reJqsQR2pwGg69+p5HLMiyjNi2NxbiXq4pGk9XJbweozJyhKc/gN/0KwDFewVnE9gF7p6JQq9+1Kk7QjeQ1Q== Received: from MW3PR06CA0010.namprd06.prod.outlook.com (2603:10b6:303:2a::15) by DM6PR12MB4027.namprd12.prod.outlook.com (2603:10b6:5:148::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:12:17 +0000 Received: from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2a:cafe::fc) by MW3PR06CA0010.outlook.office365.com (2603:10b6:303:2a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:12:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:12:16 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:12:14 +0000 From: Xueming Li To: Kalesh AP CC: Luca Boccassi , Somnath Kotur , Andy Gospodarek , Ajit Khaparde , dpdk stable Date: Sat, 12 Jun 2021 07:02:54 +0800 Message-ID: <20210611230433.8208-80-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca16cb41-a107-4bd9-70d2-08d92d2e5b1f X-MS-TrafficTypeDiagnostic: DM6PR12MB4027: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4SEEe3Q9iLgyqIZdm0vdIgYo6jNVX0wPcFK4tf439yrI9raPcl0/d0GcaYLkCvDC5r5Uk/5fnUyi/GlYvtlUPbndf2APUenU3tD/Kn2W3KqNl/Yn4gqshSYhiPaBcmlywbPlI2fsnBpMsUUlOuHJ8pdJe298zUfAG26+X+DqEw+ZMpH3sL6+vEPEtZZUQFu+MjEeLZ5um/0C3IK07ZmsvI8ddXTsfcNp+pdM6sHjcHwUVA3LzpFCtMWvbLtlnBH/gprT/hwKG6xD9W1Vm0Rhga7GKoRR4Oxufr6QOSU4NeLii9wya6ZpT9NWqNQUnw7sOClI0rdxawRzqFgF7khqeVL5pyP9fJtlFpKY6Bh8m2SIpy5PQVCWos04wvTYPd6XiYZFzg+AfH5dvhr4CAHU9TBzcCqaVtliwvgiAjBpep8Kjzgpogdd7y9unitrzsDPzoVgfan3yFqHtypIZNEjKM8itubncY+nKLiJSJ0I4fmaAB/4IpVWK071z4X6GKBCAVi4D87rUKxG4EfGhVBG6hFYtSm/iEFQgDC+YsRKBVRFBA1lKUhJJtFmQqjUp3vkIjj17DWLovnzdbdom0yUpebaN9XPG/+RWWBDhYoXkqMoazyBdiha5vqAvk0OwmJENTYT+0Bmx9VRqwdSz5aEFDMBxiPESPAFPGpejAa3wbYTqXSaGFELi3/4IOJfgqav8+CZab2Dp83LFxBKKLrsXxiRFZ/i2kBAqSQmkA8B96Y+tMNGqUDxGIf2oyptmaliFkjzonitFuQCYOd0VxTE9hXh+pT4Ymqh77IebGaIZnQrlpiCakNw5/cJdHTW8SZk X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(46966006)(36840700001)(2616005)(966005)(8676002)(82310400003)(426003)(26005)(186003)(16526019)(336012)(70586007)(36860700001)(47076005)(70206006)(1076003)(2906002)(5660300002)(478600001)(6916009)(83380400001)(4326008)(54906003)(6666004)(6286002)(86362001)(8936002)(53546011)(36906005)(7696005)(7636003)(55016002)(82740400003)(356005)(36756003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:12:16.9069 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca16cb41-a107-4bd9-70d2-08d92d2e5b1f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4027 Subject: [dpdk-stable] patch 'net/bnxt: prevent device access in error state' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/a0a21cb0c7f032799d9a9eee1ccedcddb78121f5 Thanks. Xueming Li --- >From a0a21cb0c7f032799d9a9eee1ccedcddb78121f5 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Mon, 3 May 2021 10:51:50 +0530 Subject: [PATCH] net/bnxt: prevent device access in error state Cc: Luca Boccassi [ upstream commit c967098a4c0aafa0cb244ab9423fdea3d943d1ab ] Driver should prevent any DMA with the device when it detects an error. When firmware is in fatal state, stop tx/rx by assigning them to dummy functions. Fixes: be14720def9c ("net/bnxt: support FW reset") Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Andy Gospodarek Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 242841a598..1498f4a653 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4254,6 +4254,8 @@ reset: bp->flags |= BNXT_FLAG_FATAL_ERROR; bp->flags |= BNXT_FLAG_FW_RESET; + bnxt_stop_rxtx(bp); + PMD_DRV_LOG(ERR, "Detected FW dead condition\n"); if (bnxt_is_master_func(bp)) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:58.665550700 +0800 +++ 0080-net-bnxt-prevent-device-access-in-error-state.patch 2021-06-12 06:53:56.370000000 +0800 @@ -1 +1 @@ -From c967098a4c0aafa0cb244ab9423fdea3d943d1ab Mon Sep 17 00:00:00 2001 +From a0a21cb0c7f032799d9a9eee1ccedcddb78121f5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit c967098a4c0aafa0cb244ab9423fdea3d943d1ab ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 719eb68847..822853a008 100644 +index 242841a598..1498f4a653 100644 @@ -26 +28 @@ -@@ -4275,6 +4275,8 @@ reset: +@@ -4254,6 +4254,8 @@ reset: