From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1E4DA0C3F for ; Sat, 12 Jun 2021 01:13:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAA304003F; Sat, 12 Jun 2021 01:13:07 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2054.outbound.protection.outlook.com [40.107.236.54]) by mails.dpdk.org (Postfix) with ESMTP id 9A16B4003F for ; Sat, 12 Jun 2021 01:13:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4XGP5RO9NQgKiQUceVRRfBwJ5LmAdJccSxttRbtN+kZqoEE3+xHojOb3sumo2AKZoC0VV1XdKN4W8r3hKKfxdLYkWhlt7f13rs/OqXBf1wlg29lWeWOjtlFe2RU32uNP5X92d/SJnc/AJql2u+gx9ZigdoDMaBlATKNLComiE6rU6uTpjEYVKVRGgFMzgxE3HyzdHf7FV8IJ+HVegWQIRWyfLayFOhlGVbr+6MCMxahBBzCOvZ3JmcWHfq3J+kb09F/Bpk+KBq2yA8OCMXcNJVzhZY9uq2zw4MVQtNSjGyCI0wlMJ2kIdT5ObCmzLHUrjSIUqp+1KFlhUCy9sJdqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfFC/haK3bX5N7s6Oibu6mOeJVoroPJglSs/xus/ZU8=; b=Kw6gGsrGcnH1rCkB1tauuvZgo4foyGVv+C2b9uReVCGt7eFgDCL4xtnQlxtc8PF62zY9t2+BL7mqWdN1U6fd6jaq7oCB+Ya3Dy88hkLufRotdZpwQLcGie1rrjRWhqvy1TWlzHq/GhJKublxsNnbBdRGjYqPqmLIQzv+X/0QqVCLFM3BV5ascUbwzy849g2QUKccW3FL/PiBr+k5DnvfPteMVLpHJ4RbG9GX55cGw26XYXNYJVoy8y4GR+x8LPJCqGKr2J1FFgARkt+XwlbmGo0eBmlibb+O05+gh8AuGJ7yej2M+ms/0N5iPEmy8Sh1gPj4qqYL/BPxbXk4gJ13Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfFC/haK3bX5N7s6Oibu6mOeJVoroPJglSs/xus/ZU8=; b=kATg6LxKk7MxcJ9du08h95aMw9yWRycN1Mm1BHCosfUuCWN5UTU0E9uXb6wq7QVD97FBv9cfxyGU0/jOLZ2rbc8g2R5QvJBOy62M7a93fh6ttYQGEyXwcKyi4TO4xFcuD8bsMMjallM+z6AstbAkiCczTbYFS8BltkksQcx4afziouKmWD7U7T1OfB/3TIabZ0PWW+3kDLP/YUEvi6kbDjDeLoBIrXBbCBP8QblK8jmY2GUHhot+GhNfW5uTJw62DsbWXwCelpRmfPu80fkSJt6DQy7LxTWBEOF/qtyfPZH5+wKXyUR2wQTRicPSWPXFnJCmcbV9p12nfUEBM8WJrA== Received: from MWHPR2001CA0013.namprd20.prod.outlook.com (2603:10b6:301:15::23) by BN6PR1201MB2483.namprd12.prod.outlook.com (2603:10b6:404:a6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Fri, 11 Jun 2021 23:13:05 +0000 Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:301:15:cafe::e6) by MWHPR2001CA0013.outlook.office365.com (2603:10b6:301:15::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:13:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:13:05 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:13:03 +0000 From: Xueming Li To: Chengwen Feng CC: Luca Boccassi , Min Hu , Harry van Haaren , dpdk stable Date: Sat, 12 Jun 2021 07:03:00 +0800 Message-ID: <20210611230433.8208-86-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98315a89-9888-4f4b-cd13-08d92d2e77cf X-MS-TrafficTypeDiagnostic: BN6PR1201MB2483: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8djFhdrgys33sBRaooQCIUpurQ/l7sE4iuuzDPGLhhxbnSDtLRiQBLlhLks279djVOhGp6Hx9w0SX3nTd26csEahyu/v768Sbj+27goB5VIYOld06Dmgx53izD1aoqDTGEKy+Ab5iQaeexbpi1jqyHKQpeAdItmjJ9yGAQhBwGyVVDWmu9uBRPSgf2usDj/2SJpX6Rk5Z5RHfqSThSpC1Xez7dUdJqRdrXacxSsa/kvd5SUnamgdkLZJVtpV0+0CodIJm6eq2NOdzOb1+ODYIceSRkd9gKLw/94L+m9pBLheAp6guG8jVE4kVix+VogOqj9Bnhgl03wGbsYCI6+g68pd/tdzZIXE/f4vGunsl9EL10bLdMP/lGJ/3BJeIT2M9VyEkU0KHaL8JiNb3wFxd8GECbqOKNpO6jvSjlgLH7yNWg9Uhe3PmJWW6whb7tzP5BLvxDu8xocsYgnw/mGGEuOqaWu2Intj/Ega9FA2cISPm/BWmDjTUleumXY0B396KbQS4jpv1mKp19YfKwSRNM4Om9XwZt5os0LnWOKAAUmBKRU/An6kIPg4J4wqwFLLv1F4OAnuFdFbbvEmEJNF3mTIWvsraG4cimNlyU4hgUljdqDHPyU7gv1byisRMyLiaejsztU0R7vmW+7aExNygljwTCqIvdSMEWBu4RYVfvbPUcI61p/QvTrazSR2oE5b0wYgff6hh/bl4EZ2Gh1nCrQEL0es4kGF70YcY2gxpsYxPkjCwXCtKiDbMRc+LhoZp9KTPyRn3B2HhClyAqDQzEgfk2n27r88ok6iyWTmSkRDUcPex8fgJi3Vm3Xw+PS4 X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(54906003)(966005)(36756003)(53546011)(7636003)(70586007)(316002)(4326008)(82740400003)(55016002)(36906005)(336012)(70206006)(478600001)(6286002)(83380400001)(426003)(2616005)(1076003)(82310400003)(86362001)(2906002)(5660300002)(47076005)(36860700001)(26005)(7696005)(6916009)(186003)(8676002)(16526019)(356005)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:13:05.0459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98315a89-9888-4f4b-cd13-08d92d2e77cf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB2483 Subject: [dpdk-stable] patch 'eal: fix service core list parsing' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/2194792b3acff9fee485ecd5fbe65ce7ef7f7d13 Thanks. Xueming Li --- >From 2194792b3acff9fee485ecd5fbe65ce7ef7f7d13 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Wed, 5 May 2021 12:10:07 +0800 Subject: [PATCH] eal: fix service core list parsing Cc: Luca Boccassi [ upstream commit 97ca1e786b25182199877393978decbed6608a78 ] This patch adds checking for service core index validity when parsing service corelist. Fixes: 7dbd7a6413ef ("service: add -S corelist option") Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Acked-by: Harry van Haaren --- lib/librte_eal/common/eal_common_options.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 622c7bc429..94b560a8ab 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -757,10 +757,10 @@ static int eal_parse_service_corelist(const char *corelist) { struct rte_config *cfg = rte_eal_get_configuration(); - int i, idx = 0; + int i; unsigned count = 0; char *end = NULL; - int min, max; + uint32_t min, max, idx; uint32_t taken_lcore_count = 0; if (corelist == NULL) @@ -784,6 +784,8 @@ eal_parse_service_corelist(const char *corelist) idx = strtoul(corelist, &end, 10); if (errno || end == NULL) return -1; + if (idx >= RTE_MAX_LCORE) + return -1; while (isblank(*end)) end++; if (*end == '-') { -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:58.817932600 +0800 +++ 0086-eal-fix-service-core-list-parsing.patch 2021-06-12 06:53:56.410000000 +0800 @@ -1 +1 @@ -From 97ca1e786b25182199877393978decbed6608a78 Mon Sep 17 00:00:00 2001 +From 2194792b3acff9fee485ecd5fbe65ce7ef7f7d13 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit 97ca1e786b25182199877393978decbed6608a78 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - lib/eal/common/eal_common_options.c | 6 ++++-- + lib/librte_eal/common/eal_common_options.c | 6 ++++-- @@ -19,5 +21,5 @@ -diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c -index 66f9114715..97ab6e00fd 100644 ---- a/lib/eal/common/eal_common_options.c -+++ b/lib/eal/common/eal_common_options.c -@@ -758,10 +758,10 @@ static int +diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c +index 622c7bc429..94b560a8ab 100644 +--- a/lib/librte_eal/common/eal_common_options.c ++++ b/lib/librte_eal/common/eal_common_options.c +@@ -757,10 +757,10 @@ static int @@ -36 +38 @@ -@@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist) +@@ -784,6 +784,8 @@ eal_parse_service_corelist(const char *corelist)