From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E81DEA0C3F for ; Sat, 12 Jun 2021 01:13:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E250340691; Sat, 12 Jun 2021 01:13:10 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2054.outbound.protection.outlook.com [40.107.212.54]) by mails.dpdk.org (Postfix) with ESMTP id 0FFD04003F for ; Sat, 12 Jun 2021 01:13:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dJM9S1t25Saxp1/54oyu7loGc5Tz3nbiz63xLRF9i169RCKtmPOW8/bgiszwTBDhwMDkptII0nGmJUK4zgz9MUYa+550a6eLNDjyGbyqBY0HJ3WszkMfi+I8x6Vq1v5dtLUCIydG28rZXuZHxJyRw0DdSX0LwTmVSPYCYCfKEEZNglORsmBhi9pK4FV37lW8wctEA2eNAyD2KnxQWZapercuIV3sFXqo11AF1DhmrIc6K+aUGNaOkz2PalqpooRrc7THAMySyfp1M1btJ7p3vy6hg+nPTyVZWbKKtS+VwN9jnVrYDLin6emAhX0aSE/fk4eB9SLq5hZ37SrInZgpvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7SVyoZimkprvDtEgdopuvPt+a9K4swRt22U9JuxEscU=; b=ocItZ9oBl+PttKK9sh1slQ3Wd6Hv4EVwCSxAdPbjGg46idek2xLRiVd7p2IlvHYVAGWGeBGTp6qZDx1wG1r0Puqrz5ohr3U4lWHqQPe29ND9sIEQhHhdZxGWjyCDbqhzZ6RG7d7mPdhAWo59kTzya0D0kKYgZb6535HI7Wh5NBnLzW4rz51/gPqMGqs76kUws/PAv8D6r5aLfWG2BHrTVmIv0j/UY9SH8JKvt5lxZF8ebcgqVNvNuaAXC4ulmHFidclHN4L3KCx6qeIwae+4N7/GVBl1XgcCbxf4SNzcCXO+nTUhDJ+CwGR25q2v1rK8b8wHgVGZAOZeT6k46KAAgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7SVyoZimkprvDtEgdopuvPt+a9K4swRt22U9JuxEscU=; b=heKb2sJFrp7zxcPqu+/IbrQEi5XeJp+Ubjrjy3k373EWf4rkUCSeEa75Ez4W1++jO+DkvjKvqFXUYH8+gxbUp8hvBmCVCHRko6hK6pq72PE1zJib/ZKzu+yxBpwaHLSV2bUf1Xbgeqy5599hJdZ3XwctvKbq4p9oruBXjKsVCkRIlm3BrDIx6Cfc9NabeF+dwLrZG7qqFrEFAXNqx4H2E64oRNbwHHsn13gOt67BiCsw9j6gYvXXBh5N9wdDxnG3cKcpW/vOAz+hAuCkRGlBtRYoHbBRPbiaf1PE83KIe/gTpjBQrDLlAbdGDsRLsLccwRWIL9Hpv2nUd57LfVwJQQ== Received: from MWHPR2001CA0011.namprd20.prod.outlook.com (2603:10b6:301:15::21) by CY4PR12MB1701.namprd12.prod.outlook.com (2603:10b6:903:121::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:13:08 +0000 Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:301:15:cafe::bf) by MWHPR2001CA0011.outlook.office365.com (2603:10b6:301:15::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:13:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:13:08 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:13:05 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , Nicolas Chautru , dpdk stable Date: Sat, 12 Jun 2021 07:03:01 +0800 Message-ID: <20210611230433.8208-87-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fba6d20d-b6cb-48c7-4eed-08d92d2e79ef X-MS-TrafficTypeDiagnostic: CY4PR12MB1701: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3GKKVZ9iD7XbnDCpnYTNSRCaVKESzEUJurdsRN88d5Wgf08hA0xO1tezKviis2jJFqDeAaBBFCHGoVG2a1A3eqMcw1NOUvfHDL8L/vGpgawnFeQWgSinN9h8YKH8v3Oed8LeN8TF8EX5ozVZWAxsgwbgiq+u4/D75QIAMvvd+v/1i5S68RkpPi+mOz/shkQUGQC3j3aEAjrbBhCX23/XSJje7yJkfn7xFOvQktiumPqVjZeLEBeJFZt2SHo6Wg5yeDPJ8ujq92KTtEV9ebIQYRT3YOqloUwI0yUZkhUaXLMImigmvqJXO+F+8J59ZTMd9QExlxKkdphwEQrjugamdGjnX0CHO6bxkK8BWgIGfnl9WtNvkuiSsmd1fxdjAS3X6evzo5920Mfj7cSQUL3LuI50TFi4h1/aCG0XHcGhM8dPzxnQAgpeOUJ6nwWKb68nqPpHwSPg0w6zCoaSSnjqunqWCLiizMnR4zPuKqzOu/vMYv5hHb1s/cfKdGxrjUUGBWnAVL6dS7N6O4OoFE4vpKtKG3DAx0Ko4yXLStNJvKHCuEnRDVh6gAEFoiwkn130fwPNaXYlIk8iz3lElIWZbMEA5FQgyT70A6yYiYB9zPzIdhRrlp8QwNRfk+cJw2CIH/JPiGE+Xrl6R6ILWBmon501seDGVgj/nq4S8jM/QNuImnYGtn2FRKKDp5r+m7br79HWQw4v5LPebkxmRYJkZr13OQTJ4bKLJONPaUSNjIRt1PZa+2pbmc6U4tgUfXnzNm7z7DnoOZqzfsUP1iM7YDRKWs3175XhMzGKUu7z19cVkCBTiWfXkAi3c8KS2vda X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(376002)(39860400002)(46966006)(36840700001)(83380400001)(186003)(6916009)(82310400003)(426003)(7636003)(47076005)(82740400003)(36860700001)(356005)(16526019)(36756003)(6286002)(2906002)(7696005)(1076003)(54906003)(6666004)(53546011)(336012)(966005)(55016002)(478600001)(36906005)(26005)(5660300002)(70586007)(8936002)(86362001)(70206006)(8676002)(2616005)(316002)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:13:08.5358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fba6d20d-b6cb-48c7-4eed-08d92d2e79ef X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1701 Subject: [dpdk-stable] patch 'app/bbdev: check memory allocation' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/90ca87dd693b18c69449075c447911f42827289d Thanks. Xueming Li --- >From 90ca87dd693b18c69449075c447911f42827289d Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 17:25:05 +0800 Subject: [PATCH] app/bbdev: check memory allocation Cc: Luca Boccassi [ upstream commit bc4c9418ee0fc22c480c236846af7fbad923ba89 ] Return value of a function 'rte_malloc' is dereferenced without checking, and may result in segmentation fault. This patch fixed it. Fixes: 31a7853d1ed9 ("baseband/turbo_sw: support large size code block") Signed-off-by: Min Hu (Connor) Acked-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 59b37ede4a..622ba70c67 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -957,6 +957,9 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs, if ((op_type == DATA_INPUT) && large_input) { /* Allocate a fake overused mbuf */ data = rte_malloc(NULL, seg->length, 0); + TEST_ASSERT_NOT_NULL(data, + "rte malloc failed with %u bytes", + seg->length); memcpy(data, seg->addr, seg->length); m_head->buf_addr = data; m_head->buf_iova = rte_malloc_virt2iova(data); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:58.844915700 +0800 +++ 0087-app-bbdev-check-memory-allocation.patch 2021-06-12 06:53:56.410000000 +0800 @@ -1 +1 @@ -From bc4c9418ee0fc22c480c236846af7fbad923ba89 Mon Sep 17 00:00:00 2001 +From 90ca87dd693b18c69449075c447911f42827289d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit bc4c9418ee0fc22c480c236846af7fbad923ba89 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 45b85b984c..f94e2a94d0 100644 +index 59b37ede4a..622ba70c67 100644