From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B89FA0C3F for ; Sat, 12 Jun 2021 01:14:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41A644003F; Sat, 12 Jun 2021 01:14:04 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2058.outbound.protection.outlook.com [40.107.244.58]) by mails.dpdk.org (Postfix) with ESMTP id 235D64003F for ; Sat, 12 Jun 2021 01:14:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFnJs04a8XZ5supwsz6XXRLRliJ3R8AReWrGxoDNkh9RvUH/gKm8Dx6kblTelyRxL5uuQKNGsoKrshlltc1HwPUXAHi17y2w0hNhwhxCC04eruKTXZSkZX1l1OF49fFuQUt8a4sHGwwR+6xnpNDT5/2dgde8BKkl8Ml/Z7L1CIWzABEglCNKqHyjyYQhWINpJvS9dA7kLfFTAGTXrwA1FUxAKWZgwdL/lU9DT0bNg15iXFHb4CDSH70wAaKgKm5TjUJjwpoX68XBvlFg/h0I+yt54OWGaKUSAGr/6CxZpJv3O3l/XCqk/omfvdXeRCuW0y+EUp6XO49Q68Upo4u8Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++kSFhPlz+u4GyVRs76Cp7je8UndqzlkwEErWRl8Cjk=; b=HDSVlj+JZhPmJkUZOyZ2+HDYvQPMJ5JkipmbRmGyJWPjOWeGOlp5u1bwcVcPYHzCTNhT9crbhg1IDH3WQlgsd0sTmp1EOtXOP5NBiUZFj+2C788u01TXoQDRanYeCXcuiT0xsKZhM8E6Tsn1ajuPnCHFjs+wFhVhX65lixvfM5lzc43FyrvdcViaG3kHQO5s6McgGLqam+CrN0EUsSk+8dNOGog97L9knrcPjTelpVmqn10bddPZG3b8L6XPpM4nTeTo/m+GuC3RiintNlMlt0dTNucyHfSTdFJVffiAmha33svQitRKkqVjABC88/qgEAB4vngEBw61lHLdezmRog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++kSFhPlz+u4GyVRs76Cp7je8UndqzlkwEErWRl8Cjk=; b=S4tpHd2mL2zAnW4VYTzY6f5Empo3NuULnUXVthkUWnGjQ+FgCW+xGYgQ0L3FzUrKfWe1neBmEs6quQPhyNKPtjm42glflyCxpq4HpS803xX3styhHb9k0RAlC2AcR+VBMFjxDLufINq3fpxeTyBKIHwuu9gBlv1MNqEDw99v96Rvo6xqM7jSADoHzUdR97RyshoS8VV8wlLogKthnytX+xLaner8gXJczVwvwMElKY0XihRw/BnGsYXaTFyVGPy58/wW2fbjcPDnb6WgBvvaktO0G9WK0xE1/gjmD34QkyFhqEMweJYNHZfW1LQTCPI++sBz0x2CmzSO/QtePH5P6A== Received: from BN6PR17CA0037.namprd17.prod.outlook.com (2603:10b6:405:75::26) by BYAPR12MB4775.namprd12.prod.outlook.com (2603:10b6:a03:107::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 23:14:01 +0000 Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2603:10b6:405:75:cafe::ae) by BN6PR17CA0037.outlook.office365.com (2603:10b6:405:75::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:14:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT063.mail.protection.outlook.com (10.13.177.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:14:00 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:13:58 +0000 From: Xueming Li To: David Marchand CC: Luca Boccassi , Bruce Richardson , dpdk stable Date: Sat, 12 Jun 2021 07:03:10 +0800 Message-ID: <20210611230433.8208-96-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dacc5daa-4bef-4d4d-12cd-08d92d2e98e8 X-MS-TrafficTypeDiagnostic: BYAPR12MB4775: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Yx7W/CWAWjJKk9CLWHu1MgeVqisXYVPVsIdcOZnzi6UfEjIg9XrMCrW8sKbddfb5h1Vf+1SvCAKfl56L15E4S/WK5t94VAsgupY88bd+ZlLpT6m4pwefXDcpNlO7JKx9/uZSfEZ8+8vh9pIWhI5G2gKs5V/qNIaVLyP/ewROVWFNFnKx1/ZOxwSO+86QNoBGNRCeTSdo409cY5kIOKZGcvGNeK9bJQVQE4YGfxie0ThH+MH2WttUNODIDl/4LwRWkL0ExBpZIkWHcbWyg1UcWAdtVr7lMvwgF/Pv5ltBNoYMLl6ClAWu9oRWwPzcPRK3Aj7AO0hqoNCb7Gavy2RKuHsj6zuujLMtQxnNRHesbVoHP5gGxAKmpn+m2UPbww79RAn/8qV6FCfRIx5fPScgjZ+tg20aBDtWJTz3I4kAVPksBGgdGRh93Pq0qfjXaPFQrZGZDRNahW6Ha6v7KuchejUq2R3aB65bE33g9/AxoIOIy9PSdP596Pc5e/6qPkDcEKT0BPWhUFv6olr72sHm6NyxTNYwCCnRcCNEEDVCgurvTluxv0hZZCo1eLuJ/bnTC5Mut7i0wk0opv6wQYn/47juPJLdnRQEKQwhqj79//H6QvMxwCOwwfNFLPdpy1uy0OqhmEtpggiBo6F0ngfERYuiHrPw/J6vR8IMNkVhC8xEKa9iBHhpzDuM3yIy7uDKOboh8UpD61XwoLm/zIkEjexSv5+7N6ePT7feOZKIQoXuXKqquzCVVj58CVHHmvzXMu63UbCBYsBMoFOu0hpBEr0Mk2c/ANADQokhNZMuPoKEH6FXvyrRBLjT3TkrHJY X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(36840700001)(46966006)(478600001)(36906005)(336012)(36860700001)(966005)(316002)(2616005)(4326008)(5660300002)(55016002)(426003)(1076003)(70586007)(83380400001)(26005)(53546011)(36756003)(70206006)(82740400003)(8676002)(6666004)(2906002)(6916009)(16526019)(54906003)(8936002)(47076005)(7696005)(186003)(356005)(7636003)(6286002)(86362001)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:14:00.4928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dacc5daa-4bef-4d4d-12cd-08d92d2e98e8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT063.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4775 Subject: [dpdk-stable] patch 'eal: fix leak in shared lib mode detection' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/3cb6827a324761d14641ddb2126e570bef5950c9 Thanks. Xueming Li --- >From 3cb6827a324761d14641ddb2126e570bef5950c9 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 6 May 2021 12:06:37 +0200 Subject: [PATCH] eal: fix leak in shared lib mode detection Cc: Luca Boccassi [ upstream commit b81bf1efe3ff7bf6bedf4dcce1e3fb90ac9c8d3c ] This is reported by our internal covscan: 1. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: alloc_fn: Storage is returned from allocation function "dlopen". 6. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: leaked_storage: Failing to save or free storage allocated by "dlopen("librte_eal.so.21.0", 5)" leaks it. # 506| * shared library is not already loaded i.e. it's # statically linked.) # 507| */ # 508|-> if (dlopen("librte_eal.so."ABI_VERSION, RTLD_LAZY | # RTLD_NOLOAD) != NULL && # 509| *default_solib_dir != '\0' && # 510| stat(default_solib_dir, &sb) == 0 && This leak is not an issue per se, but on the other hand, this is easy to fix and I prefer not having to waive this warning later. Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_options.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 94b560a8ab..f8ab47435d 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -508,10 +508,14 @@ is_shared_build(void) } while (len >= minlen) { + void *handle; + /* check if we have this .so loaded, if so - shared build */ RTE_LOG(DEBUG, EAL, "Checking presence of .so '%s'\n", soname); - if (dlopen(soname, RTLD_LAZY | RTLD_NOLOAD) != NULL) { + handle = dlopen(soname, RTLD_LAZY | RTLD_NOLOAD); + if (handle != NULL) { RTE_LOG(INFO, EAL, "Detected shared linkage of DPDK\n"); + dlclose(handle); return 1; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:59.100017400 +0800 +++ 0096-eal-fix-leak-in-shared-lib-mode-detection.patch 2021-06-12 06:53:56.450000000 +0800 @@ -1 +1 @@ -From b81bf1efe3ff7bf6bedf4dcce1e3fb90ac9c8d3c Mon Sep 17 00:00:00 2001 +From 3cb6827a324761d14641ddb2126e570bef5950c9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit b81bf1efe3ff7bf6bedf4dcce1e3fb90ac9c8d3c ] @@ -26 +28,0 @@ -Cc: stable@dpdk.org @@ -31 +33 @@ - lib/eal/common/eal_common_options.c | 6 +++++- + lib/librte_eal/common/eal_common_options.c | 6 +++++- @@ -34,5 +36,5 @@ -diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c -index 97ab6e00fd..ff5861b5f3 100644 ---- a/lib/eal/common/eal_common_options.c -+++ b/lib/eal/common/eal_common_options.c -@@ -509,10 +509,14 @@ is_shared_build(void) +diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c +index 94b560a8ab..f8ab47435d 100644 +--- a/lib/librte_eal/common/eal_common_options.c ++++ b/lib/librte_eal/common/eal_common_options.c +@@ -508,10 +508,14 @@ is_shared_build(void)