From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA44A0C3F for ; Sat, 12 Jun 2021 01:14:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99D854003F; Sat, 12 Jun 2021 01:14:08 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2074.outbound.protection.outlook.com [40.107.236.74]) by mails.dpdk.org (Postfix) with ESMTP id D2C81406A2 for ; Sat, 12 Jun 2021 01:14:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O+uzeyFLD4Bzdq46uTCCyhy+QmYUKfgmisz4kmAmbSVBVzGVnCpMPB4te6IwC+GdZe+ODNw3Res4YuQQDSnMgktLM9kwLD9ee4eGnF82xQ3KPha3AlijexSGoG+QgDmC2XTe5eq5B+f1KXVIAiScH7DvRdhU5TteLDEWaCeGa4qxtbE7t3WZqKNM7IqeWFd+/skZDBe7Dt3gOMqAdQWxummyOA3u9RBxw3VMw0oYIQuN/5LxbdKo6lRfXUJ2SIauVDzXQK3++KlnkvGFI95xCcMCnAZxJbsl3uJqqfgJxIJTzl88w849sB11B8Wzs+KMePS7WUHK/ciFaOAiB8RauA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWirN1MTnYbDASgNQHq0El73hVANKMXKNL5i2z0kJ+w=; b=gQHI80YsScgO/bSjttuwhhUn8vEde/RPxPHxmV85OscqD3Jks81k6+6wHINGVhwdE39x2klGV+HS2hOjthcs26zOWJB9FWcEeGDf1ou//fN6GZnxVhm1KV+4AI29YSbC3QiYtMHS9ATX3IcxFAbb1YMfH5Ba4bWej8Vq8mB8YhdYP8mNh8AMH45s2BAM1m/Wrfc7B4UeOeO/H3Is4LjQU40shO2lEYkkC+YwgmgxuO6MD5uRQAakValO39Qr4SqX3WoH6E0Y2T2l77fQl1cByETg1ZeXggJsvOBWL9xk3o9kUxKYVMbEU8Llhf5k2QfVFjTVdK9vu1MGMLRyAg1LAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWirN1MTnYbDASgNQHq0El73hVANKMXKNL5i2z0kJ+w=; b=LbXSfl7v6XsDoP6WxLdGjYpMnFFWbpB+JlbKekI9IsDv6f5spNUwJdt0on2Njed/sUluUUXz+oPJ4lNUvzP5tBwtGtKEyvAapKXmt75a9TcDBFRa+gtEvZCFimTnI2cbll+lEITiuZTGeg1+QYZ25+6QATRDu9zTBtHWRtgLCiNEIeWguw1zqY7ZdNhHT8NCADav8vIe/5WWP/MxKU/g9m0cBBFAgTzpOjwFPU8UHlpNOd10mZewGum/IFCFwx9R7MhGwNb0132/earLJFjbtfmusBQkamMnzjOu2lnhyUTWIgDJkScTECHeg2TSYRPT1ztXcgiYG+QE7voKdWKtPw== Received: from BN9PR03CA0605.namprd03.prod.outlook.com (2603:10b6:408:106::10) by DM5PR12MB1322.namprd12.prod.outlook.com (2603:10b6:3:70::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Fri, 11 Jun 2021 23:14:05 +0000 Received: from BN8NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:408:106:cafe::22) by BN9PR03CA0605.outlook.office365.com (2603:10b6:408:106::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 23:14:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT013.mail.protection.outlook.com (10.13.176.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4219.21 via Frontend Transport; Fri, 11 Jun 2021 23:14:04 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 11 Jun 2021 23:14:02 +0000 From: Xueming Li To: "Min Hu (Connor)" CC: Luca Boccassi , dpdk stable Date: Sat, 12 Jun 2021 07:03:12 +0800 Message-ID: <20210611230433.8208-98-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611230433.8208-1-xuemingl@nvidia.com> References: <20210510160258.30982-229-xuemingl@nvidia.com> <20210611230433.8208-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9387562d-16fb-4309-b512-08d92d2e9b86 X-MS-TrafficTypeDiagnostic: DM5PR12MB1322: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vOhHfUbMwyYSFQoR35Fjz/QzxjBU4LOW5CJETYRXCa23jrFq+oE08xbJMMfnVc3Toq6cjFFmmL7Vl+w/8e2SukA2b8fe7bcvGMGed5U+XdIeZODTrfH/52OG+id112kBjb/drnpRkQXr+j7TR6H6HmjjZFMY84ZwZtLdFsCDazpaJlRzGCu2zQ4rwvwo7cjuwx4LxcmEvbRtsGSEfAT+BJWHfmHkSZuxKRh08Wwgw6H4v/T+6k9kdaP9Xy6lVIYprfQvhZrJb3LtFn6DuGyN+vmoLpO8+DKW2oJLbgm9pX1JfYRfIrjDXs+Ulxd0L0RNYDR92ZFW+ij9680Y6jcCY6DS3flqPgzjBjsIVob77G+E+wMnuOv3w6FYkJnhU4v6rCHgfUnD+gsJv/qmczLKL/nKbteeIbvSz69FUdC5cSG3D4wED7GmSf4nyD8zx9kyGJlYyJQpQRaQYGfgRBJISJ0guxMKGJ/F97FaV4tLKJTQi7ofMcGyf8PGaRED+MAxldXdC5CxrND/jqbtMHto+Vncg/n4egtFjgqEt07Gcdd4fUEbp4vBMMRs/XfUzCfiUHsNgAv9iMojnCsjsKRDVBKIQo5vjXjnQ8CS3Ap1Vwnhe42hst+e23Qf3ZrpAA0Q7KQDxgVZJo+Kew9+xo3ygc86ZGh0EdBkzhL28huaFbg5aam+IAlu4N1ksr/+QO/6UpFxCGCCuHWWgm27u2AZrb2tuV4P1eyg6y4/J77MNTq5HUn1gRJzhokU7QWWnepkvyixmdyTbYygwcPqcprSsBjblkMIrDOYIKsW7HU1Ne86XeyefG0xHhTq3CMiyfdz X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(46966006)(36840700001)(336012)(53546011)(5660300002)(186003)(966005)(7696005)(1076003)(16526019)(478600001)(86362001)(70586007)(2906002)(6286002)(36860700001)(4326008)(36906005)(426003)(36756003)(356005)(70206006)(2616005)(26005)(47076005)(82310400003)(55016002)(7636003)(8676002)(82740400003)(8936002)(6916009)(54906003)(6666004)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 23:14:04.8709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9387562d-16fb-4309-b512-08d92d2e9b86 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1322 Subject: [dpdk-stable] patch 'raw/skeleton: add missing check after setting attribute' has been queued to stable release 20.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/14/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/45c0d2e47e48829ab9f75ac7883820d8d2a33eae Thanks. Xueming Li --- >From 45c0d2e47e48829ab9f75ac7883820d8d2a33eae Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Thu, 22 Apr 2021 14:21:46 +0800 Subject: [PATCH] raw/skeleton: add missing check after setting attribute Cc: Luca Boccassi [ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ] This patch adds return value check for setting an attribute. Fixes: 88a81bcecb7b ("raw/skeleton: remove compile-time constant for device id") Signed-off-by: Min Hu (Connor) --- drivers/raw/skeleton/skeleton_rawdev_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c index 1405df080d..484468eeb4 100644 --- a/drivers/raw/skeleton/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c @@ -295,6 +295,7 @@ test_rawdev_attr_set_get(void) dummy_value = &set_value; *dummy_value = 200; ret = rte_rawdev_set_attr(test_dev_id, "Test2", (uintptr_t)dummy_value); + RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test2)"); /* Check if attributes have been set */ ret = rte_rawdev_get_attr(test_dev_id, "Test1", &ret_value); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-06-12 06:53:59.150231000 +0800 +++ 0098-raw-skeleton-add-missing-check-after-setting-attribu.patch 2021-06-12 06:53:56.450000000 +0800 @@ -1 +1 @@ -From b97012825dfad7d30bbd1fa99ec6115eba6135ce Mon Sep 17 00:00:00 2001 +From 45c0d2e47e48829ab9f75ac7883820d8d2a33eae Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Luca Boccassi + +[ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org